paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 11:52:01 +00:00
Code Issues Packages Projects Releases Wiki Activity
24,305 Commits 30 Branches 160 Tags
be9dbccdfae5ac620c5e1626fabe0433ef67d24d
Commit Graph

2532 Commits

Author SHA1 Message Date
Rohitt Vashishtha
3550467899 markdown: Insert text in link-only inline image preview tests. 
Appends "Test: " text to some tests to make changes to the image preview
rendering. In the future, if the message is only a link to an image,
the link will be hidden.
 2017-11-27 13:30:18 -08:00
Tim Abbott
2210f627a5 signup: Switch active mirror-dummy users to an AssertionError. 
Previously, this was a ValidationError, but that doesn't really make
sense, since this condition reflects an actual bug in the code.

Because this happened to be our only test coverage the ValidationError
catch on line 84 of registration.py, we add nocoverage there for now.
 2017-11-26 16:13:45 -08:00
Vishnu Ks
b9bc1c2b33 Eliminate get_user_profile_by_email from test_classes. 2017-11-26 15:47:56 -08:00
Vishnu Ks
610eb557b8 backend: Make password reset form support multi realm membership. 2017-11-26 15:35:25 -08:00
Vishnu Ks
9f225360dc register: Make /register redirect to find accounts in root domain without realm. 
If there is no realm in the root domain don't show
registration form. Instead just redirect to find
accounts page.
 2017-11-26 15:32:17 -08:00
Vishnu Ks
bab0b913ee test_signup: Extract logic for realm-creation test to a function. 2017-11-26 15:29:16 -08:00
Vishnu Ks
1b5753d021 test_signup: Fix assertIsNone check for realm in RealmCreationTest. 2017-11-26 15:27:33 -08:00
Robert Hönig
0e0a8a2b14 queue processor tests: Call consume by default. 
This significantly improves the API for queue_json_publish to not be
overly focused on what the behavior of this function should be in our
unit tests.
 2017-11-26 11:45:34 -08:00
Tim Abbott
6968b540c8 mypy: Remove type: ignores that are unnecessary with new mypy. 
Mostly these can be removed because the broken LXML stubs were removed
from typeshed in https://github.com/python/typeshed/issues/525.
 2017-11-25 10:06:28 -08:00
Tommy Ip
e44b8809b2 /team: Render contributors list in tabs client side. 2017-11-22 11:33:24 -08:00
Harshit Bansal
2e7d0cb4cb digests: Fix new stream links. 
Fixes: #7479.
 2017-11-22 10:07:36 -08:00
rht
3ec90f8b33 zerver/tests: Use python 3 syntax for typing (final). 2017-11-21 22:01:19 -08:00
rht
0260ba82ca zerver/tests: Use python 3 syntax for typing (part 4). 2017-11-21 22:01:19 -08:00
rht
3bf9cd0656 zerver/tests: Use python 3 syntax for typing (part 3). 2017-11-21 22:01:19 -08:00
rht
e3daa09b05 zerver/tests: Use python 3 syntax for typing. 2017-11-21 22:01:19 -08:00
rht
e169bb0954 zerver: Remove simplejson dependency. 
Modified by tabbott to put the third-party code in a new file.

Fixes #6970.
 2017-11-21 21:51:48 -08:00
derAnfaenger
e526d0c144 embedded bots: Add views to access state. 2017-11-21 21:10:39 -08:00
derAnfaenger
cbadd3d430 embedded bots: Simplify StateError exception messages. 2017-11-21 21:10:12 -08:00
Tim Abbott
665fc594db auth: Set valid_attestation more unconditionally in social auth. 2017-11-21 20:14:12 -08:00
Tim Abbott
ade5b4ea69 auth: Convert SocialAuthMixin to accept a realm object. 2017-11-21 20:14:12 -08:00
Tim Abbott
0377288f68 auth: Fix GitHub test for invalid user account. 2017-11-21 20:14:12 -08:00
Tim Abbott
251a537e0d auth: Set the subdomain in more GitHub auth tests. 
This should have been set in basically all of these tests to set them
up properly, and this issue will matter after upcoming changes.
 2017-11-21 20:14:12 -08:00
Tim Abbott
732dd1b6a3 auth: Improve logic for invalid GitHub emails. 
This deletes the old mock-covered test for this, which was mostly
useless.  We have a much less messy test, which we extend to provide
the same test coverage the old one did.

While the result was the same before, this makes it more obvious.
 2017-11-21 20:14:12 -08:00
Vishnu Ks
766511e519 actions: Mark all messages as read when user unsubscribes from stream. 
This fixes a bug where, when a user is unsubscribed from a stream,
they might have unread messages on that stream leak.  While it might
seem to be a minor problem, it can cause significant problems for
computing the `unread_msgs` data structures, since it means we need to
add an extra filter for whether the user is still subscribed, either
in the backend or in the UI.

Fixes #7095.
 2017-11-21 20:09:17 -08:00
Tim Abbott
e0b56c72de ldap: Simplify logic for user creation. 
self._realm can't be None here with the new logic in authenticate().
 2017-11-21 19:08:45 -08:00
Tim Abbott
c4c8879cf7 ldap: Fix the error message for deactivated users. 2017-11-21 18:35:05 -08:00
Tim Abbott
3bfb19b5f3 Convert EmailAuthBackend and LDAPAuthBackend to accept a realm. 2017-11-21 18:23:50 -08:00
Tim Abbott
a7d51127fb auth: Convert GoogleMobileOAuth2Backend to accept a realm object. 2017-11-21 18:23:49 -08:00
Tim Abbott
07bc31f818 auth: Convert DevAuthBackend to accept a realm object. 2017-11-21 18:23:49 -08:00
Tim Abbott
4968631d1b auth: Convert DevAuthBackend to use a unique argument pattern. 
This helps ensure that we won't accidentally activate this backend on
other code paths.
 2017-11-21 18:23:49 -08:00
Tim Abbott
d63e9f240c auth: Remove unnecessary remote_user=None code path. 
This code path was only required because we had remote_user set as a
positional argument here, and thus we'd be running this auth backend's
code when actually using another auth backend (due to how Django auth
backends are selected based on argument signature).
 2017-11-21 18:23:49 -08:00
Tim Abbott
387c9109ec auth: Convert RemoteUserBackend to accept a realm object. 2017-11-21 18:23:49 -08:00
Tim Abbott
f17974ab32 DummyAuthBackend: Require being passed a realm object. 
We should now always know the realm in our auth code paths.
 2017-11-21 18:22:37 -08:00
Vishnu Ks
34689370cd settings: Create UI and backend for setting signups stream. 2017-11-21 17:39:51 -08:00
Vishnu Ks
3d2c9c6098 models: Replace core team with Realm.INITIAL_PRIVATE_STREAM_NAME. 2017-11-21 17:39:51 -08:00
Vishnu Ks
a0275a6257 actions: Send new user messages to signup_notifications_stream. 2017-11-21 17:39:50 -08:00
Tim Abbott
29408d24ff emoji: Rework reactions validation to have a single function. 
This feels more readable to me, and also identified a couple cases
where we were missing test coverage.
 2017-11-20 15:27:21 -08:00
Harshit Bansal
87b523f3ef emoji.py: Refactor emoji data consistency checking functions. 
Inorder to provide more explicit error messages I have merged the
`emoji_code_is_valid()` and `emoji_name_is_valid()` functions into
`check_emoji_code_consistency()` and `check_emoji_name_consistency()`
respectively.
 2017-11-20 15:27:21 -08:00
Harshit Bansal
9a4d5fe1f8 test_reactions.py: Extract EmojiBaseReaction test class. 2017-11-20 15:27:20 -08:00
Rishi Gupta
27babcf92b portico: Update error message for deactivated user. 
The installation admin is not the right person to get support requests from
deactivated users, regardless of the situation.

Also updates the wording to be a bit more concise.
 2017-11-20 13:40:51 -08:00
Tim Abbott
0667a62244 password reset: Simplify password reset form logic. 
Now that we're generating the URL inside the Python code, we can clean
up the context logic.
 2017-11-20 10:40:33 -08:00
Tim Abbott
c8edbae21c password reset: Fix error message for invalid realm. 
This is a lot cleaner than the previous model.

Basically rewritten by Vishnu Ks to actually work :).
 2017-11-20 10:34:55 -08:00
Tim Abbott
10fbafa13e PasswordResetTest: Clean up mocking of logging.info. 2017-11-20 10:32:40 -08:00
Umair Khan
95ba3e7cbb password_reset: Send email unconditionally. 
This was basically rewritten by tabbott, because the code is a lot
cleaner after just rewriting the ZulipPasswordResetForm code to no
longer copy the model of the original Django version.

Fixes #4733.
 2017-11-20 10:32:40 -08:00
Shubham Dhama
8b152fc109 email: Fix identification of chrome as safari on ios 
The user agent(UA) string for chrome on ios contains "crios" instead of "chrome".
Added the missing test for corresponding case.
Fixes: #7441.
 2017-11-19 17:07:33 -08:00
Rishi Gupta
f6bf11f5e6 portico: Add for/mystery-hunt. 2017-11-19 17:04:17 -08:00
rht
4a07214725 zerver/tests: Use python 3 syntax for typing. 2017-11-18 15:41:16 -08:00
rht
6c28c7e879 zerver/tests: Use python 3 syntax for typing. 2017-11-18 15:35:57 -08:00
Tim Abbott
462b7a1b3c tests: Expand test coverage of OurAuthenticationForm. 
This adds tests for a new more cases.  Some were already covered
elsewhere in the codebase, but it feels best for LoginTest to fully
cover OurAuthenticationForm.
 2017-11-17 17:31:38 -08:00
Tim Abbott
1ed50ee858 tests: Pass a realm option to login for non-zulip realms. 
This better matches the model of how having multiple realms should
work: you need to specify which realm you're logging into.
 2017-11-17 15:32:42 -08:00