Raymond Akornor 
							
						 
					 
					
						
						
							
						
						4dc7f5354d 
					 
					
						
						
							
							tests: Optimize test-backend performance.  
						
						 
						
						... 
						
						
						
						This optimizes test-backend by skipping webhook
tests when run in default mode.
Tweaked by tabbott to extend the documentation and update the CI
commands. 
						
						
					 
					
						2019-02-19 14:50:41 -08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Vishnu Ks 
							
						 
					 
					
						
						
							
						
						6d138bd3e5 
					 
					
						
						
							
							tests: Fix broken avatar_disk_path for original size input.  
						
						 
						
						... 
						
						
						
						string.replace returns the new string and does
not change the original string. 
						
						
					 
					
						2019-02-14 14:18:03 -08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Anders Kaseorg 
							
						 
					 
					
						
						
							
						
						f0ecb93515 
					 
					
						
						
							
							zerver core: Remove unused imports.  
						
						 
						
						... 
						
						
						
						Signed-off-by: Anders Kaseorg <andersk@mit.edu > 
						
						
					 
					
						2019-02-02 17:41:24 -08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Anders Kaseorg 
							
						 
					 
					
						
						
							
						
						e8b32a4b67 
					 
					
						
						
							
							python: Stop importing get_display_recipient from the wrong file.  
						
						 
						
						... 
						
						
						
						Signed-off-by: Anders Kaseorg <andersk@mit.edu > 
						
						
					 
					
						2019-02-02 17:08:57 -08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Steve Howell 
							
						 
					 
					
						
						
							
						
						7d58b05a51 
					 
					
						
						
							
							tests: Add capture_event() helper.  
						
						 
						
						... 
						
						
						
						For many actions, we make a single call to
send_event, and it's kind of heavy now to
properly assert we made one call, and we
don't need to exercise all the tornado code
to prove that the action was written correctly. 
						
						
					 
					
						2019-01-02 09:12:10 -08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tim Abbott 
							
						 
					 
					
						
						
							
						
						a0da4f6d30 
					 
					
						
						
							
							python: Clean up various if False blocks.  
						
						 
						
						... 
						
						
						
						Most of these are now-unnecessary typing imports; some are just
improved comments for those with other mypy motivations. 
						
						
					 
					
						2018-12-17 11:14:47 -08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								rht 
							
						 
					 
					
						
						
							
						
						a1ff44a230 
					 
					
						
						
							
							refactor: Add a helper function to create s3 buckets.  
						
						 
						
						... 
						
						
						
						This refactor makes upgrading boto to boto3 easier.
Based on 43d2f6286c 
						
						
					 
					
						2018-12-07 13:58:11 -08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tim Abbott 
							
						 
					 
					
						
						
							
						
						6a9e6503b7 
					 
					
						
						
							
							python: Remove unnecessary NonBinaryStr TypeVar.  
						
						 
						
						... 
						
						
						
						This was a potentially useful value (later superceded by use of Text)
when first introduced, but now that we're on Python 3, it should just
be str. 
						
						
					 
					
						2018-11-27 11:44:09 -08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tim Abbott 
							
						 
					 
					
						
						
							
						
						6e55342e21 
					 
					
						
						
							
							bulk_remove_subscriptions: Pass client object in.  
						
						 
						
						... 
						
						
						
						We need the client object to pass on to do_mark_stream_as_read. 
						
						
					 
					
						2018-08-01 16:48:31 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tim Abbott 
							
						 
					 
					
						
						
							
						
						02ae71f27f 
					 
					
						
						
							
							api: Stop using API keys for Django->Tornado authentication.  
						
						 
						
						... 
						
						
						
						As part of our effort to change the data model away from each user
having a single API key, we're eliminating the couple requests that
were made from Django to Tornado (as part of a /register or home
request) where we used the user's API key grabbed from the database
for authentication.
Instead, we use the (already existing) internal_notify_view
authentication mechanism, which uses the SHARED_SECRET setting for
security, for these requests, and just fetch the user object using
get_user_profile_by_id directly.
Tweaked by Yago to include the new /api/v1/events/internal endpoint in
the exempt_patterns list in test_helpers, since it's an endpoint we call
through Tornado. Also added a couple missing return type annotations. 
						
						
					 
					
						2018-07-30 12:28:31 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Vishnu Ks 
							
						 
					 
					
						
						
							
						
						53237d39aa 
					 
					
						
						
							
							registration: Allow users to import profile picture.  
						
						 
						
						
						
						
					 
					
						2018-06-06 13:29:42 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Steve Howell 
							
						 
					 
					
						
						
							
						
						a42492d0ac 
					 
					
						
						
							
							Fix very recent build error w/url coverage for casper.  
						
						 
						
						... 
						
						
						
						Example:
    http://localhost:9991/casper/casper-failure1.png  
						
						
					 
					
						2018-06-04 12:37:10 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Aditya Bansal 
							
						 
					 
					
						
						
							
						
						a85576149d 
					 
					
						
						
							
							test_helpers: Add use_db_models decorator.  
						
						 
						
						... 
						
						
						
						This is somewhat messy, but it's purpose is to make it easy to write
tests in test_migrations.py. 
						
						
					 
					
						2018-05-21 09:46:24 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tim Abbott 
							
						 
					 
					
						
						
							
						
						16d807d157 
					 
					
						
						
							
							Revert "test_helpers: Fix a nonexistent import."  
						
						 
						
						... 
						
						
						
						This reverts commit fa18913b8b .
We fix the typo when doing this, though. 
						
						
					 
					
						2018-05-15 16:08:29 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Greg Price 
							
						 
					 
					
						
						
							
						
						fa18913b8b 
					 
					
						
						
							
							test_helpers: Fix a nonexistent import.  
						
						 
						
						... 
						
						
						
						This module doesn't exist, and never did; the name appears to be a
mistaken variant of the module that really does contain ZulipTestCase.
So, fix the import to use the real name.
This would never have worked at runtime, which is why it's in an
`if False:`.  It's also an example of the kind of error that can be
hidden by `ignore_missing_imports`; we'd have caught the issue
immediately if we hadn't had a blanket application of that flag
in place. 
						
						
					 
					
						2018-05-15 18:14:33 -04:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Aditya Bansal 
							
						 
					 
					
						
						
							
						
						a68376e2ba 
					 
					
						
						
							
							zerver/lib: Change use of typing.Text to str.  
						
						 
						
						
						
						
					 
					
						2018-05-12 15:22:39 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								neiljp (Neil Pilgrim) 
							
						 
					 
					
						
						
							
						
						9e1dbde82d 
					 
					
						
						
							
							mypy: Final small migrations to python3.5 annotations in many files.  
						
						 
						
						
						
						
					 
					
						2018-03-12 11:23:30 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								rht 
							
						 
					 
					
						
						
							
						
						9a8d2244ca 
					 
					
						
						
							
							django-2.0: Shift to resolvers from urlresolvers.  
						
						 
						
						... 
						
						
						
						The old name is deprecated. 
						
						
					 
					
						2018-01-30 10:53:54 -08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Xavier Cooney 
							
						 
					 
					
						
						
							
						
						b0f501ff6c 
					 
					
						
						
							
							test_helpers.py: Remove unecessary imports.  
						
						 
						
						
						
						
					 
					
						2018-01-16 08:16:43 -05:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Rhea Parekh 
							
						 
					 
					
						
						
							
						
						b792a90842 
					 
					
						
						
							
							Remove unused imports in the codebase.  
						
						 
						
						
						
						
					 
					
						2017-12-26 09:09:31 -05:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Shreyansh Dwivedi 
							
						 
					 
					
						
						
							
						
						47fcb27e39 
					 
					
						
						
							
							invitations: Remove custom_body.  
						
						 
						
						... 
						
						
						
						Fixes  #7672  
						
						
					 
					
						2017-12-11 19:23:54 -08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Steve Howell 
							
						 
					 
					
						
						
							
						
						78041a5846 
					 
					
						
						
							
							mypy: Use more specific type for instrument_url wrapper.  
						
						 
						
						
						
						
					 
					
						2017-12-08 19:00:18 -08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								rht 
							
						 
					 
					
						
						
							
						
						33b1a541d7 
					 
					
						
						
							
							zerver/lib: Use python 3 syntax for typing.  
						
						 
						
						... 
						
						
						
						With tweaks by tabbott to fix line spacing. 
						
						
					 
					
						2017-11-18 16:09:04 -08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								rht 
							
						 
					 
					
						
						
							
						
						5ee40bf718 
					 
					
						
						
							
							Remove usage of six.moves.binary_type.  
						
						 
						
						
						
						
					 
					
						2017-11-09 10:00:00 -08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								rht 
							
						 
					 
					
						
						
							
						
						19bd335cbb 
					 
					
						
						
							
							Change urllib import to be Python 3-specific.  
						
						 
						
						
						
						
					 
					
						2017-11-07 10:46:42 -08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								rht 
							
						 
					 
					
						
						
							
						
						e311842a1b 
					 
					
						
						
							
							zerver/lib: Remove inheritance from object.  
						
						 
						
						
						
						
					 
					
						2017-11-06 08:53:48 -08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								neiljp (Neil Pilgrim) 
							
						 
					 
					
						
						
							
						
						792a580efb 
					 
					
						
						
							
							mypy: Specify Callable type parameters in test_helpers.py.  
						
						 
						
						
						
						
					 
					
						2017-11-04 19:47:45 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Aditya Bansal 
							
						 
					 
					
						
						
							
						
						31ea495842 
					 
					
						
						
							
							test_uploads: Extract 'use_s3_backend' to test helpers.  
						
						 
						
						
						
						
					 
					
						2017-10-30 21:56:31 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Steve Howell 
							
						 
					 
					
						
						
							
						
						a28841e8aa 
					 
					
						
						
							
							Extract get_stream_recipient().  
						
						 
						
						... 
						
						
						
						Do you call get_recipient(Recipient.STREAM, stream_id) or
get_recipient(stream_id, Recipient.STREAM)?  I could never
remember, and it was not very type safe, since both parameters
are integers. 
						
						
					 
					
						2017-10-28 17:57:39 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Greg Price 
							
						 
					 
					
						
						
							
						
						318682fd52 
					 
					
						
						
							
							auth: Use URL rather than cookie to pass signed data cross-domain.  
						
						 
						
						... 
						
						
						
						The cookie mechanism only works when passing the login token to a
subdomain.  URLs work across domains, which is why they're the
standard transport for SSO on the web.  Switch to URLs.
Tweaked by tabbott to add a test for an expired token. 
						
						
					 
					
						2017-10-27 14:42:04 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								rht 
							
						 
					 
					
						
						
							
						
						035ed93111 
					 
					
						
						
							
							zerver/lib: remove import six.  
						
						 
						
						
						
						
					 
					
						2017-09-27 19:10:28 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								rht 
							
						 
					 
					
						
						
							
						
						2e12fe5e2e 
					 
					
						
						
							
							zerver/lib: Remove print_function.  
						
						 
						
						
						
						
					 
					
						2017-09-27 18:05:45 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Vishnu Ks 
							
						 
					 
					
						
						
							
						
						caaa90f22d 
					 
					
						
						
							
							emails: Extract CSS from email_base_default.  
						
						 
						
						
						
						
					 
					
						2017-09-27 16:48:18 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								rht 
							
						 
					 
					
						
						
							
						
						f43e54d352 
					 
					
						
						
							
							zerver/lib: Remove absolute_import.  
						
						 
						
						
						
						
					 
					
						2017-09-27 10:00:39 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tim Abbott 
							
						 
					 
					
						
						
							
						
						4a22316d90 
					 
					
						
						
							
							test_decorator: Add explicit subdomains in tests.  
						
						 
						
						
						
						
					 
					
						2017-08-28 22:51:57 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tim Abbott 
							
						 
					 
					
						
						
							
						
						b8e7369dee 
					 
					
						
						
							
							mypy: Remove type: ignores not needed in Python 3.  
						
						 
						
						
						
						
					 
					
						2017-08-25 11:04:20 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tim Abbott 
							
						 
					 
					
						
						
							
						
						890417f8eb 
					 
					
						
						
							
							test_helpers: Add 'method' to HostRequestMock.  
						
						 
						
						
						
						
					 
					
						2017-08-15 19:47:03 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Jack Zhang 
							
						 
					 
					
						
						
							
						
						a533ab5881 
					 
					
						
						
							
							context_processors.py: Add flag for whether user is logged in.  
						
						 
						
						
						
						
					 
					
						2017-08-15 12:15:21 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Jack Zhang 
							
						 
					 
					
						
						
							
						
						b82bdc82bf 
					 
					
						
						
							
							context_processors.py: Add flag for whether page is help center.  
						
						 
						
						... 
						
						
						
						This is needed once the header markup is deduplicated. 
						
						
					 
					
						2017-08-15 12:15:21 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tim Abbott 
							
						 
					 
					
						
						
							
						
						cc03c8766f 
					 
					
						
						
							
							test_helpers: Expand HostRequestMock variables.  
						
						 
						
						
						
						
					 
					
						2017-08-15 10:54:23 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tim Abbott 
							
						 
					 
					
						
						
							
						
						4bb979d869 
					 
					
						
						
							
							test_helpers: Fix annotation for avatar_disk_path.  
						
						 
						
						
						
						
					 
					
						2017-08-05 17:53:18 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								neiljp (Neil Pilgrim) 
							
						 
					 
					
						
						
							
						
						3ca34bebdc 
					 
					
						
						
							
							mypy: Use Callable as parameter for simulated_queue_client.  
						
						 
						
						... 
						
						
						
						Previously the type was annotated as 'type'. 
						
						
					 
					
						2017-08-05 12:08:59 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Aditya Bansal 
							
						 
					 
					
						
						
							
						
						452bbd9104 
					 
					
						
						
							
							test_helpers: Extract stub for request_event_queue & get_user_events.  
						
						 
						
						
						
						
					 
					
						2017-07-28 14:50:55 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Tim Abbott 
							
						 
					 
					
						
						
							
						
						53e4d8562b 
					 
					
						
						
							
							lint: Add a lint check for bare type: ignores.  
						
						 
						
						
						
						
					 
					
						2017-07-27 16:31:55 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Rishi Gupta 
							
						 
					 
					
						
						
							
						
						394f85eb76 
					 
					
						
						
							
							confirmation: Change confirmation keys to have length 24.  
						
						 
						
						
						
						
					 
					
						2017-07-17 23:18:47 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								neiljp (Neil Pilgrim) 
							
						 
					 
					
						
						
							
						
						8611a2cafa 
					 
					
						
						
							
							tidying: Combine multiple 'import typing' lines onto one line.  
						
						 
						
						
						
						
					 
					
						2017-07-16 16:43:21 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Vishnu Ks 
							
						 
					 
					
						
						
							
						
						80d0039e2c 
					 
					
						
						
							
							test_helpers: Remove unused get_user_profile_by_email import.  
						
						 
						
						
						
						
					 
					
						2017-07-13 00:45:24 +05:30  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Cory Lynch 
							
						 
					 
					
						
						
							
						
						6653e19e3a 
					 
					
						
						
							
							Add URL for viewing node coverage data on dev server.  
						
						 
						
						... 
						
						
						
						Running test-js-with-node --coverage now provides a URL
to view the output data on the web.
Fixes  #5177 . 
						
						
					 
					
						2017-06-09 16:17:30 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Rick Chern 
							
						 
					 
					
						
						
							
						
						e53d1c3885 
					 
					
						
						
							
							tests: Remove get_user_profile_by_email from most tests.  
						
						 
						
						
						
						
					 
					
						2017-05-24 13:05:19 -07:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								umkay 
							
						 
					 
					
						
						
							
						
						ccc70445d6 
					 
					
						
						
							
							mypy: Fix strict-optional errors for test files.  
						
						 
						
						... 
						
						
						
						Fix mypy --strict-optional errors in zerver/tests 
						
						
					 
					
						2017-05-24 12:43:28 -07:00