paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 15:33:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,340 Commits 30 Branches 160 Tags
c39aa0b0bc583bbb94f602ac8ff39dba3d93a9a5
Commit Graph

125 Commits

Author SHA1 Message Date
Waseem Daher
a629f7edf6 Remove dead reference to 'show_all_messages'. 
This used to be a button that let us un-narrow, I guess.
A git grep for it after this commit turns up no actual
references to it.

(imported from commit 05acb4bb40da1b032f548c511fbae5b2b20874a8)
 2013-01-09 21:46:08 -05:00
Waseem Daher
fad7d0a7cb Always show the floating recipient bar. 
The initial rationale for hiding the floating recipient bar
was that it duplicated information that was in the "narrowbar".
Now that this no longer exists, let's *always* show the
floating recipient bar.

(Yes, there is some duplication of this information in the
search area, but I think the situation is fundamentally
different now and would basically like to see it everywhere.)

(imported from commit 6fd4506c2f48caade9496139e580e6550252ce8c)
 2013-01-08 16:43:50 -05:00
Keegan McAllister
6dea25fd9f Add narrow.by for syntactic convenience 
(imported from commit 51300b93a078d54e5111e6bb16ecd9ecbcc295d2)
 2013-01-08 12:18:31 -05:00
Keegan McAllister
3af2bf345a Reinstate server-side narrow filtering 
(imported from commit 40f63324a8dff404b504b06bddf303b8c1ad5780)
 2013-01-08 12:18:31 -05:00
Keegan McAllister
3455e37160 Get rid of is:pm alias for is:private-message 
It's cleaner if the filtering code recognizes only one value.
We can add this back in by converting in the parser.

(imported from commit 453b7b01e094955c6d66be63b5d997cc56b50a35)
 2013-01-08 12:18:31 -05:00
Keegan McAllister
dbc4798594 Be consistent about when we display search buttons 
Show the buttons iff

    - the search input is focused,
    - the search input has non-empty contents, or
    - we are narrowed.

(imported from commit f5c98471a2db4ab522160960dd1271471a9db555)
 2013-01-08 12:18:31 -05:00
Keegan McAllister
4ddaf5a2ae Use case-insensitive matching for all narrow operators 
We don't require that the parsed form be lower case; that's handled by
narrow.activate.  However we unparse as lower case, in order to give the user a
hint that matching is not case sensitive.

(imported from commit 2882b440deb59a049b095db7a13cfc18e047caec)
 2013-01-08 12:18:30 -05:00
Keegan McAllister
3619480673 Handle narrowing operators typed into the search box 
(imported from commit 6f758091e2953d00d6a331210aa774b72ba889d5)
 2013-01-08 12:18:30 -05:00
Keegan McAllister
d2705ab913 Add narrow.describe 
(imported from commit df123384754701108fe7597710cb0cf46cb86caf)
 2013-01-08 12:18:30 -05:00
Keegan McAllister
6d50e233ec Add narrow.parse 
(imported from commit 2275d02c2aee411d07645f7c3d81fdff7d188607)
 2013-01-08 12:18:30 -05:00
Keegan McAllister
5ee6a9ebca Rename narrow.show_all_messages to narrow.deactivate 
(imported from commit 927374756e112abc1042b16caa315af8c1f0baec)
 2013-01-08 12:18:29 -05:00
Keegan McAllister
ba7ffcead4 narrow: Remove some unnecessary helpers 
(imported from commit 307dfec262648bc1fc79d2fb46f8950c7a2f1e2e)
 2013-01-08 12:18:29 -05:00
Keegan McAllister
3c9b9227f8 Get rid of the narrowbar 
(imported from commit 53335b8177561d4b103659a51704d6b2ce7ec367)
 2013-01-08 12:18:29 -05:00
Keegan McAllister
d4d4ea7a8d Display narrowing operators in the search bar 
(imported from commit d801128c5b961360939c9e3f3f6f89c8602f987b)
 2013-01-08 12:18:29 -05:00
Keegan McAllister
38ff2d9993 Use operators to express narrowing internally 
This breaks server-side filtering, for the time being.

(imported from commit 58ec2d7aa593e1c71f835b186535a038faa63239)
 2013-01-08 12:18:29 -05:00
Jeff Arnold
db6f03d46d Make the back button work when narrowed 
(imported from commit be922b06e7b53ec21751e67a490bb518333c3e6c)
 2012-12-19 14:46:31 -05:00
Zev Benjamin
7e4776322d [manual] Unify huddles and personals into private messages on the receive path 
feedback-bot and zephyr_mirror will need to be updated and restarted
when this is deployed to prod.

(imported from commit fe2b524424c174bcb1b717a851a5d3815fda3f69)
 2012-12-04 18:01:51 -05:00
Jeff Arnold
b52dbe1ca9 Auto-invoke "Load older messages" when at the top of the page 
Resolves Trac #445

(imported from commit d7d96fe82e9e1cbef32e0dde284ce217e83aff55)
 2012-11-29 14:18:38 -05:00
Tim Abbott
aba2192ec2 Restore the time-travel functionality with Waseem's UI. 
This restores the time-travel functionality and fixes Waseem's laundry
list of problems with its original UI.

(imported from commit e30e02c25af994435adb815d26284b3669c945a4)
 2012-11-28 22:26:31 -05:00
Zev Benjamin
48790187ca select_message_id: Remove no longer applicable update_server option 
(imported from commit 03076f1d514017b70ec5bd2b34b1a575d0c56f6e)
 2012-11-28 16:36:43 -05:00
Tim Abbott
14494d6a1f Add "time travel" feature. 
(imported from commit b7b6794ad635ec63269a2043cd48b02749fbffda)
 2012-11-20 17:17:39 -05:00
Jeff Arnold
9ce4c103c0 Implement full history search by creating a narrow for a search term 
(imported from commit 3f2df6a6e590458ff774bbd658bbd1d95076a4db)
 2012-11-19 17:12:59 -05:00
Waseem Daher
b251d064f9 narrow.js: Add ability to narrow to private messages by name/email. 
(imported from commit b3afda6444afa9b44b140882f3d71fb41b3ef10d)
 2012-11-16 15:58:49 -05:00
Waseem Daher
77a45cbc0e narrow.js: Add the ability to narrow by stream name. 
(imported from commit 033dea1f63cceb30f37eae50ea3a7425a8e94685)
 2012-11-16 15:58:37 -05:00
Jeff Arnold
a68efd9ce2 Handle loading of older messages in narrowed view 
(imported from commit 2fe1377736322a44e8682c69dd5e4312d5f46ca4)
 2012-11-15 16:32:00 -05:00
Waseem Daher
a1c4aa6865 Modularize search.js. 
(imported from commit 72f00f832846124d833071fdd46b026c99189512)
 2012-11-14 15:29:18 -05:00
Jessica McKellar
a2c6975ca2 Be case-insensitive about subjects when collapsing and narrowing. 
(imported from commit 0baf20179c037c3eac82d8db20c6ec8062bb136a)
 2012-11-07 14:51:51 -05:00
Keegan McAllister
4f53457f2f show_all_messages: Use .empty() instead of .html("") 
(imported from commit 8df159bee6512856fd61eb5038e4b12470724553)
 2012-11-06 17:04:10 -05:00
Jessica McKellar
4396f1bf35 Don't unnarrow if you click the Home link from another pane. 
This makes the Home link modal (when on the Home pane, it unnarrows
you; when on a different pane, it returns you to your feed in whatever
state you left it).

Fixes Trac #5.

(imported from commit 3181f17035d78a9916ab7a3ad336f34cb66d3cdf)
 2012-11-04 11:17:48 -05:00
Keegan McAllister
5a7b307d71 Create the narrowbar using a Handlebars template 
This fixes an XSS hole (#249).

(imported from commit 5f70c0bc23e0d992f2d85889e2ba9157f1b73b3a)
 2012-10-31 16:02:17 -04:00
Zev Benjamin
564565f627 When narrowing a second time, don't move the pointer and display the persistent pointer 
(imported from commit f49222f3a5df636517cadcafbc3d278f4f0ced00)
 2012-10-31 12:03:00 -04:00
Keegan McAllister
582cb799dd Get rid of the selected_message_class global 
Instead we infer this from narrow.active(), with the ability to override during
the narrowing procedure.

(imported from commit fab9c6861f19aedf0ee8af094c1ef4e8a0a73d80)
 2012-10-26 21:05:04 -04:00
Waseem Daher
44a6a2b8a4 Have search bar always take on color of main area. 
(imported from commit 85f6db17ca2fd616e4c7b63a98b80332cbddc1c0)
 2012-10-26 14:31:05 -04:00
Jessica McKellar
92593b7cc8 Add basic up/down search functionality, including across narrows. 
(imported from commit c82acad95e97733b87d65287c685caf7533a774e)
 2012-10-26 14:31:05 -04:00
Zev Benjamin
6ed1d38743 Show persistent pointer on narrow again 
(imported from commit c871ec931ffad4bc692a908e687bb21c6cb2e7e9)
 2012-10-26 11:44:28 -04:00
Zev Benjamin
9c838c44a1 Scroll to the correct message when narrowing 
(imported from commit c6f11f3315f1d168b85f80ab524f322b399f5a85)
 2012-10-26 11:44:28 -04:00
Keegan McAllister
f3f9fb545d Narrow by recipient when the user presses 'S' on a huddle 
(imported from commit 7e7c3d27b0824a60f7e8379c282ec05704d842f6)
 2012-10-23 23:04:42 -04:00
Keegan McAllister
eaecaab7f4 Rename narrow.all_personals -> all_huddles 
(imported from commit 6258ddd1548b6ee8cf20c28c9b18e229ebf4e720)
 2012-10-23 20:43:23 -04:00
Waseem Daher
8ce8a083bb Slightly hackish way of stripping out   in narrowbar tooltips. 
(imported from commit 414738408cd1e4e53f0268b0851c903c6a1a9eda)
 2012-10-23 20:30:58 -04:00
Waseem Daher
feff1d811d Allow icons in narrowbar without putting their HTML in the title text. 
Before this commit, a hover read "<i class='icon-whatever'></i> All huddles with..."

(imported from commit e5a20678b87355d6709ec3b8776469114c92b2f6)
 2012-10-23 20:21:51 -04:00
Tim Abbott
bcfe06c69c Don't show floating recipient bar when narrowed to huddle/subject. 
(imported from commit b7cbd83035292ed447a3da666df9326d75aac35e)
 2012-10-23 18:29:54 -04:00
Keegan McAllister
afdd3af1b6 Handle having no selected message more gracefully 
(imported from commit ba00c012061b35dfe490bf1312b3fa78a4f6582f)
 2012-10-23 17:03:31 -04:00
Keegan McAllister
86159813df Hide the "Load older messages" button in narrowed view 
Ideally this would be part of hiding zhome, but right now zhome/zfilt are
assumed to the tables themselves, and changing that seems unfortunately
invasive.  And it's not crazy to think of the "loading controls" as a logically
separate thing that we might show/hide independently.

Longer term, we may want an indication in narrowed view that there could be
more messages on the server.

(imported from commit eb72d720da7c03f6f1378ae18ab6e973bf98247f)
 2012-10-23 13:28:08 -04:00
Zev Benjamin
bb64eb717f Make select_message and friends take an options argument 
The select_and_show_by_id function is now subsumed by select_message_by_id.

(imported from commit 3dbe9cf9d253b64733f269b6dc78c144100927ca)
 2012-10-22 16:06:38 -04:00
Waseem Daher
17d44be14a Display huddles as 'You and...'. 
(imported from commit 35fe0e56751b1a2993bd99181e8bbd57e8c3ce81)
 2012-10-19 15:11:13 -04:00
Waseem Daher
647f3c1220 Hack to make narrowbar line up a liiiiitle bit with real bar. 
(imported from commit 83f0066def43b2a35e2d8aa089f5962617cf5546)
 2012-10-19 15:07:08 -04:00
Waseem Daher
92045f2c9e Experiment: Use icons in more places (instead of the word Huddle). 
(imported from commit 6e27da4e54634c1f2fe05e2bffac24dc00576d2c)
 2012-10-19 14:42:43 -04:00
Keegan McAllister
299a298bfb Fix variable name typo in narrow.by_recipient 
(imported from commit 87954f2d9007ebdd9d6da8a71584d2677c19ad4d)
 2012-10-19 13:02:25 -04:00
Keegan McAllister
5d0fdd1958 Clean up narrow.by_recipient 
(imported from commit ca6665f29847077d6038d3f48821c4be02e95ff1)
 2012-10-19 13:02:25 -04:00
Keegan McAllister
390c9a26c1 Explain why target_id exists 
(imported from commit af2235d80ada47e95806a8a2f807261da583e39e)
 2012-10-19 12:57:34 -04:00