paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
29,230 Commits 30 Branches 160 Tags
c4d3578de32599571d84bdce7cba0193420bb83c
Commit Graph

29230 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Steve Howell
4b38260a27 tests: Fix message.subject references. 2018-11-12 15:47:11 -08:00
Steve Howell
630dd8ac1b subject -> topic: Fix bugdown tests. 2018-11-12 15:47:11 -08:00
Steve Howell
1854ddbcd0 taiga tests: Use self.TOPIC instead of "subject". 2018-11-12 15:47:11 -08:00
Steve Howell
31e328c544 webhook tests: Replace SUBJECT with TOPIC. 2018-11-12 15:47:11 -08:00
Steve Howell
1fff890b71 webhooks: Change *_SUBJECT_TEMPLATE to *_TOPIC_TEMPLATE. 2018-11-12 15:47:11 -08:00
Steve Howell
ea98a44db3 webhooks: Replace SUBJECT_WITH_* with TOPIC_WITH_*. 2018-11-12 15:47:11 -08:00
Steve Howell
ced4d81856 Sweep tests for expected_subject -> expected_topic. 
This is all in the webhooks tests, including some
docs for how to write those tests.
 2018-11-12 15:47:11 -08:00
Steve Howell
3133998af9 test_messages: Fix a lot of subject -> topic_name. 2018-11-12 15:47:11 -08:00
Steve Howell
e55fc144b9 Add alias support to REQ helpers for subject/topic. 
The alias support is generic here, and we use it for
migrating subject -> topic in REQ_topic().
 2018-11-12 15:47:11 -08:00
Steve Howell
97062c4017 lint: Prevent use of "subject" in zerver/views. 2018-11-12 15:47:11 -08:00
Steve Howell
de6c08a842 Extract messages_for_topic(). 2018-11-12 15:47:11 -08:00
Steve Howell
b667dff4bc minor: Change wording in comment to avoid "subject". 
We're trying to sweep "subject" out of the codebase,
even when it has nothing to do our legacy "subject"
field.  The rewording here will prevent some linter
noise.
 2018-11-12 15:47:11 -08:00
Steve Howell
c7515a853c Use REQ_topic in update_message_backend(). 
Note that we now strip the topic in the converter.
We also strip it in the view handler, which is now
redundant, but I left it in as defensive code.
 2018-11-12 15:47:11 -08:00
Steve Howell
3de1289d3e Rename subject -> topic_name in update_message_backend(). 2018-11-12 15:47:11 -08:00
Steve Howell
754795c0b7 Extract REQ_topic() helper. 
For now we use it only in the send path, not the update
path.
 2018-11-12 15:47:11 -08:00
Steve Howell
0a171bf9bf Fix "prev_subject" with LEGACY_PREV_TOPIC. 
I added `LEGACY_` prefix to the var, because
otherwise you'd have really confusing code
where you change the key from `PREV_TOPIC`
to "prev_topic".
 2018-11-12 15:47:11 -08:00
Steve Howell
a49ba8c577 Extract user_message_exists_for_topic(). 2018-11-12 15:47:11 -08:00
Steve Howell
39e5c61d4a Extact MATCH_TOPIC constant. 2018-11-12 15:47:11 -08:00
Steve Howell
500fcbb5e3 messages: Update subject -> topic_name. 
This fixes several local vars named "subject".
 2018-11-12 15:47:11 -08:00
Steve Howell
f7f071b52f minor: Fix subject -> topic in a comment. 2018-11-12 15:47:11 -08:00
Steve Howell
8981b65bbc Extract topic_column_sa(). 2018-11-12 15:47:11 -08:00
Steve Howell
b46fb5eaad Rename subject_matches -> topic_matches. 
This is always either a var or a SQL label,
so it's safe to change.
 2018-11-12 15:47:11 -08:00
Tim Abbott
fe8d400e3a node: Fix test failure due to 'narrowed' removal. 
This was broken in 67fa755158.
 2018-11-12 15:39:35 -08:00
Vishnu Ks
fba5b329ab version: Bump PROVISION_VERSION for py packages upgrade. 2018-11-12 15:27:26 -08:00
Vishnu Ks
11c595a33e requirements: Upgrade disposable-email-domains to 0.0.38. 2018-11-12 15:27:26 -08:00
Vishnu Ks
c4b197cd4f requirements: Upgrade Sphinx to 1.8.2. 2018-11-12 15:27:26 -08:00
Vishnu Ks
96bd1328a5 requirements: Upgrade pylibmc to 1.6.0. 2018-11-12 15:27:26 -08:00
Vishnu Ks
1657f0d161 requirements: Upgrade psycopg2 to 2.7.6.1. 2018-11-12 15:27:26 -08:00
Vishnu Ks
7121903fc5 requirements: Upgrade cryptography to 2.4.1. 2018-11-12 15:27:26 -08:00
Vishnu Ks
77473c2a6a requirements: Upgrade django-auth-ldap to 1.7.0. 2018-11-12 15:27:26 -08:00
Vishnu Ks
b46aeaf00b requirements: Upgrade setuptools to 40.5.0. 2018-11-12 15:27:26 -08:00
Vishnu Ks
c1aed13afe requirements: Upgrade wheel to 0.32.2. 2018-11-12 15:27:26 -08:00
Vishnu Ks
4f91a564ef requirements: Upgrade virtualenv-clone to 0.4.0. 2018-11-12 15:27:26 -08:00
Vishnu Ks
8f5cbb5c8c requirements: Upgrade typing to 3.6.6. 2018-11-12 15:27:26 -08:00
Vishnu Ks
3ae8e79c5a requirements: Upgrade Twisted to 18.9.0. 2018-11-12 15:27:26 -08:00
Vishnu Ks
1444fb8870 requirements: Upgrade sphinx-rtd-theme to 0.4.2. 2018-11-12 15:27:26 -08:00
Yashashvi Dave
89eebad14f user profile: Add user type/role in user profile popover. 
Add user type/role in user's detail profile popover.

Fixes part of #10754
 2018-11-12 15:13:44 -08:00
Yashashvi Dave
54dd7f0a43 user info popover: Add user type/role in user information popover. 
Add user role-- "Administrator", "Member", "Bot" or "Guest"
under 'Local time' in user information popover.

Fixes part of #10754
 2018-11-12 15:13:44 -08:00
Yashashvi Dave
614624d232 static/js/popover.js: Extract render_user_info_popover. 2018-11-12 15:13:43 -08:00
Tim Abbott
67fa755158 popovers: Remove now-unused narrowed argument to user info popover. 
This stopped being used in bbfd33185c.
 2018-11-12 15:10:19 -08:00
Tim Abbott
5a9f00dae4 popovers: Sort arguments for user info popover. 
This makes it easier to see how the two duplicate implementations differ.
 2018-11-12 15:09:09 -08:00
Tim Abbott
4c8f439ece popovers: Standardize calculation of show_user_profile. 2018-11-12 14:59:39 -08:00
Tim Abbott
96284bd336 popovers: Use attributes of user object more consistently. 
This is a preparatory refactoring to make it easy to see what's
different as we deduplicate this logic.
 2018-11-12 14:59:38 -08:00
Tim Abbott
08529507c8 popovers: Sort arguments to user info popover rendering. 
This is a first step towards deduplicating this logic.
 2018-11-12 14:59:23 -08:00
Yashashvi Dave
53201c5411 statis/js/people.js: Add function get_user_type. 
Add function `get_user_type`, which returns user
type-"Administrator", "Guest", "Bot" or "Member"
depending on what they are.
 2018-11-12 14:57:32 -08:00
Steve Howell
bb959acbaf Use modern huddle URLs in digest emails. 2018-11-12 12:01:09 -08:00
Steve Howell
e79e0018f7 Use modern PM URLs in digest emails. 2018-11-12 12:01:09 -08:00
Steve Howell
6a89446e80 tests: Add test for huddle digest urls. 2018-11-12 12:01:09 -08:00
Steve Howell
c08a3833e2 tests: Start to check urls in digest emails. 2018-11-12 12:01:09 -08:00
Tim Abbott
453c35d0f7 install: Provide a suggestive error message when missing Universe. 
By far the dominant cause of errors when installing apt packages is
not having the Universe repository enabled in Ubuntu bionic (this
seems to have started happening a lot recently; I wonder if Ubuntu
changed the defaults for new server installs or something?).

In any case, providing that suggestion in the error output should help
reduce these a lot.
 2018-11-12 10:56:39 -08:00