Commit Graph

63435 Commits

Author SHA1 Message Date
Prakhar Pratyush
8018c2d203 topic_list: Show empty string topic when narrowed to empty topic.
When narrowed to an empty topic i.e. topic with no messages yet,
we show the topic name in the left sidebar topic list.

Earlier, it was not working for empty string topic.

This commit fixes the bug.
2025-02-11 09:56:02 -08:00
Alya Abbott
801bf0454f contributor docs: Consistently describe project hours and difficulty. 2025-02-11 09:55:34 -08:00
Tim Abbott
745a81b70b docs: Add a few new GSoC project ideas.
I expect to add a few more in the coming weeks.
2025-02-10 17:25:28 -08:00
Lauryn Menard
2de2b22d55 help: Update for subscribe/unsubscribe user to channel terminology.
Instead of referring to users being added or removed from channels,
we now use subscribe or unsubscribed from channels.

Splits the article for adding and removing users from a channel
into separate articles: /help/subscribe-users-to-a-channel and
/help/unsubscribe-users-from-a-channel.

The URL redirects for the combined add/remove articles (for both
channel and stream terminology) go to the subscribe users to a
channel article.
2025-02-10 15:54:35 -08:00
apoorvapendse
dfa17b97f3 edit_message: Remove cursor:text from scrollbar thumb.
It makes it easy to determine whether you are dragging
the scrollbar or selecting text from the editing area.

Fixes: #33253.
2025-02-10 15:50:13 -08:00
evykassirer
707565b291 search: Fix bug where narrow screen closed search had background color.
This was introduced in 325ab83edb
and should have only been applied to the expanded search bar.
2025-02-10 11:25:06 -08:00
apoorvapendse
5e6764373f copy_and_paste: Remove spannification logic for math expressions.
We instead use a turndown filter to get
what we want in case of inline expressions.

This removes most of the faulty logic
introduced by @apoorvapendse.

Fixes: https://chat.zulip.org/#narrow/channel/9-issues/topic/HTML.20paragraphs.20misconverted.20by.20copy.20and.20paste/near/2078384
2025-02-10 10:02:10 -08:00
Aman Agrawal
d28f7d8622 recent_view: Show topic menu instead of topic visibility popover.
This helps us include topic summary feature in recent view.
2025-02-08 08:52:26 -08:00
evykassirer
a37d1033ce message_header: Fix em height calculation given larger font-size.
Followup to https://github.com/zulip/zulip/pull/32933#discussion_r1910137015

Discussion here:
https://chat.zulip.org/#narrow/channel/6-frontend/topic/info.20density.20with.20em.20font.20size/near/2037799
2025-02-07 14:02:50 -08:00
roanster007
ca2394495e search: Exclude with operator terms from search terms.
This commit excludes terms containing the `with` operator
from the search terms, since `with` operator is not a search
operator.
2025-02-07 13:03:52 -08:00
evykassirer
725d0e2d47 subscriptions: Use em to center permissions radio buttons. 2025-02-07 09:12:40 -08:00
evykassirer
6ad425a912 empty feed: Use em for max-width of notice. 2025-02-07 09:12:05 -08:00
evykassirer
d40e3dc350 empty feed: Use app-wide line height. 2025-02-07 09:12:05 -08:00
Harsh Bansal
30a59e877e left_sidebar: Restyle log-in link to match browse channels.
This commit updates the styling of "Log in to browse
more channels" link in the left sidebar for logged out
users to match "BROWSE N MORE CHANNELS" link. If a string
exceeds the width of container then it would be wrapped
to the next line.

Fixes: #33108
2025-02-07 09:11:18 -08:00
Saubhagya Patel
6d51b80086 banners: Close the timezone banner after the user selects an option.
This commit ensures that the timezone update banner is closed after
the user either accepts or declines to update the timezone.

Fixes #33313.
2025-02-07 09:08:33 -08:00
Sahil Batra
4deb0a46a3 test_events: Refresh self.user_profile in verify_action.
For some cases, if the function called for testing events
changes some realm property using the realm object other
than the one derived from self.user_profile, then while
matching the states, self.user_profile still has the
old realm object.
2025-02-06 17:20:01 -08:00
Sahil Batra
58d21c432e event_schema: Update check_user_group_update to check multiple fields.
We can send data for multiple fields in user group update event
so this commit updates check_user_group_update accordingly.
2025-02-06 17:20:01 -08:00
Sahil Batra
8b068cf244 groups: Remove unused parameter from parse_group_setting_value.
setting_name parameter was not being used in
parse_group_setting_value function.
2025-02-06 17:20:01 -08:00
Vector73
dedd4237a4 saved_snippets: Fix JQuery error.
This error occurred when opening the saved snippets dropdown while
editing a message caused by `get_offset_to_window()` expecting a
single JQuery element in the selected set. This function was used on
`$(this.dropdown_input_visible_selector)` which is a class selector
and can return multiple elements when multiple saved snippets button
are rendered.

This commit resolves this bug by creating dropdown widgets with unique
`widget_selector` for each saved snippets button.
2025-02-06 17:13:30 -08:00
Alya Abbott
ee1ee63c53 settings: Make label for warning when DMing a guest more succinct.
Also explain what the setting does in the help center.
2025-02-06 13:46:06 -08:00
Vector73
cb6f0fd63c realm: Add setting to notify user on DMing guest.
Added `enable_guest_user_dm_warning` setting to decide whether
clients should show a warning when a user is composing to a guest
user in the organization.

Fixes #30078.

Co-authored-by: adnan-td <generaladnan139@gmail.com>
2025-02-06 12:15:41 -08:00
Aman Agrawal
d852aeffc4 message_summary: Raise error for error responses. 2025-02-06 12:03:24 -08:00
Aman Agrawal
2f5aea6604 message_summary: Add setting to put a monthly rate limit per user. 2025-02-06 12:03:24 -08:00
Aman Agrawal
7fb767c080 message_summary: Move cost per token configuration to settings. 2025-02-06 12:03:24 -08:00
Aman Agrawal
099bab986f settings: Remove unused setting.
Since TOPIC_SUMMARIZATION_MODEL is already defined in
dev_settings to a groq model, this is not used.
2025-02-06 12:03:24 -08:00
Aman Agrawal
0bad785f03 message_summary: Log time to generate summary.
Mostly copy pasted things from markdown time logging.
2025-02-06 12:03:24 -08:00
Aman Agrawal
e85a33cc95 message_view: Reset id_info to avoid potential bugs. 2025-02-06 10:37:25 -08:00
Aman Agrawal
8686adc162 message_view: Ask server for first_unread when old_unreads_missing.
When we need to contact server to fetch messages around first
unread and we have `old_unreads_missing`, we use `first_unread`
as anchor instead of relying of first unread msg id calculated
locally for the narrow.
2025-02-06 10:37:25 -08:00
evykassirer
500e0f63d6 read reciepts: Use em for row height and modal width. 2025-02-06 10:35:35 -08:00
Maneesh Shukla
205cfc0f85 change_password_modal: Hide the dialog spinner when action fails.
This commit also add the comma(,) and exclamation mark(!) to the
error messages wherever they were missing.

This commit modify the settings_change_error function to show the error
inside the modal, instead of the settings panel behind it.
2025-02-06 09:40:57 -08:00
evykassirer
47f21ae9c5 message_header: Center privacy icons. 2025-02-06 09:40:17 -08:00
Mateusz Mandera
0de58860dc install: Configure services during installation. 2025-02-05 17:47:28 -08:00
Tim Abbott
68c3e86ffa stream_data: Fix parsing of slugs for inaccessible channels.
Previously, if we had syntax in a URL slug that looked like a channel
ID, but we couldn't find the channel (say, beacuse it's a link to a
channel we're not subscribed to), parse_narrow would fail to parse it,
resulting in incorrect error handling.

This could break rendering of topic links that we want to process via
rendered_markdown.ts. I've confirmed that the web app's logic for
processing message_view.show does not require its caller to check the
channel ID is accessible.

The updated logic matches what we do in the mobile apps.
2025-02-05 14:01:11 -08:00
crab
c26cd25a4b user_profile: Invalidate user group state after closing the user modal.
A regression was introduced in #33075 where user groups are only
rendered on the user profile modal once per page load since
user_groups_list_widget was not getting cleaned upon closing the modal.
2025-02-05 13:42:54 -08:00
Tim Abbott
b249830715 rocketchat: Harden parsing of custom emoji exports.
Apparently some exports have a weird `ObjectId("idstring")` typed
value here, that stringify to the actual string.
2025-02-05 13:41:19 -08:00
Lauryn Menard
4d0448f7c6 zoom: Extract user authentication helper for current oauth integration.
Prep for adding a server to server oauth zoom integration.
2025-02-05 13:36:25 -08:00
Lauryn Menard
901141e297 zoom: Create shared TypedDict for zoom call payloads.
Prep for adding a server to server oauth zoom integration.
2025-02-05 13:36:25 -08:00
Lauryn Menard
cb68d11ee3 tests: Create subclasses for create video call tests.
Separates tests for Zoom and Big Blue Button video call
intgrations into separate sublcasses, ZoomVideoCallTest
and BigBlueButtonVideoCallTest respectively.
2025-02-05 13:36:25 -08:00
Lauryn Menard
f13a1a48f7 realm: Refactor VIDEO_CHAT_PROVIDERS to have all possible options.
Refactors Realm.VIDEO_CHAT_PROIVDERS to have all the possible options
for video chat integrations, and use get_enabled_video_chat_providers
to compute the enabled options for the realm.

Prep for adding Zoom server to server video chat integration.
2025-02-05 13:36:25 -08:00
Pratik Chanda
ef2f8c0796 recent_conversations: Show unread @-mention indicator for DMs.
Earlier, in recent conversation, only streams had unread @-mention
indicators and DMs in recent conversation lacked them.

This commit introduces unread @-mention indicators for DM rows in recent
conversations using `unread_mention_dms` which stores `user_ids_string`
mapped to `message_id`s having mention.

Fixes: zulip#28849.
2025-02-05 13:27:57 -08:00
Pratik Chanda
d3f4d0dfa2 left_sidebar: Show unread @-mention indicators for DMs in left sidebar.
Earlier, in left sidebar, only streams had unread @-mention indicators
in individual streams and topics. DMs lacked unread @-mention
indicators.

This commit introduces unread @-mention indicators for DM rows in left
sidebar using `unread_mention_dms` which stores `user_ids_string` mapped
to `message_id`s having mention.

Fixes part of zulip#28849.
2025-02-05 13:27:57 -08:00
Pratik Chanda
05fbee9f5a inbox_ui: Show unread @-mention indicator for DMs in inbox view.
Earlier, only unread @-mentions in streams were shown in inbox view
while DMs lacked this indicators.

This commit introduces unread @-mention indicators for DM rows in inbox
view using `unread_mention_dms` which stores `user_ids_string` mapped to
`message_id`s having mention.

Fixes part of zulip#28849.
2025-02-05 13:27:57 -08:00
Pratik Chanda
224024e683 unread: Track unread mentions for private messages.
Earlier, unread mentions in messages were handled to ignore if the
message was from a dm instead of stream.

This commit changes the behaviour by tracking the unread mentions
in all private messages and storing them to be easily retrieved.

Fixes part of zulip#28849.
2025-02-05 13:27:57 -08:00
Pratik Chanda
c14135ded5 tooltips: Change tooltip string for unread mention info.
This commit changes the tooltip string for unread mentions across
different views for streams.
2025-02-05 13:27:57 -08:00
Greg Price
2ce4fad39f contributor docs: Update GSoC mobile project for 2025. 2025-02-05 13:25:09 -08:00
Pratik Chanda
2a26f34983 hotkey: Focus visible input filter field on query streams hotkey.
Earlier, if pm_list or stream_list was zoomed in and hitting `q`
hotkey would seemingly do nothing but in the background would add
highlighted class to `stream_row` and toggle stream-list-filter.

This commit fixes this behaviour by bringing focus to currently
visible input filter field.
2025-02-05 13:23:15 -08:00
Pratik Chanda
c071d952e1 left_sidebar: Refactor display left sidebar for stream list filter.
This commit refactors show left sidebar display logic when initiating
stream search to sidebar_ui.
2025-02-05 13:23:15 -08:00
Pratik Chanda
1545a75645 tooltips: Refactor left sidebar tooltips to its own module.
This commit refactors tooltip targeting left sidebar elements
into its separate module in `left_sidebar_tooltips`.
2025-02-05 13:21:54 -08:00
evykassirer
56ba72c0b7 user_status: Remove fixed px height of status input.
It looks fine without the height explicitly set,
and the fixed height only works at 14px info
density.
2025-02-05 13:16:57 -08:00
Anders Kaseorg
432ebd9a36 tests: Consume more streaming responses.
Fixes warnings like “ResourceWarning: unclosed file <_io.FileIO
name='/srv/zulip/var/4fc6d348-ccfe-43fa-8a2e-5b4ff5a15a66/test-backend/run_2304691/worker_7/test_uploads/files/2/d9/KYUsAKJ_g45NA7CojVbRW0C4/zulip.jpeg'
mode='rb' closefd=True>” with warnings enabled.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
2025-02-05 13:16:12 -08:00