Commit Graph

63435 Commits

Author SHA1 Message Date
Alex Vandiver
d74e176cbe docs: Fix missing references. 2025-01-21 15:12:49 -08:00
Niloth P
dbced00e47 hubot-integrations: Utilize a constant DOC_PATH for readability. 2025-01-21 15:07:55 -08:00
Niloth P
727fa9f32f hubot-integrations: Add secondary line text for all Hubot scripts. 2025-01-21 15:07:55 -08:00
Niloth P
e7f4d16863 hubot-integrations: Remove the unused logo_alt property.
This was used before `alt="{{ integration.display_name }} logo"` was set
in the common template `integrations/index.html` for all integration
logos. It is no longer necessary.
2025-01-21 15:07:55 -08:00
Niloth P
4b0172b282 hubot-integrations: Update link prefix to GitHub repositories.
The `hubot-scripts` account has been taken over.
While calls to the current set of URLs work as they are redirected to
the new links, this commit updates the link to refer to the right
GitHub account.
2025-01-21 15:07:55 -08:00
Steve Howell
b84eabae95 navbar bug fix: Restore sideways keyboard navigation.
This fixes #33123, which was a regression due to
7e57477dea
2025-01-21 15:02:22 -08:00
Steve Howell
094b59c3e7 timerender test: Add explicit test for Montreal/Toronto.
This might not actually work in all browsers, but it
expresses our intention, and it is what works on node.
2025-01-21 13:24:58 -08:00
Prakhar Pratyush
5bb53ec091 compose_banner: Show realm_empty_topic_display_name for topic="".
This commit adds support to display `realm_empty_topic_display_name`
value in the compose banners for topics having the actual value
of empty string.

Fixes part of #32996.
2025-01-21 13:22:08 -08:00
Kislay Verma
8379f0cffb topic_link_util: Accept channel name instead of syntax text.
In the function `get_stream_topic_link_syntax`,
we used the typed syntax text to make out
the channel name and then use it to
generate the appropriate link syntax.
We change that to directly accepting the
channel name.

This is in preparation for #31420
2025-01-21 13:21:11 -08:00
Saubhagya Patel
04fa3655ec settings: Replace the Theme select dropdown with the Theme switcher.
This commit includes the following changes:
 - Replace the theme select dropdown in the Preferences
   section of the Personal settings with the theme switcher,
   similar to the one in the personal menu popover.
 - The theme select dropdown in the Default User Settings
   section of the Organization settings also follows the same
   changes.

Fixes: #32111.
2025-01-21 12:01:12 -08:00
debghs
253efe1686 left_sidebar: Fix gap between direct-messages and streams_header.
This commit fixes the gap at the top of the streams_header
by adjusting the 'top' property with a small offset.

Fixes #32849.
2025-01-21 11:58:52 -08:00
Maneesh Shukla
b689ddb2ab move_message: Make propagation mode choices smarter and sticky.
This commit improves the propagation mode choices by making them smarter
and sticky. It remembers the last choice made by the user by storing it
in a map. The new behavior is as follows:

- Overwrites the dropdown selection if the last used option was
 "only one".
2025-01-21 11:57:20 -08:00
Harsh
40519ee9fa compose box: Fix disabled reply button for spectators. 2025-01-21 11:54:54 -08:00
Harsh
f9617c0aff searchbox_css: Replace display: none with visibility: hidden.
This commit standardizes the use of visibility: hidden for
clear_search_buttons in search boxes.
2025-01-21 10:31:34 -08:00
Steve Howell
36a6f0c547 group mentions: Use set instead of list for members.
The members aren't ordered, and a lot of the downstream
code merges the members into sets.
2025-01-21 10:23:02 -08:00
Steve Howell
0cbbe0c3bd group mentions: Optimize query with values_list.
The query in question runs in a loop when you have
multiple group mentions in a message. We can at
least make it slim.

This is my way to address #32934. It doesn't undo
the O(N) behavior, but N here is usually 1 or 2.
2025-01-21 10:23:02 -08:00
whilstsomebody
ef201f4fed overlay_util: Correctly handle overflow behavior in the application.
As the bug reported in
<https://chat.zulip.org/#narrow/channel/9-issues/topic/A.20little.20right.20shift.20can.20be.20observed.20when.20confirm.20dialog.20ope/near/2026160>
suggests that enabling scroll for an overlay when it is
opened and then disabling it while opening a modal over
it causes a slight shift in the application UI.

We fix this bug by toggling overflow behavior for the
application only when the modal is opened not over an
active overlay. For active overlays, we disable the
overflow for the application when they are opened and
in that case opening a modal over it also has not effect
on the overflow. This prevents any right shift that might
occur due to the visibility of the scrollbar in the application.

Fixes: #32898
2025-01-21 09:00:44 -08:00
Karl Stolley
b4fe3fa37b compose: Allow left arrow to scroll buttons. 2025-01-21 08:57:59 -08:00
Karl Stolley
d14c3b7aac left_sidebar: Present uniform, gridded filter boxes. 2025-01-21 08:56:49 -08:00
Harsh
dfedfbdfd3 css: Remove unused .bot-owner-name from styles. 2025-01-21 08:49:27 -08:00
Harsh
d5aca48cd8 css: Use --color-text-url variable as color for text links.
fixes: #31520
2025-01-21 08:49:27 -08:00
Sahil Batra
264e49e7e8 groups: Allow changing description and settings for deactivated groups.
We now allow changing description and all the permission settings
for deactivated groups as well, as there is no need to restrict
it and makes handling UI for deactivated groups easier.
2025-01-16 14:38:45 -08:00
Sahil Batra
abbd546531 openapi: Fix description for update-user-group endpoint.
Description for "PATCH /user_groups/{user_group_id}" endpoint
only mentioned updating name and description, but permission
settings are also updated using the same endpoint.
2025-01-16 14:25:43 -08:00
Sahil Batra
1fcda48d68 compose: Show system groups in silent mentions typeahead. 2025-01-16 14:25:04 -08:00
Sahil Batra
2e4d4c1d6a compose: Show all groups with at most 20 members in DM typeahead.
Previously, all the non-system groups were shown in the DM
recipient typeahead. Now, we show system groups as well but
do not show groups with more than 20 members.
2025-01-16 14:25:01 -08:00
Sahil Batra
1cf351197d compose: Include recursive group members when sending DMs.
Previously, when selecting a group from DM recipient typeahead,
only direct members of the group were included in the DM.

Now all the recursive members of the selected group are included.
2025-01-16 14:19:17 -08:00
Chris Bobbe
c088ddcecf help: Mention microG's Cloud Messaging setting in notification help 2025-01-16 14:03:19 -08:00
Aman Agrawal
b870faec5a stripe: Require 10 minimum licenses for cloud plus plan. 2025-01-16 11:32:03 -08:00
Aman Agrawal
e0767b23ed stripe: Validate licenses for the correct plan.
Since licenses are being created for the `new_plan` we need to
check licenses for the new plan here.
2025-01-16 11:32:03 -08:00
Saubhagya Patel
b013e25a64 css: Adjust focus outline for New Channel input in Move messages modal.
This commit adjusts the focus outline for the "New channel"
input in the Move message(s) and topic modal, preventing
it from extending to the entire modal and limiting it to the
input element only.
2025-01-16 11:22:31 -08:00
Alex Vandiver
1e9099737d docs: Update changelog for 9.4 release. 2025-01-16 18:00:30 +00:00
Mateusz Mandera
d1cbb0dd59 CVE-2024-56136: Don't leak information via "invalid subdomain" error.
The bug we're fixing here leaks information by returning an "invalid
subdomain" error when an attempt is made to log in to user@example.com
on a subdomain X when user@example.com does not exist on X, but does
on another subdomain Y.

This allows an attacker to determine that a certain email address has an
account on the server.

Instead, this should just return a regular authentication error.
2025-01-16 12:30:08 -05:00
Sourabh Patel
aa5f2d3346 lightbox: Add query to hide media-description below 100px width.
Using container query ensures that the media-description element gets
hidden only when the container size is less tha 100px not screen size.
The change is visible for image preview in small screen as action
button takes much of space. Meanwhile in video-preview the description
is still visible as we have much space even in small screen.
2025-01-16 09:01:51 -08:00
Sourabh Patel
194a9f762c lightbox: Remove unused media query styles for cleaner CSS. 2025-01-16 09:01:51 -08:00
Sourabh Patel
bff652a565 lightbox: Update iframe styles to use aspect-ratio.
Using width 100% with a max-width improves the view for tall screen.
Dynamic max-height is just to ensure that it adjust itself for
much wider screen with very less height.
2025-01-16 09:01:51 -08:00
Sourabh Patel
0739de6fdc lightbox: Adjust line-height to avoid vertical overflow.
This nullifies the vertical overflow due to transform scaleY.
2025-01-16 09:01:51 -08:00
Sourabh Patel
ca1a25c994 lightbox: Simplify media description styles for better responsiveness.
Give media-description all the available space using flex-grow.
Setting min-width to zero helps to truncate overflowing text.
2025-01-16 09:01:51 -08:00
Sourabh Patel
51956c6806 lightbox: Refactor styles for improved layout and spacing.
Proper use of flex properties for consistent layout and spacing
while avoiding use of margin that can result in extra spacing
around first and last child.
2025-01-16 09:01:51 -08:00
Sourabh Patel
fcaa77ffba lightbox: Update styles with flexbox to avoid height calculation.
Using flex-grow ensures that component fills up the available
space without the need of calculation of height.
2025-01-16 09:01:51 -08:00
Lauryn Menard
e963d5eaa9 billing: Fix deleting next fixed-price plan via support.
If the customer has a current fixed-price plan and a support admin
configures a fixed-price plan for the upcoming billing year, then
a CustomerPlan object is created and not a CustomerPlanOffer.

Fix the support action for deleting a configured fixed-price next
plan.

Updates the success strings for these actions to be specify if the
deleted object was a plan offer or a scheduled plan.
2025-01-15 11:23:24 -08:00
Alya Abbott
06a776e7b6 help: Document how previews of large animated images work. 2025-01-15 09:56:19 -08:00
Alex Vandiver
8bd8a33dd2 thumbnail: Show the first few frames of large animated images.
71406ac767 switched the IMAGE_BOMB_TOTAL_PIXELS cutoff for what
images we preview to include the number of frames in the calculation.
While accurate to the implementation (thumbnailing a 1k-frame animation is
prohibitive, even a small resolutions), this was a behaviour change
from without thumbnailing -- animated gifs did not display inline at
all anymore.

Switch to thumbnailing as many frames as we can fit into a pixel-based
animated thumbnailing threshold, with a minimum of three (to be able
to convey that the image is actually animated).  Smaller-resolution
images will hence get more frames in their preview.  This also allows
the standard animate-on-hover or always-animate behaviour to be true
to their configurations, without confusing edge cases.

Fixes: #32609.
2025-01-15 09:56:19 -08:00
Karl Stolley
ea3cd18382 compose: Hide scrolling buttons with keyboard focus. 2025-01-14 15:52:02 -08:00
Karl Stolley
dcb7acfde3 compose: Show or hide scrolling buttons on scroll event.
Fixes: #31215
2025-01-14 15:52:02 -08:00
Karl Stolley
c6bdebec03 compose: Add logic for scrolling buttons. 2025-01-14 15:52:02 -08:00
Karl Stolley
afb57c6c9c compose: Determine need for scrolling buttons on sidebar toggles. 2025-01-14 15:52:02 -08:00
Karl Stolley
8feaa5e6e8 compose: Initialize scrolling buttons only when needed. 2025-01-14 15:52:02 -08:00
Karl Stolley
a5e234f8ff compose: Size help button to match all others. 2025-01-14 15:52:02 -08:00
Karl Stolley
0d0aaa8586 compose: Introduce scrolling buttons in gridded layout. 2025-01-14 15:52:02 -08:00
Karl Stolley
cf29edaa65 compose: Flatten a popover-free formatting bar. 2025-01-14 15:52:02 -08:00