This commits remove the unused block of code which involves
`failed_listing_users` when there is no users to list.
Since, this is a case which is not possible to occur because there
should always be at least one active user, i.e. yourself.
Instead of mutating data object with fields
that it does not have at declaration, we should declare the
complete object once.
This is a prep-commit for upcoming TypeScript migration of module.
We can remove some of the CSS properties for
".clear_search_button" selectors because they
were being overridden by CSS set using more
specific selectors or by CSS set using
".bootstrap-btn" selector.
As a result, we can remove some the overriding
CSS as well where they were being used to set
default values.
This commit updates CSS to use grid layout for stream
search input in user profile modal so that we can have
clean CSS and do not have different values for padding,
right and margin properties at different places.
This also fixes the alignment of "x" button.
Also, the heading and search input were not aligned
perfectly, so changed the CSS to they align better.
This commit updates CSS to use grid layout for search input
in recent conversations view so that we can have clean CSS
and do not have different values for padding, right and margin
properties at different places.
This also fixes the alignment of "x" button.
This commit is to use medium-size avatar images when previewing avatars during the copy account settings flow. Before this commit, the avatar images were blurry when using the avatar from an existing account while joining a new realm. Now, the avatar is clear.
Fixes#32604.
This prep commit extracts the logic for converting Slack formatted text
into Zulip friendly markdown from `convert_to_zulip_markdown` into a new
helper function, `convert_slack_formatting`.
This is done to make reformating logic be reusable else where such as in
the Slack webhook or Slack incoming webhook.
This prep commit extracts the logic for reformatting Slack mentions into
Zulip mentions from `convert_to_zulip_markdown` into a new helper
function, `convert_slack_workspace_mentions`.
This is done to make the reformatting logic be reusable else where such
as in the Slack webhook or Slack incoming webhook.
This prep commit moves `convert_to_zulip_markdown` and
`convert_markdown_syntax` so that they appear after the various
helper functions used in the main logic for converting Slack
messages to Zulip's formatting. This adjustment aligns with code
style conventions, improving readability.
The change also prepares the codebase for reusing Slack text
reformatting logic in the Slack incoming webhook.
This commit changes the behavior of the topic actions popover
(displayed from the left sidebar via the `...` menu) to no
longer appear for empty topics (topics with no messages).
Instead, a message is displayed: "There are no messages in
this topic.", along with the topic visibility options and
the name of the topic.
Fixes: #32098.
Forward message previously didn't open the recipient dropdown
when forwarding from the combined feed.
This commit will also make the messages keep their original
channel or pm-recipient when forwarding from combined feed, to
be consistent with the behavior in the rest of the app.
This commit fixes the code to add a check for whether the
setting is set to an anonymous group or not before checking
if the setting is set to "Nobody" group by checking the
group name.
This commit renames the 'queue_json_publish' function to
'queue_json_publish_rollback_unsafe' to reflect the fact that it doesn't
wait for the db transaction (within which it gets called, if any)
to commit and sends event irrespective of commit or rollback.
In most of the cases we don't want to send event in the case of
rollbacks, so the caller should be aware that calling the function
directly is rollback unsafe.
Fixes part of #30489.
Removes the unnecessary fields from bulk_access_users_by_email and
bulk_access_users_id, while also removing duplication of these lists
of fields.
"base_bulk_get_user_queryset", used when fetching a user
other than the acting user.
"base_get_user_queryset", used when fetching the acting user,
prefetching more fields.
There remains some inconsistency in the models.py functions that may
merit further investigation.
This, as well as increasing the spacing by 5px, ensures that the left
sidebar bottom elements aren't overlapped by URLs that the browser
shows in the corner when hovering links.
