paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-17 12:21:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
41,452 Commits 30 Branches 160 Tags
c6e553427a8348a1e6bfd38ef3cbc8f5f5535fc7
Commit Graph

53 Commits

Author SHA1 Message Date
Steve Howell
686ae3eef4 node tests: Use less mocking for stream events. 
We now use the real implementation of
`stream_data` in our tests (as well as `people`),
while still just checking stubs for "heavier"
functions that we dispatch to.

Also, we use our regular blueslip helpers.
 2020-06-13 15:35:39 -07:00
Steve Howell
186973cde2 refactor: Extract add_peer and remove_peer helpers. 
These are basically shims for some deeper refactorings.

I basically just try to make the code express the
problems more clearly:

    - use stream_name instead of sub
    - make early-exit more explicit
    - make it clear that add_subscriber needlessly
      requires a name
    - make it clear we have an unnecessary loop

I also fixed some phony data in the test.
 2020-06-13 15:35:39 -07:00
Steve Howell
cc7e11f868 node tests: Extract lib/events.js. 
The immediate goal here is to make it a little
easier to share code among the node tests.
 2020-06-12 14:00:53 -07:00