bold_current_selection is a field within the options returned by
get_options, not a field on DropdownWidgetOptions itself.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Auto scrolling to view the new message is not working.
This bug was introduced in 238c35f2af.
Fixed by passing `messages_are_new` in the relevant functions.
This commit updates the code which computes the dict for
setting groups mapping named user groups to ID and anonymous
groups to UserGroupMembersDict. After the changes, the dict
contains only anonymous groups values and the setting values
for group IDs not present in dict will be computed based on
the fact that those are named user groups.
This is a preparatory refactor for optimizing computing group
setting values for register response by fetching all anonymous
groups membership data just once.
Previously we collapsed buttons when the two-panel view was narrow enough
that the buttons started wrapping, but this case for one-panel view with
wrapping buttons was missed.
This simplifies some @container queries and also ensures there's enough
space at larger font-sizes for the save/discard buttons to appear
beside setting section headings without overflowing onto the next line.
Now the left pane is always 40% and the right pane is always 60%.
One effect of this is that the top left buttons in the stream settings
overlay are now always in two rows at 16px (like they already always
were at 20px).
This mirrors the restrictions in
zerver.lib.message.bulk_access_stream_messages_query, in order to
prevent leftover UserMessage rows from granting access to messages the
user was previously allowed to access but no longer is.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
Previously, deactivating a bot from the bots tab without loading
the users tab caused a blueslip error because update_view_on_deactivate
tried to render uninitialized role dropdowns from a realm_user event.
This commit fixes this by passing is_bot to update_view functions
and only rendering dropdowns for non-bots if they’re initialized.
If the organization has limited message history to moves only,
we display "MESSAGE MOVE HISTORY" for the overlay header, instead
of "MESSAGE EDIT HISTORY".
If the organization only allows viewing message move history, in
the message edit history overlay for the initial message, we display
the original topic and channel of the message instead of the original
message content.
This way the overlay content is consistent with the organization
setting for viewing message edit history, and if the message content
has been edited, that original content is not viewable to other
users.
This generalizes from thumbnail_workers, to include any other queue.
We only additionally choose to document `email_senders_workers`,
however, since other queues are not guaranteed to work correctly with
multiple consumers.
Previously, users could send messages before uploads finished,
resulting in incomplete messages with "Uploading..." text.
This commit blocks sending until uploads complete.
Fixes: #33986.
In direct messages, the blue message focus ring could, at certain zoom
levels, be clipped near date rows.
The cause was a redundant background-color on .date_row interacting
badly with zoom. We previously debugged this problem more broadly and
fixed it in #25806, but missed this redundant declaration.
Fixes#33571.
Previously on subscribing, channels used to appear in the left panel
regardless of the filter. Now, channels that don't match the
filter are hidden from the left panel.
