Commit Graph

2529 Commits

Author SHA1 Message Date
Karl Stolley
c9ffd17d2d home_views: Let Recents/Inbox view filter fit content.
(cherry picked from commit 55ea5be022)
2025-03-27 16:53:35 -07:00
Aman Agrawal
03ecbd6654 channel_settings: Fix channel name incorrect hidden.
`max-width` was not working correctly here. Removing it gets
us in good state.

(cherry picked from commit 5ad100afef)
2025-03-27 16:53:35 -07:00
Sayam Samal
260c56ab0c banners: Fix banner action buttons vertical alignment.
(cherry picked from commit 5f0a55544b)
2025-03-27 16:53:35 -07:00
Sayam Samal
b7919e1957 banners: Update banner layout.
This is follow-up commit for d00b4cb0bd,
which updates the padding of the banner label and banner close button
to accommodate the previous font size change.

(cherry picked from commit 836e04fac8)
2025-03-27 16:53:35 -07:00
Sayam Samal
26c983d717 banners: Improve banner scaling with font size.
This commit converts the pixel values to em instead to make the banner
scale better with the different font sizes.

(cherry picked from commit bf88426cd1)
2025-03-27 16:53:35 -07:00
Evy Kassirer
c1a00e7308 stream_settings: Move muted channels help text to below header.
(cherry picked from commit 8adb46867b)
2025-03-27 16:53:35 -07:00
Karl Stolley
c2fc886a8a left_sidebar: Avoid misaligned unreads on Safari.
(cherry picked from commit 852b957da8)
2025-03-27 16:53:35 -07:00
Aman Agrawal
a42d31bcb2 subscriptions: Fix wrapping of channel name above 18px font size.
We limit the width of the channel title and show ellipsis for
overflowing channel name.

(cherry picked from commit c7364fafe5)
2025-03-26 10:55:07 -07:00
Prakhar Pratyush
a54bd3cdfa compose_recipient: Avoid using .css() for visibility toggling.
This commit replaces direct `.css("visibility", "...")` calls
with `.addClass("visible")` and `.removeClass("visible")` to
manage the `$topic_not_mandatory_placeholder` visibility.

This improves maintainability by keeping styling in CSS.
2025-03-20 10:32:31 -07:00
Tim Abbott
bccc283554 Revert "compose: Fix buttons spilling from compose box."
This reverts commit 9243fa3d52.

This commit appears to have caused the same issue with the compose box
borders at other size/zoom configurations that may be more common.

We'll figure out a better fix and apply that.
2025-03-20 09:28:05 -07:00
Karl Stolley
7be9ac9883 stream_settings: Better handle word breaks. 2025-03-19 11:35:11 -07:00
harshbansal8705
8402323cb5 stream_settings: Improve handling of long stream titles in UI.
This commit makes the following changes to improve the display of long
stream titles in the stream creation and user group settings UI:

- Uses `display: -webkit-box` and `line-clamp` properties to show the
title upto two lines, and end with `...` if it exceeds.
- Updates icon `font-size` to align with text size.
- Updates `margin` and `line-height` to make it visually better.
2025-03-19 11:35:11 -07:00
harshbansal8705
9243fa3d52 compose: Fix buttons spilling from compose box. 2025-03-19 11:32:51 -07:00
apoorvapendse
353f57e518 copy: Style KaTeX annotations to be included in copy HTML.
We've for a while been finding that copy/paste of LaTeX only worked if
we had a more JS-heavy copy handler that directly copies the HTML/text
using events, rather than just allowing the browser's native copying
logic to do its thing.

We've discovered the bug was that the `<annotation>` tag in MathML is
not rendered in some browsers which results in default copy behavior
of the browser breaking KaTeX copy-pasting and quoting by omitting the
`<annotation>` in the copied HTML as Chrome and possibly other
browsers select only what is visible.

From https://www.w3.org/TR/selection-api/

> Chrome 16 dev behaves as you'd expect given its Selection
implementation. It refuses to select anything that's not visible, so
it's almost always wrong. Opera 11.50 just does nothing in all my
tests, as usual.

This can be observed in the `paste_html` fixtures present in
https://github.com/zulip/zulip/pull/33993#issuecomment-2725417637.

We fix this by simply overriding the `display:none` property from the
<annotation> tag in the user agent stylesheet, which lets the browser
select and ultimately copy it which results in the annotation being
present in the `paste_html` and restore the working of KaTeX
quoting/copy-pasting.

This appears to have no visible impact, since browsers don't actually
have a way to display the annotations.
2025-03-19 10:07:32 -07:00
Aman Agrawal
8858f03847 compose: Revert send button color to that in 9.x.
This reverts commits 9501082e99 and 
a8cfd2fb04.
2025-03-19 09:00:49 -07:00
Karl Stolley
7f8899bf99 message_edit: Preserve width of Save button when showing spinner. 2025-03-18 13:15:10 -07:00
Karl Stolley
e0aeb5cb52 recent_view: Enable avatars and overflow marker to scale. 2025-03-18 09:12:01 -07:00
Karl Stolley
0f17d6e7ef compose: Remove browser-default outline on Send button. 2025-03-18 09:10:54 -07:00
Karl Stolley
9b33a81351 compose: Remove focus-visible color from Send button. 2025-03-18 09:10:54 -07:00
evykassirer
194c338b30 search: Increase min width of search pill label. 2025-03-17 17:04:28 -07:00
evykassirer
07d72a1d39 search_pill: Use sizes in grid declaration to improve narrow screen UI.
This makes sure the padding around the label is always present and that
the avatar and exit buttons don't get squished.
2025-03-17 16:56:16 -07:00
evykassirer
ba55ddf1d0 user_pill: Use variables for sizing and scale with font-size.
Using variables because they'll be used in the next commit
for search pills.
2025-03-17 16:56:15 -07:00
Tim Abbott
29f3acaf1e message_edit: Use brand colors for save button.
Matching the blue/info color that we're using for the send button
hasn't felt good.
2025-03-17 14:15:12 -07:00
whilstsomebody
24ada051dd Subscriptions: Fix the left offset of the group name.
This commit fixes a bug reported on CZO where the group
name appears offset to the left by a few pixels compared
to the description and other settings.

See CZO:
<https://chat.zulip.org/#narrow/channel/9-issues/topic/name.20of.20user.20group.20is.20misaligned>
2025-03-17 14:08:12 -07:00
Anushrut pandit
889c9a0a94 dropdown_container: Fix dropdown list focus outline clipping
Adjust the focus style for dropdown list items in inbox and recent-view.This ensures the focus outline is fully visible
across different zoom levels and fixes #34020
2025-03-17 14:07:33 -07:00
Karl Stolley
61f5bd6a4c spectator_view: Improve righthand alignment of standalone search icon.
Fixes: #34007
2025-03-17 13:54:39 -07:00
Karl Stolley
589c713c13 search: Simplify grid for standalone search icon. 2025-03-17 13:54:39 -07:00
Sayam Samal
d00b4cb0bd banners: Scale with base font size. 2025-03-17 11:43:57 -07:00
Vector73
9c5535f447 saved_snippets: Use intent="neutral" for edit icon. 2025-03-17 11:03:25 -07:00
Sahil Batra
aa02eb1eba stream: Modify warning shown when archiving announcement stream.
This commit updates how we show the text mentioning that archiving
a stream which is used for new user, new channel or update
announcements will result in the announcements not being sent.

Fixes #33379.
2025-03-17 11:02:55 -07:00
Aman Agrawal
5c1bba369d message_list_hover: Optimize code for show edit message icon.
Doing a lot of DOM manipulation on message hover leads to
tooltips being not hidden / displayed when they should be.

This commit is an attempt to optimize that code to do minimal updates.
2025-03-17 11:00:04 -07:00
Prakhar Pratyush
4cc0d52f74 move_topic: Improve placeholder when topic is not mandatory.
Earlier, we used to show "general chat" as the placeholder.

This commit adds support to show "Enter a topic (skip for general
chat)" as the placeholder when topic is not mandatory in the
move-topic-new-topic input box.

We show "general chat" (as we show in compose topic input box)
when move-topic-new-topic input box is not focused and topic="".

Fixes #33846.
2025-03-17 10:56:01 -07:00
ahmedgulabkhan
d69d2d8b9f settings: Update bot icons to be vertically aligned.
Current bot icons were not aligned vertically, this commit fixes it.
2025-03-17 10:52:25 -07:00
ahmedgulabkhan
d9573a62d4 user-admin-invite: Update icon for invite users in admin panel.
Co-authored-by: Lauryn Menard <lauryn@zulip.com>
2025-03-17 10:52:25 -07:00
ahmedgulabkhan
3ece6ca196 user-settings: Update icon for managing a user or bot.
Co-authored-by: Lauryn Menard <lauryn@zulip.com>
2025-03-17 10:52:25 -07:00
ahmedgulabkhan
c0b3fb1bbe user-settings: Update icon for deactivating user or bot.
Co-authored-by: Lauryn Menard <lauryn@zulip.com>
2025-03-17 10:52:25 -07:00
ahmedgulabkhan
50582b72b6 user-settings: Update icon for reactivating user.
Co-authored-by: Lauryn Menard <lauryn@zulip.com>
2025-03-17 10:52:25 -07:00
Sahil Batra
a1a3ce8479 settings: Fix showing tooltip when permissions panel input is disabled.
Since the input-group covered all the available space, tooltip looked
like it is separated from the checkbox label. This commit fixes the
width of input-group to be just wide enough to contain the content
when the setting is disabled so that tooltip is positioned correctly.
2025-03-17 10:24:20 -07:00
Aman Agrawal
49a9197c52 compose: Use info colors for send button. 2025-03-17 10:23:48 -07:00
Sayam Samal
987bde8cd3 connection_error_banner: Hide loading indicator on hover.
This commit enables the retry button even when the loading indicator
is being shown, and hides the loading indicator in favor of the original
button content to indicate that the button is still interactable.

Fixes part of #33924.
2025-03-17 09:47:52 -07:00
evykassirer
6e36c6de16 channel_picker: Align icon by keeping constant line-height.
Fixes issue reported here:
https://chat.zulip.org/#narrow/channel/9-issues/topic/.F0.9F.8E.AF.20channel.20picker.20icon.20alignment/near/2122798
2025-03-14 17:20:45 -07:00
evykassirer
f3377e90a4 subscriptions: Use only one container for the two-row header styles. 2025-03-14 16:35:05 -07:00
evykassirer
02edb62d33 settings: Collapse buttons to two rows on narrow screens with one panel.
Previously we collapsed buttons when the two-panel view was narrow enough
that the buttons started wrapping, but this case for one-panel view with
wrapping buttons was missed.
2025-03-14 16:35:05 -07:00
evykassirer
f00cc8f14d settings: Center save/discard buttons vertically. 2025-03-14 16:35:05 -07:00
evykassirer
6f9ad9e74b settings: Wrap save/discard buttons as a unit on narrow screens. 2025-03-14 16:35:05 -07:00
evykassirer
dfe3769d97 settings: Increase size of right pane of subscriptions/usergroups modal.
This simplifies some @container queries and also ensures there's enough
space at larger font-sizes for the save/discard buttons to appear
beside setting section headings without overflowing onto the next line.

Now the left pane is always 40% and the right pane is always 60%.

One effect of this is that the top left buttons in the stream settings
overlay are now always in two rows at 16px (like they already always
were at 20px).
2025-03-14 16:35:05 -07:00
evykassirer
3cb9ebd4a0 settings: Clean up styling for save/discard buttons.
This commit scales the X icon with font-size, centers it more
consistently, and scales the button height with font-size.
2025-03-14 16:35:05 -07:00
evykassirer
88a5630960 subscriptions: Scale tab width with font size. 2025-03-14 16:35:05 -07:00
evykassirer
8a5bdcbe9f popovers: Fix bug where tippy was getting cut off in usergroup list. 2025-03-14 16:21:57 -07:00
Karl Stolley
42e1b104e2 action_buttons: Remove bottom margin from Bootstrap. 2025-03-14 13:00:54 -07:00