paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity
59,228 Commits 30 Branches 160 Tags
cb1531b061144d79fbb4079b66bf69077e8d3db3
Commit Graph

1016 Commits

Author SHA1 Message Date
evykassirer
7f9361a865 composebox_typeahead: Filter and sort candidates within get_candidates. 
This simplifies some of the logic and will make it easier to
convert to TypeScript.
 2024-05-16 14:51:28 -07:00
evykassirer
96abc52d97 composebox_typeahead: Return mentions from get_candidates. 2024-05-16 14:51:28 -07:00
evykassirer
19a4810d53 composebox_typeahead: Remove DM blur handler. 
Since #private_message_recipient is a <div contenteditable>,
not an <input> or <textarea>, it doesn’t make sense to call
.val() (it will always give the empty string).

It looks like this line is from over 10 years ago
(09deef9611 (diff-f2b22549dc2fb4824b37e787d964a2c9f4f580e767f86b6d7ded1d0ff37d5a62R291))
and probably before we had pills here. We can just remove this
whole block.
 2024-05-16 14:51:28 -07:00
evykassirer
e08c7548af composebox_typeahead tests: Create user_or_mention items directly. 2024-05-16 14:51:28 -07:00
evykassirer
7a9a445088 emoji: Restrict reaction_type for compatibility with typeahead.Emoji. 2024-05-16 14:51:28 -07:00
Aman Agrawal
b2dc6f4039 people: Split search terms inside the search function. 
This helps other views calling this function to not do a separate
split of the terms.
 2024-05-16 09:20:43 -07:00
Aman Agrawal
2a8174baa3 recent_view: Rename filters_should_hide_topic. 
Since we also filter DMs using this function, the name is
misleading.
 2024-05-16 09:20:43 -07:00
Aman Agrawal
aa31f9ae8d server_events: Fix infinite loading indicator on page load. 
Hiding the loading indicator was based on us adding some messages
into the view which was no always the case.
 2024-05-16 09:10:07 -07:00
AfonsoOrmonde
b42cd1022b streams: Close color picker when scrolling stream settings. 
Fixes #17451.
 2024-05-15 17:22:03 -07:00
Anders Kaseorg
fba81d1cd5 upload: Convert module to TypeScript. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-15 10:53:09 -07:00
Anders Kaseorg
97b0fd424d upload: Replace get_item with config object methods. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-15 10:53:09 -07:00
Anders Kaseorg
60545fb475 upload: Reimplement get_item with config object methods. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-15 10:53:09 -07:00
Anders Kaseorg
25b29b5cd4 upload: Centralize config object construction. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-15 10:53:09 -07:00
Anders Kaseorg
d9f05121d9 upload: Fix @uppy/xhr-upload locale configuration. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-15 10:53:09 -07:00
Anders Kaseorg
b132fc50b3 compose_reply: Convert module to TypeScript. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-15 10:53:09 -07:00
Anders Kaseorg
4d407c6b8d copy_and_paste: Convert module to TypeScript. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-14 14:12:05 -07:00
Aman Agrawal
a30029c8ad upload: Don't render upload button instead of hiding. 
Doesn't make sense to hide the upload button button later when
we can just not show it if the browser doesn't has support for
it.
 2024-05-14 12:21:49 -07:00
nimishmedatwal
941c5daf36 navbar: Describe views in top navbar. 
Adds description in views styled like stream descriptions also adds a
help center link to the appropriate page at the end of each
description.

Fixes #29769.
 2024-05-13 17:56:30 -07:00
evykassirer
724306df10 recent_view_ui: Convert module to typescript. 2024-05-13 12:51:00 -07:00
evykassirer
28c13f6d0e message_store: Modify get_pm_full_names to only take user ids. 
This will let us properly call it from compose_closed_ui without
a full message object, which we need to convert it to typescript.
 2024-05-12 17:41:22 -07:00
Aman Agrawal
d4ea7e251b narrow: Fix browser back not navigation to previous selected message. 
Reproducer:
* Go to a stream narrow.
* Scroll up to select a previous message.
* Click on a different stream in the left sidebar.
* Click browser back button, you land at first unread message instead
  of your selected message.

Fixed by updating the hash before we render the new message list.
 2024-05-10 16:03:45 -07:00
Prakhar Pratyush
bf2360bcf2 onboarding_steps: Remove hotspot as an onboarding_step. 
Earlier, hotspots and one-time notices were the valid
type of onboarding step.

Now, one-time notice is the only valid type.

Fixes #29296.
 2024-05-10 12:30:22 -07:00
N-Shar-ma
cb58752909 widgets: Cache event handler instead of entire jquery for each widget. 
In 61b3c698af we stopped restoring widgets
from the cache, so the only purpose of the cache remaining was to access
the event handler patched onto the widget jquery.

Now instead of the entire jquery object, we cache just the event handler
since that's the only thing we need from the cache, and do not patch it
onto the widget jquery object.
 2024-05-08 16:47:07 -07:00
Aman Agrawal
d1050376e1 bootstrap_typeahead: Fix compose typeahead overflowing when expanded. 
When compose box is expanded, typeahead overlfows the top of the window.
We move the typeahead to the bottom of the screen and let
preventOverflow shift it into the visible area.
 2024-05-08 10:05:27 -07:00
Aman Agrawal
689489573a bootstrap_typeahead: Remove fixed argument. 
Tippy uses a different strategy for positioning items, so this
will not be required.
 2024-05-08 10:05:27 -07:00
N-Shar-ma
61b3c698af widgets: Always render and activate widgets in the current view. 
Earlier we did not activate widgets if their rendered HTML was cached,
and also when narrowing to the combined feed view. This caused bugs with
widgets not being activated, and so not responding to any interactions.

Now we unconditionally render and activate widgets in the current view,
irrespective of the cached HTML or the view being narrowed to.
 2024-05-07 12:59:47 -07:00
Anders Kaseorg
49e1c919c3 drafts: Convert .data("draft-id") to a module variable. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-07 12:57:14 -07:00
evykassirer
3cad639a82 typeahead: Add textarea input type for the composebox. 2024-05-07 11:12:01 -07:00
evykassirer
9cb9733f71 composebox_typeahead: Remove unused second argument to caret(). 2024-05-07 11:12:01 -07:00
nimishmedatwal
acf13e49cf rendered_markdown: Fix code getting copied when visiting playground. 
Fixes #29844.
 2024-05-06 15:50:39 -07:00
Anders Kaseorg
7360fd2a67 bootstrap_typeahead: Remove create and lookup API. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-06 15:02:45 -07:00
Anders Kaseorg
40440248e6 support: Fix implicit use of any. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 15:39:55 -07:00
Anders Kaseorg
2be5cb0223 settings_user_topics: Fix implicit use of any. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 15:39:55 -07:00
Anders Kaseorg
939b88b9a7 settings_realm_domains: Fix implicit use of any. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 15:39:55 -07:00
Anders Kaseorg
fe6744ae54 input_pill: Fix implicit use of any. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 15:39:55 -07:00
Anders Kaseorg
ffd1a80ef4 common: Remove copy_data_attribute_value. 
Commit 90d0531e20 (#23721) removed
envelope-link and data-admin-emails.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 12:45:46 -07:00
Anders Kaseorg
eb45eca57b support: Replace common.copy_data_attribute_value with clipboard.js. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 12:45:46 -07:00
Anders Kaseorg
252b0f193e password_quality: Convert .data("minLength") et al. to .attr. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 12:45:46 -07:00
Anders Kaseorg
7a5e68161a list_widget: Convert .data("sort"), .data("sort-prop") to .attr. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 12:45:46 -07:00
Anders Kaseorg
64c2d442ac web: Convert .data("user-id") to .attr. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 12:45:46 -07:00
Anders Kaseorg
455f8a9c53 web: Convert .data("stream-id") to .attr. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 12:45:46 -07:00
Anders Kaseorg
bc9a7ef274 components: Convert .data("tab-id") to .attr. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 12:45:46 -07:00
Anders Kaseorg
153847d617 web: Convert .data("search-results-empty") to .attr. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 12:45:46 -07:00
Anders Kaseorg
abee323c77 web: Convert .data("code-language") to .attr. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 12:45:46 -07:00
Aman Agrawal
240f7b53b2 message_lists: Remove save_pre_narrow_offset_for_reload. 
This is no longer required since narrow state is restored by
`reload` library and narrow history restores the narrow pointer
and offset when going back to a view.

Only regression here is we will no longer restore the pointer when
user navigates to the combined feed view without using browser back
button and combined feed view is the default view. This is fixed
in the next commit.
 2024-05-03 12:42:22 -07:00
Aman Agrawal
2eb216f1da message_list: Only update selected id and banner for current list. 2024-05-03 12:42:22 -07:00
N-Shar-ma
5d468ddef8 left_sidebar: Add colon : to the list of stream word separators. 2024-05-03 09:20:53 -07:00
Prakhar Pratyush
d7a9523170 compose_banner: Replace the close button with "Got it" button. 
For onboarding banners, we replace the close button with
"Got it" button.

Also, the banner is marked as read for the user only after
the "Got it" button is clicked. Earlier it was marked as read
as soon as it was displayed.
 2024-05-02 12:48:22 -07:00
Lalit
0a66fada64 input_pill: Use "input" event handler for textInputHook. 
Register our `onTextInputHook` to be called on "input" events so that
the hook receives the updated text content of the input unlike the "keydown"
event which does not update the text content before running the hook.
 2024-05-02 12:01:30 -07:00
Lauryn Menard
141e1d4c90 streams-settings: Update ID of overlay container element. 
This commit renames ID of the container element of streams settings
overlay to channels_overlay_container for the stream to channel
rename.
 2024-04-30 14:44:12 -07:00