Previously, pressing Esc while the "Filter topics" input was empty would
de-focus the input. Pressing Esc again would trigger the
"BACK TO CHANNEL" action, hiding the zoomed topic. However, this
behavior was broken as the input was not triggering any blur event,
making Esc a noop.
This commit restores the expected behavior by ensuring the blur event is
properly triggered, allowing Esc to function as intended.
Fixes#35150
Fixed by adding more fallback options.
Reproduced by clicking on left sidebar or inbox channel popover
triggers at the bottom right corner.
The result message shown when adding members to a stream
previously listed the name of every member being added,
which could be noisy for large groups.
This commit updates stream_subscription_request_result.hbs to
conditionally display clearer, more concise messages based
on the number of subscribed and already subscribed users.
This improves readability and user experience when handling
large subscription actions.
Fixes part of #34347
Co-authored-by: Rajeev Tapadia <108951750+rajeevtapadia@users.noreply.github.com>
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
Adds a loading spinner for both `Unsubscribe` and `Remove`
buttons in channel and group settings.
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
Previously, due to a logic issue, the clear status icon did not
appear when there is only selected emoji in the status—it appeared
only when status text was present.
This commit fixes the bug and now the clear status icon disappears
only when neither status text nor a selected emoji is present.
Fixes: #35176
This commit adds maxlength attribute with value set to 100 to
name inputs in both "Manage user" and "Manage bot" modals since
we allow maximum 100 characters for both user and bot names.
The "maxlength" attribute for "Full name" input in "Profile"
settings panel was incorrectly set to 60, when we allow
maximum 100 characters. This commit fixes that.
We show the UI to send email to the user being deactivated when
deactivating user from button in "Manage user" section of user
profile modal, but the email text was not included in the API
request sent to server and thus no email was sent. This commit
fixes it to send the email if it was configured while deactivating
the user from "Manage user" modal.
0229f73fae introduced a bug wherein
while caching the media assets keyed using the message id, previews of
media from composebox which also used same codepath attempted to find
the message id from the asset. This resulted in an assertion error.
This is fixed by making sure that compose previewable assets are
never cached nor attempted to fetch from cache since they don't
have a message id yet.
Co-authored-by: Tim Abbott <tabbott@zulip.com>
Clicking on the stream row should open the message view
as per "Channel links in the left sidebar go to" setting.
But this happens only when clicking on stream name element
and not on the complete stream row, like clicking on the
privacy icon or towards the left of it, opens the channel
feed always irrespective of the setting. This commit
fixes that.
Updated the code to attach the "New topic" button handler
to "#stream_filters" element instead of "body", as it was
not being executed due to stopPropagation being called in
the click handler for "a" element for stream row.
Attaching the event to "#stream_filters" makes sure that
clicking on "New topic" button calls the handler for it
first and stops event from being propagated to the "a"
element for stream row.
Also moved "New topic" handler to stream_list.ts, as it
would be easy to maintain them if all handlers for the
UI are in the same file.
This also fixes the bug when pressing "Enter" key after
clicking on a stream row did not open the compose box for
replying to the selected message which is the expected
behavior when "Channel links in the left sidebar go to"
setting is set to value other than "List of topics".
Fixes#31287.
These tags are not limited to just KeyboardTip, so we want to run the
transformation on all html.
We need to run the transformation client-side since the user's keyboard
style is only known at that time.
We had to override the HEAD component since that's what starlight
recommends to do if we want to include local assets on every page. If we
were using a remote js file, we could have modified the head config
option provided by starlight.
The script file to adjust the tags is mostly just copy-paste of the
original function to adjust for the lack of JQuery. Most of the comments
are also copy-pasted.
One change in the new script is to just use ⌘ symbol directly instead of
using zulip-icon since we don't have any centering problems in the new
help center.
This also ends up consistently calling clear_topic_moved_info for all
code paths where we exit the function without adding a banner. It
might be better to just call that clear function at the start; I'm not
entirely sure why we don't do that.
This commit Removes `deactivate-user-button` and
`reactivate-user-button` classes.
These classes were originally introduced in commits
50582b72b6 and
c0b3fb1bbe for the sole
purpose of styling. The associated styles were later removed
in 1c89c3e647 but the classes
themselves were mistakenly left behind.
Removing them has no effect in the functionality of the
buttons and there is no evidence of any bugs or regression
caused by their removal.
