Commit Graph

2157 Commits

Author SHA1 Message Date
apoorvapendse
8ca2ec4363 inbox: Use _html naming convention for content rendered as HTML.
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-07-28 12:56:44 -07:00
apoorvapendse
33e728e586 user_membership: Use banner template to render messages.
We now resort to using banner template instead
of trying to maintain our own banners
in the stream subscription and user group
membership templates.

Fixes: https://chat.zulip.org/#narrow/channel/9-issues/topic/.F0.9F.8E.AF.20User.20add.20success.20banner.20squashed/near/2229035.
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-07-28 12:33:20 -07:00
apoorvapendse
c6a64b3c1d stream_subscription: Use banner template to render messages.
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-07-28 12:33:20 -07:00
apoorvapendse
818a3365af banner: Allow label to be in HTML format.
This is done to later render the subscribe
success and error messages using the banner
template instead of using the banner classes
in the subscription/memebership templates
which requries us to duplicate the changes
in banner.hbs at these places to avoid
regressions.

Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-07-28 12:33:20 -07:00
Sahil Batra
c300775282 channel-folders: Enable channel folders UI in production. 2025-07-28 11:00:45 -07:00
Evy Kassirer
e63ee026fe left_sidebar: Hide inactive channels in channel folders. 2025-07-28 10:28:01 -07:00
Evy Kassirer
e6fecfc8eb left_sidebar: Show channel folders in left sidebar.
Fixes part of #31972.
2025-07-28 10:28:01 -07:00
Evy Kassirer
bc6b0cccf4 left_sidebar: Add unread markers to channel section headers. 2025-07-28 10:28:01 -07:00
Evy Kassirer
739debf7b4 left_sidebar: Add plus icon to channel section headers. 2025-07-28 10:28:01 -07:00
Evy Kassirer
08fd7a30f9 left_sidebar: Add plus icon beside channel search bar.
This button was previously found when hovering on the CHANNELS
header, but now that we've removed that header, we show the
button here instead, and always visible.
2025-07-28 10:28:01 -07:00
Evy Kassirer
9478525f15 left_sidebar: Remove #streams_header and related code.
This component no longer exists with the new design.

Everything removed here that's still relevant (unread counts, special
logic for spectator view) is added back, at the section/channel folder
layer, over the next several commits.
2025-07-28 10:28:01 -07:00
Evy Kassirer
27092d5543 left_sidebar: Change channel sections to togglable sections. 2025-07-28 10:28:01 -07:00
Evy Kassirer
dc013b6a10 left_sidebar: Show the search bar all the time.
This is preparation for adding channel folders to the sidebar
and removing the CHANNELS header, where we'll want to have an
always open search bar.
2025-07-28 10:28:01 -07:00
Sayam Samal
5d4b9ee505 topic_popover: Show loading indicicator on topic resolve/unresolve.
This commit shows a loading indicator in the recipient bar when the
user resolves or unresolves a topic from the topic actions menu.

Since we do not have a unresolve icon button in the recipient bar
following commit 23ac87606a, we
first render a icon button with a placeholder icon in the recipient bar,
and then show the loading indicator when the user clicks on the
"Mark as unresolved" option in the topic actions menu.
2025-07-25 22:27:03 -07:00
Sayam Samal
701c81d919 left_sidebar: Make LOG IN TO BROWSE MORE link keyboard accessible. 2025-07-25 13:13:05 -07:00
Sayam Samal
2462a6b457 left_sidebar: Fix ENTER key behavior in back to channels in topics list.
This commit addresses the issue where pressing the ENTER key on the
"back to channels" link in the zoomed in topics list did not perform
the intended action by adding the `trigger-click-on-enter` class to
the element.
2025-07-25 13:13:05 -07:00
Sayam Samal
ac0f3a0817 left_sidebar: Fix ENTER key behavior in back to channels in DM list.
This commit addresses the issue where pressing the ENTER key on the
"back to channels" link in the zoomed in direct messages list did not
perform the intended action by adding the `trigger-click-on-enter`
class to the element.
2025-07-25 13:13:05 -07:00
Sayam Samal
fa266701e0 left_sidebar: Make DM list back to channels link keyboard accessible. 2025-07-25 13:13:05 -07:00
Sayam Samal
63200b9e9e left_sidebar: Fix ENTER key navigation in more conversations in DM list.
This commit addresses the issue where pressing the ENTER key on the
"more conversations" link in the direct messages list did not perform
the intended action by adding a `trigger-click-on-enter` class to the
element.

This allows the `process_enter_key` function to explicitly trigger a
click event on the element when the ENTER key is pressed, ensuring that
the associated click handler is called.
2025-07-25 13:13:05 -07:00
Alya Abbott
8b72f51156 recent: Follow current pattern for placeholder text.
We no longer show keyboard shortcuts in placeholders.
2025-07-25 12:37:31 -07:00
Sahil Batra
34cb0034e1 settings: Handle long names better in susbcribers and members list.
This commit updates the subscribers and group members table CSS to
use fixed layout. This helps in having user pill take the width if
available and we can show more characters.

Previously the width of name in user pill was set to have a max
width of 165px which meant the there was some empty unused space in
the rows especially on narrow screens when email column was hidden.

Fixes #35157.
2025-07-25 11:21:23 -07:00
Karl Stolley
ea58f35941 recent_view: Ensure all DMs get an identifying class. 2025-07-24 16:49:53 -07:00
Sayam Samal
d00cf1a0e8 banners: Improve responsiveness in normal banners.
This commit improves the responsiveness of normal banners by adopting a
flexbox layout for the label and action buttons. This change better
accommodates varying text lengths and button counts in the banners, due
to the natural flowy nature of flexboxes.

The key logic shift involves using `flex-basis` to manage layout
transitions: the label and the group of action buttons now wrap to
separate lines when the label's width is less than 60% of the banner
query container's width (60cqw).

This commit also updates the CSS for navbar banners to align with the
new flexbox layout between the label and the group of action buttons,
while also ensuring that the layout behavior of these banners remains
consistent with the previous implementation.
2025-07-23 12:01:33 -07:00
Sayam Samal
122d93d430 filter_input: Add explicit classname for filter clear button.
This commit adds an explicit "input-close-filter-button" classname to
the filter input clear button, improving the readability of the code.
2025-07-21 23:16:26 -07:00
Tim Abbott
6036dc9812 subscribers: Use _html in content inserted as HTML.
This makes it easier for maintainers to verify that code using `{{{`
is already rendered HTML, intended for insertion into the DOM.
2025-07-18 18:24:57 -07:00
apoorvapendse
0908f0ac30 settings: Include ignored deactivated users in result banner.
This introduces the ignored deactivated user messages
in the channel and user group subscription banners.
Related:
https://chat.zulip.org/#narrow/channel/101-design/topic/New.20channel.2Fgroup.20UX.20changes/near/2215785

Fixes #34347.
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-07-18 18:07:38 -07:00
apoorvapendse
aa56623deb user_groups: Improve clarity of subscription result message.
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-07-18 18:07:37 -07:00
Apoorva Pendse
eb6676f9b5 settings: Show a tick inside of add button on click.
We want the input field to retain
the same width even when
Add button shrinks, when we
show a check icon.

This solution involves layering
of the check and `Add` button
and toggling visibility.

Karl's coment: https://chat.zulip.org/#narrow/channel/6-frontend/topic/.2334347.20rework.20subscribe.20users.20confirmations/near/2206344.

Related: https://github.com/zulip/zulip/pull/34912#issuecomment-3010269391.

Reference:
https://chat.zulip.org/#narrow/channel/6-frontend/topic/.2334347.20rework.20subscribe.20users.20confirmations/with/2193352.
Co-authored-by: Rajeev Tapadia <108951750+rajeevtapadia@users.noreply.github.com>
Co-authored-by: Maneesh Shukla <shuklamaneesh24@gmail.com>
Co-authored-by: Karl Stolley <karl@zulip.com>
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-07-18 18:04:57 -07:00
Apoorva Pendse
f75fbdda8b channel_settings: Improve clarity of subscription result message.
The result message shown when adding members to a stream
previously listed the name of every member being added,
which could be noisy for large groups.

This commit updates stream_subscription_request_result.hbs to
conditionally display clearer, more concise messages based
on the number of subscribed and already subscribed users.

This improves readability and user experience when handling
large subscription actions.

Fixes part of #34347

Co-authored-by: Rajeev Tapadia <108951750+rajeevtapadia@users.noreply.github.com>
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-07-18 18:04:56 -07:00
apoorvapendse
e1a0385028 channel_settings: Move checkbox below the input field.
Prep commit for #34912.

Addresses: https://github.com/zulip/zulip/pull/34912#issuecomment-3013913429
(point 1)
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-07-18 18:04:56 -07:00
apoorvapendse
40a4666be8 channel_settings: Update add subscribers subtitle.
Addresses:
https://github.com/zulip/zulip/pull/34912#issuecomment-3013913429(point 2)

Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
2025-07-18 18:04:56 -07:00
Alya Abbott
fdb35f2f81 compose: Improve preview mode tooltips.
Also modernize help center instructions for message previews.
2025-07-18 17:22:34 -07:00
Aman Agrawal
61e25ff0cd channel_popover: Fix go-to-list-of-topics not working on enter.
Used `navigate-link-on-enter` class to fix it.
2025-07-18 16:41:26 -07:00
Aman Agrawal
2ba72101a2 inbox: Simplify keyboard navigation.
This makes use of `data-col-index` attribute on the elements
to know which column to focus based on user input.
2025-07-18 16:41:26 -07:00
Aman Agrawal
47f42ed149 inbox: Redesign to show channel folders. 2025-07-18 16:41:26 -07:00
Aman Agrawal
ded8f93ca0 inbox: Always show collapsed icon for collapsed headers. 2025-07-18 16:41:26 -07:00
Aman Agrawal
ebb0c9b496 inbox: Move collapse button after the header name. 2025-07-18 16:41:25 -07:00
Aman Agrawal
51047d3b43 inbox: Treat DM row as a folder row. 2025-07-18 16:41:25 -07:00
whilstsomebody
1c697a42ff user_status_ui: Show remove status icon when only emoji is present.
Previously, due to a logic issue, the clear status icon did not
appear when there is only selected emoji in the status—it appeared
only when status text was present.

This commit fixes the bug and now the clear status icon disappears
only when neither status text nor a selected emoji is present.

Fixes: #35176
2025-07-18 12:55:55 -07:00
Sahil Batra
80b9caa5ac user-profile: Add maxlength attribute to name inputs in edit form.
This commit adds maxlength attribute with value set to 100 to
name inputs in both "Manage user" and "Manage bot" modals since
we allow maximum 100 characters for both user and bot names.
2025-07-18 12:46:48 -07:00
Sahil Batra
b9e9697be2 settings: Fix maxlength for name input in "Profile" panel.
The "maxlength" attribute for "Full name" input in "Profile"
settings panel was incorrectly set to 60, when we allow
maximum 100 characters. This commit fixes that.
2025-07-18 12:46:48 -07:00
Pratik Chanda
e04e281413 search: Remove background suggestion highlight for text search.
This commit removes the background suggestion highlight in the
search suggestion for text search suggestion.
2025-07-17 15:57:53 -07:00
Vector73
a02614204a settings: Add can_set_delete_message_policy_group setting.
Adds new organization setting `can_set_delete_message_policy_group`
for defining who can set per-channel message delete permissions.

Fixes #34214.
2025-07-17 15:44:53 -07:00
Vector73
97a43fa6b6 stream_settings: Add can_delete_own_message_group setting.
Adds per-channel `can_delete_own_message_group` setting for
defining who can delete their own message in the channel.
2025-07-17 15:44:52 -07:00
Vector73
c4e641365b stream_settings: Add can_delete_any_message_group setting.
Adds per-channel can_delete_any_message_group setting for
defining who can delete any message in the channel.
2025-07-17 15:44:42 -07:00
Maneesh Shukla
3bd8c28fca buttons: Redesign some old-style buttons with rounded class.
Fixes part of #35006.
2025-07-16 14:46:23 -07:00
whilstsomebody
640286b91f admin_human_form: Update classes to kebab-case.
This commit updates the classes `.deactivate_user_button`
and `.reactivate_user_button` to kebab-case as per our
new rules for writing new classes.
2025-07-16 11:16:10 -07:00
whilstsomebody
6649efea70 settings_user_list_row: Remove redundant classes.
This commit Removes `deactivate-user-button` and
`reactivate-user-button` classes.

These classes were originally introduced in commits
50582b72b6 and
c0b3fb1bbe for the sole
purpose of styling. The associated styles were later removed
in 1c89c3e647 but the classes
themselves were mistakenly left behind.

Removing them has no effect in the functionality of the
buttons and there is no evidence of any bugs or regression
caused by their removal.
2025-07-16 11:16:10 -07:00
Sahil Batra
7b66eb838e groups-ui: Update error shown when group cannot be deactivated.
This commit updates error banner shown when group is only used
as subgroups and not as permission.

If group is used as a permission, then we mention that in the
error banner and have a button to go to "Permissions" panel.
We show the same banner even when group is used as a subgroup
as well. But when group is only used as subgroups, we just
show a message containing names of all the supergroups.
2025-07-15 11:57:42 -07:00
opmkumar
b5fc39044e left_sidebar: Fix unread counts showing for muted channels.
Previously, unmuted unread counts for muted channels were still shown
in the left sidebar even when the "Show unread counts for" setting was
set to "No channels".

This commit ensures that unread counts are correctly hidden for muted
channels based on user settings.
2025-07-15 11:38:13 -07:00