paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity
740 Commits 30 Branches 160 Tags
d619618fed0a30b51cced7c3e14aa9f94b2a7aae
Commit Graph

271 Commits

Author SHA1 Message Date
Keegan McAllister
d619618fed Move more validation 
(imported from commit 62d660a3c34f4aeb170771ee85580362a2c1b8a7)
 2012-10-03 18:26:00 -04:00
Keegan McAllister
0c76788ed5 Move some validation functions 
(imported from commit e482108981b2b4caa6159060729766b4d224db23)
 2012-10-03 18:25:59 -04:00
Keegan McAllister
c2ddde2053 Move some settings stuff into ui.js 
(imported from commit dea0a6fac11fb3349ac09e90c01d9313ee69c001)
 2012-10-03 18:25:59 -04:00
Keegan McAllister
ffff63eaad Move some subscriptions-related code 
(imported from commit 49f6e525e3aa8a7a5336f713c94e81fee6546dfa)
 2012-10-03 18:25:59 -04:00
Keegan McAllister
8d17de1247 Move some early setup code 
(imported from commit ca57718e4a71f43bbf229d2a6e8c70174bb3583f)
 2012-10-03 18:25:59 -04:00
Keegan McAllister
50d84e9ca8 Move some UI-related code 
(imported from commit 28dc554ed91c14f8a8b4be282a211d3d50cf9873)
 2012-10-03 18:25:59 -04:00
Keegan McAllister
37f8445318 Split more files out of zephyr.js 
I would like to have split this into several commits, but it's hard to do
incrementally, because functions need to be defined before their use in global
data.

(imported from commit 31533396b236f3b657950b073982c317256f082a)
 2012-10-03 18:25:59 -04:00
Keegan McAllister
f2a73985c9 Fix my own variable typo (whoops) 
(imported from commit d12467db2756281fe0710645825c54c269ab6781)
 2012-10-03 17:39:14 -04:00
Keegan McAllister
db224c1c24 Fix other problems in signup.js 
(imported from commit c4562cae29a635454990f093932ff8dd9879ead3)
 2012-10-03 17:34:53 -04:00
Keegan McAllister
d18a79ad07 Fix wtf control flow in signup.js 
(imported from commit d4cb46cda138c542884e0373b4498b4f7890ef51)
 2012-10-03 17:34:53 -04:00
Keegan McAllister
5a6247288a Fix typo'd variable 
(imported from commit 971e5d28cb14826b020d6e130cd62e600d88a168)
 2012-10-03 17:34:53 -04:00
Luke Faraone
3a7dda5099 Replace usage of send_status.toggle() with the more clear .show() 
(imported from commit 0593222b16bf845b7bcd9075d02c156a05764c12)
 2012-10-03 13:56:35 -04:00
Waseem Daher
2c294694fd Restyle narrowbar to avoid wrapping. 
Previously, when we narrowed on a super-long class/instance or
a huddle with lots of people, the box overflowed. This is an
attempt to fix that, even if it isn't the prettiest.

(imported from commit 4eb58726a4c4714bd5435a791ad8fea0eabb58ed)
 2012-10-03 13:38:33 -04:00
Keegan McAllister
66265aa5bf Get rid of the send status bar for non-error conditions 
(imported from commit 999ca5a02e95f4756e00b4769260f5a84e2440da)
 2012-10-03 13:15:22 -04:00
Jessica McKellar
97542d1eb5 Re-focus on new subscription input box on an invalid subscription. 
(imported from commit d4876dc43eabe73655928db58ca5ad1ed74fa336)
 2012-10-03 13:08:33 -04:00
Jessica McKellar
aa2e4efc2c Fix typo preventing focus on new subscriptions box after tabbing over. 
(imported from commit 45a6dd8e514a2233517cfaea5a5c0b8d94c62f46)
 2012-10-03 13:05:58 -04:00
Jessica McKellar
f4e04a045a Focus on new subscription text box after adding a new subscription. 
(imported from commit d23bc2d15cce67bc75c2f4ef406de73373b8f3ea)
 2012-10-03 13:05:58 -04:00
Keegan McAllister
6cdd1c3e8b Re-select the selected message by ID after prepending 
(imported from commit 24f6f17bee8c041fce39a710b8b77f14d3ef7dbe)
 2012-10-02 18:39:21 -04:00
Keegan McAllister
f03efcd788 Simplify initial pointer selection 
This code had decayed from something more substantial into a kind of silly loop.

(imported from commit a6668c19bd6d50325460ac4fa4146d7f82fec58b)
 2012-10-02 18:24:54 -04:00
Keegan McAllister
8bc01c85f1 Collapse new with old messages when prepending 
(imported from commit 0279183c9a2c70b1fe42f60f4423327aaf2dc7b8)
 2012-10-02 18:24:54 -04:00
Keegan McAllister
6baacf6815 Exit add_to_table early if we have no messages 
(imported from commit 3860d97344f6008d57829c0040363eb8491ec231)
 2012-10-02 18:24:48 -04:00
Keegan McAllister
10201460c8 Allow passing the table name to get_zephyr_row 
(imported from commit 098e64b5003eb7844f8d5ccd8aefd982af1b5c6e)
 2012-10-02 18:24:03 -04:00
Keegan McAllister
b8cca0a094 Track the groups of collapsed messages in each table 
(imported from commit 26df33856966f2ac4dc86de9f3436b4499c17089)
 2012-10-02 18:24:03 -04:00
Tim Abbott
d2884ba456 Make connection errors disappear more efficiently. 
Previously, connection errors would stick around after a problem with
the server until (1) the server was fixed and (2) we later received a
message.  This code change eliminates condition (2) by having the
server return immediately with no messages in the event that the
client has accumulated a large number of errors.

(imported from commit 6a9b08e534db6daea0041a71556ef5b708e935ed)
 2012-10-02 17:46:06 -04:00
Keegan McAllister
5fe3787ded Maintain one layout-setting row at the top of each table 
(imported from commit b375ea78d79ca39b486d124256d0d4e89558d83a)
 2012-10-02 17:21:20 -04:00
Jessica McKellar
52327a0484 Give a more accurate error message on new subs from home view. 
(imported from commit 5521e27ad63717d5a8ba325172726619bc8114cf)
 2012-10-02 17:17:27 -04:00
Jessica McKellar
abb47a6a7d Fix bad class name comparison in add_zephyr_metadata. 
(imported from commit 7e03ba4a4b3b8af5b080a273a0b480743b1b7e90)
 2012-10-02 15:58:17 -04:00
Jessica McKellar
588db5b4c5 Make class names case-insensitive. 
(imported from commit e76e50156ca8dab1f7b3124351997e75ef08e521)
 2012-10-02 15:16:26 -04:00
Jessica McKellar
2f1a3dd39c Don't allow empty class/instance/recipient/message on zephyrs. 
(imported from commit 2f8e6e0d6a2f046208f5d10d495e50d72197f79f)
 2012-10-01 18:14:27 -04:00
Keegan McAllister
ae228a9a70 Remove unused get_all_zephyr_rows 
Arguably incorrect in the multiple-tables world.

(imported from commit 6902972a12c6484e78750d055292510d9637cf42)
 2012-10-01 16:42:00 -04:00
Jessica McKellar
28e668bb46 Handle home view subscriptions error cases. 
(imported from commit 7f31b5c4837c524c3ad5a0538ca1f01ad73141a3)
 2012-10-01 15:36:10 -04:00
Luke Faraone
160744788a Disable hotkeys when preparing a huddle after clicking on a username. 
(imported from commit a27ed2734dc3e8ca1a9a1aba8f672c10a6a6fb92)
 2012-10-01 15:20:25 -04:00
Keegan McAllister
4bd3f009c0 Prepend to zephyr_array if where === 'top' 
(imported from commit f1150f36bedd07275749ca7c8dfd84296ebc9438)
 2012-10-01 15:03:16 -04:00
Keegan McAllister
25eeaabe47 On load, send a range around the pointer, then fill in later, then earlier 
This still doesn't handle collapsing entirely correctly for the backfilled
messages.

(imported from commit d1fa3e2249968208e735454c27b8cab20bb78d3f)
 2012-09-28 19:40:45 -04:00
Keegan McAllister
8d906c9b6f Allow the server to prepend a block of messages 
This doesn't handle collapsing yet.

(imported from commit 85a2284f398dea33cc891297924ff7504304be94)
 2012-09-28 18:37:12 -04:00
Keegan McAllister
1c48599824 Refactor add_messages slightly 
(imported from commit 61ac3285c9a55202f390a3b4473483656449cf44)
 2012-09-28 18:37:12 -04:00
Keegan McAllister
e9f70c1efb Track the first received message 
We don't use this information, yet.

(imported from commit 24a9466823f3e7a287027969d3841c7638954e76)
 2012-09-28 18:37:11 -04:00
Jessica McKellar
1fa3bbead9 Update the class subscriptions upon subscription removal. 
This fixes a bug where if you unsubbed from a class and then tried to
send a message to it, you could without error and wouldn't see the
message.

(imported from commit 7a4da2a6cb5bbecfc236628dda7b61972b3082e1)
 2012-09-28 17:24:45 -04:00
Waseem Daher
8b08cffcbb Faster composebox show and hide. 
(imported from commit 55f0465e9aded7c1b8cfe6e53b25bd1bc1185311)
 2012-09-28 16:17:29 -04:00
Jessica McKellar
1adb10d1ae Allow copying and pasting from zephyrs without triggering a compose. 
(imported from commit f98a14155904dda11d85ed81acee783494377e4d)
 2012-09-28 15:27:39 -04:00
Waseem Daher
ecfed97bc6 Attempt at restyling personals for more emphasis. 
(imported from commit 28adc1c6144632bf973272b096a22d8315648502)
 2012-09-28 13:32:59 -04:00
Jessica McKellar
f2b808a976 Now that mouseover doesn't select, show_email needs to take an ID. 
(imported from commit dfa737e78da0772e99fda34318ed879896fb5655)
 2012-09-28 10:59:39 -04:00
Jessica McKellar
9cbdbc4893 Don't update the selected zephyr on mouseover. 
But do keep the pointer on the screen as you scroll, and smoothly
scroll all the way up to the top or all the way down to the bottom.

(imported from commit 6acad2a16339ee5eeeebd62a853000c21e4b7152)
 2012-09-28 10:59:38 -04:00
Keegan McAllister
3429e77178 Don't display the "Loading..." indicator if the user has no messages 
(imported from commit a050218ccde3b82c570a9373cbab5e3fb22abcde)
 2012-09-27 16:15:10 -04:00
Keegan McAllister
20240d869c Rename get_updates_longpoll to get_updates 
(imported from commit 15635904584b324bdfa1414caea12c3bc4ce54c8)
 2012-09-27 15:46:36 -04:00
Luke Faraone
b58e2ee575 Enable j/k keyboard shortcuts 
(imported from commit 1a172fc6d49506060534ffc52a27160ca0bbca72)
 2012-09-27 12:32:46 -04:00
Keegan McAllister
9323abddd9 Don't jump the pointer if the user already selected a message during load 
(imported from commit 69a3f11059ee4764f1625df7774ff611fff99537)
 2012-09-26 17:53:06 -04:00
Keegan McAllister
35dcc04822 Add an interim "Loading..." indicator 
We will probably re-style this eventually.

Also, the animation freezes during template rendering.  And the HTML is a "give
up and use tables" situation.

(imported from commit 847374b616dc7ce909834f23d5ed9522aa457254)
 2012-09-26 17:11:00 -04:00
Keegan McAllister
1e02fc140b Make add_messages do everything relating to message adding 
Now that it's only called from get_updates_longpoll, we don't need to break out
specific parts that are only needed there.

(imported from commit 60d1cb25d0044ed1b2325d977b869617587e6a0f)
 2012-09-26 17:11:00 -04:00
Keegan McAllister
017c5e87bd Update autocomplete only once per batch 
...not up to three times per message.

(imported from commit 1da13c0bc1311627f1bcdce6719097836d9616ca)
 2012-09-26 17:11:00 -04:00