paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 11:52:01 +00:00
Code Issues Packages Projects Releases Wiki Activity
34,830 Commits 30 Branches 160 Tags
d79a7a8c35bdfbe8dd776f8c0acb6069422d2d7c
Commit Graph

6151 Commits

Author SHA1 Message Date
Anders Kaseorg
4480963f5a dict: Remove each method. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-04 12:22:03 -08:00
Anders Kaseorg
fac2c71776 dict: Replace items method with @@iterator method. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-04 12:22:03 -08:00
Anders Kaseorg
9e1343ff8a dict, lazy_set: Return an iterator from values method. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-04 12:22:03 -08:00
Anders Kaseorg
45d3be5449 dict, lazy_set: Return an iterator from keys method. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-04 12:22:03 -08:00
Anders Kaseorg
61de2e8192 dict: Remove is_empty method. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-04 12:22:03 -08:00
Anders Kaseorg
60fac80c8e dict, lazy_set: Replace num_items method with size property. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-04 12:22:03 -08:00
Anders Kaseorg
da633e953e lazy_set: Convert LazySet to a real class. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-04 12:22:03 -08:00
Anders Kaseorg
fe54e73c77 dict, lazy_set: Rename del method to delete, for consistency with Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-04 12:22:03 -08:00
Anders Kaseorg
0e657756f1 dict: Make set method return value consistent with Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-04 12:22:03 -08:00
Anders Kaseorg
ab61222dd5 dict: Reimplement Dict using Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-04 12:22:02 -08:00
Anders Kaseorg
b16222a38b dict: Remove setdefault method. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-04 12:22:02 -08:00
Anders Kaseorg
8872aca907 dict: Remove clone method. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-04 12:22:02 -08:00
Anders Kaseorg
22555f53ad dict: Remove Dict.from_array. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-04 12:22:02 -08:00
Anders Kaseorg
52765796c2 dict: Remove Dict.from. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-04 12:22:02 -08:00
Anders Kaseorg
5b824702b4 unread: Replace key_to_bucket Map with Dict/FoldDict/IntDict. 
This reverts commit d84646f091 (which
incorrectly assumed in unread_topic_counter that the messages were
present in the message store), while fixing the type confusion problem
by using IntDict for stream_id keys.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-04 12:21:29 -08:00
Anders Kaseorg
252910202b poll_widget: Convert votes from object to Map. 
Fixes implicity stringification of the user ID keys.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-03 15:59:26 -08:00
Anders Kaseorg
85620df34e poll_widget: Convert key_to_option from object to Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-03 15:59:26 -08:00
Anders Kaseorg
849c7f83a0 blueslip_stacktrace: Handle promises in sourceCache. 
Fixes “TypeError: sourceContent.split is not a function” at
blueslip_stacktrace.ts:60 when there’s another error during page load.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-03 15:58:57 -08:00
shubhamgupta2956
aaa30df94c Hotkeys: Change hotkeys behaviour on dropdown open. 
Disables message_view_only hotkeys when dropdown menu is opened.

Fixes: #11990
 2020-02-03 13:45:07 -08:00
shubhamgupta2956
23c5123a55 hotkeys: Change 'q' and 'w' to message_view_only 
Add message_view_only property to 'q' and 'w' hotkeys
 2020-02-03 13:40:48 -08:00
Pragati Agrawal
8e733fb513 settings_org: Extract the function to hide or show the element block. 
This change leads to some de-duplication of repeated code.
 2020-02-03 11:37:40 -08:00
Pragati Agrawal
dd6e616c9b settings_org: De-duplicate code to set value of normal dropdowns. 
In the future, any property which doesn't have any dependent setting can be
added to `simple_dropdown_properties` list, which automates setting the
value of dropdowns on saving.
 2020-02-03 11:37:40 -08:00
Anders Kaseorg
e4259d48a5 dict: Assert that Dict is only used with string keys. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-02 20:37:41 -08:00
Anders Kaseorg
b41968c4a7 topic_list: Replace active_widgets Dict with IntDict. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-02 20:37:41 -08:00
Anders Kaseorg
a7bed2c8a3 stream_list: Replace rows Dict with IntDict. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-02 20:37:41 -08:00
Anders Kaseorg
b5cd8dcedd starred_messages: Replace ids Dict with Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-02 20:37:41 -08:00
Anders Kaseorg
1189747d4c settings_streams: Replace row_dict Dict with IntDict. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-02 20:37:41 -08:00
Anders Kaseorg
90ebaa86e9 settings_sections: Replace is_loaded Dict with loaded_groups Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-02 20:37:41 -08:00
Anders Kaseorg
21b13e656d recent_senders: Replace topic_senders and stream_senders with IntDict. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-02 20:37:41 -08:00
Anders Kaseorg
c4e1357e19 pm_conversations: Replace partners Dict with Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-02 20:37:41 -08:00
Anders Kaseorg
052497de1c muting: Replace muted_topics Dict with IntDict. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-02 20:37:41 -08:00
Anders Kaseorg
e10da9c85f condense: Replace _message_content_height_cache Dict with IntDict. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-02 20:37:41 -08:00
Anders Kaseorg
2f91f583fc unread: Replace buckets with Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-02 20:37:41 -08:00
Anders Kaseorg
5262ff790e unread: Replace unread_message_ids with Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-02 20:37:41 -08:00
Anders Kaseorg
6a0de3bb74 unread: Replace unread_mentions_counter with Set. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-02 20:37:41 -08:00
Anders Kaseorg
a9e28218b2 unread: Replace reverse_lookup Dict with IntDict. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-02 20:37:41 -08:00
Anders Kaseorg
d84646f091 unread: Replace key_to_bucket Dict/FoldDict with Map. 
Fixes type confusion in unread_topic_counter, which uses stream IDs as
keys.

Since unread_topic_counter calls message_store.get now, update the
mocks so that message_store.get knows about our mocked messages.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-02 20:37:41 -08:00
Anders Kaseorg
fd9557aa0c unread: Fix {get_msg_ids,num_unread}_for_person type confusion. 
These methods take a comma-separated string of user IDs; don’t pass a
number.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-02-02 20:37:41 -08:00
Tim Abbott
df6b90db3c settings: Fix copy-from-clipboard behavior for bot tokens. 
We do this by cleaning up the API for generate_zuliprc_content,
allowing us to deduplicate the previously incorrect code.
 2020-01-31 15:11:20 -08:00
Tim Abbott
992b15b86c echo: Support senders other than ourself in display_recipient logic. 
we don't have a current use case for this feature, but it better
matches what we mean and thus makes the function more readable.
 2020-01-31 12:46:19 -08:00
Vishnu KS
d7107f47cd echo: Include sender in display_recipient during PM local insert. 
Previously the sender was not included in display_recipient when
a private message was locally echoed. This broke the copy conversation
link functionality, if the user try to copy the link immedeatly after
sending the message. This issue is present only during local echo.
This was fixed by including the recipient of the user during
local echo.

Fixes #13547.
 2020-01-31 12:45:14 -08:00
Tim Abbott
8ba48d0e4f echo: Add comment explaining zephyr mirroring details. 2020-01-31 12:45:14 -08:00
Tim Abbott
0a6e3b41d3 echo: Simplify return flow in build_display_recipient. 2020-01-31 12:45:14 -08:00
Vishnu Ks
dde5d1cd4d echo: Extract emails_to_display_recipient function. 2020-01-31 12:45:14 -08:00
Vishnu KS
fbd697ee70 tests: Add test for insert_local_message in echo.js. 2020-01-31 12:45:14 -08:00
Vaibhav Raj Singh
1fa46b1963 compose: Improved warning for wildcard mentions. 
Edited the warning to clearly state that most members/most stream members
will be notified on using wildcard mentions, along with the specific
mention (e.g. @ALL, @everyone and @stream).

Did a separate check for all wildcard mentions in util.js and stored the
corresponding mention in wildcard_mention inside compose.js.

Fixes: #13636
 2020-01-31 12:24:35 -08:00
Anders Kaseorg
23a5cf41dc fold_dict: Reimplement FoldDict using Map. 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
 2020-01-31 12:15:55 -08:00
Pragati Agrawal
91a32fecbe settings_org: Use the actual value for private message policy options value. 
This change is in series of de-duplication of code in "Other permission"
section for various dropdowns.

Here rather than using "by_anyone" and "disabled" for the `value` attribute
of options, we use actual numeric values. As a result, we don't need to
manually handle to extract the data to be sent to the backend on saving.
 2020-01-31 12:42:26 +05:30
Pragati Agrawal
97e24e6e8a settings_org: Use actual value for user group edit policy dropdown options. 
This change is in series of de-duplication of code in "Other permission"
section for various dropdowns.

Here rather than using "by_admins_only" and "by_admins_only" for `value`
attribute of options, we use actual numeric values. This helps in
de-duplicating lot of code which is vulnerable to bugs.
 2020-01-31 12:42:26 +05:30
Pragati Agrawal
ffc8042b59 settings_org: Use actual value for value attribute of invite stream policy. 
This change is in series of de-duplication of code in "Other permission"
section for various dropdowns.
 2020-01-31 12:42:26 +05:30