paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 15:33:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,997 Commits 30 Branches 160 Tags
dbb0241568ba2e9ddfbc96e41dbfc739a01d193a
Commit Graph

677 Commits

Author SHA1 Message Date
Keegan McAllister
6e63ac926e Add rows.get_table() 
This checks against the table name whitelist before building the jQuery query.

(imported from commit b296f117cdd2707aeb626328f8b0f9e00c723d59)
 2012-10-26 21:03:52 -04:00
Keegan McAllister
138721ebbb ui.js: Wrap an extremely long line 
(imported from commit e8bef501249cc11655780ab87c425c91e2ad4db5)
 2012-10-26 20:41:08 -04:00
Keegan McAllister
19d4631e6f search.js: Call .each on the jQuery match rather than $ itself 
(imported from commit cff239b483a8ef1a7997a1430f40a7fda11739b1)
 2012-10-26 20:41:08 -04:00
Keegan McAllister
a0eea37fd4 search.js: Wrap extremely long line 
(imported from commit c5b76e2da4ebb8322b5a69bf0679fa7700bb7bd1)
 2012-10-26 20:41:08 -04:00
Keegan McAllister
58ca5b3e24 Harden rows.get against bad input 
(imported from commit af0283323089f6ed4edb4cb732fe1cc821fb5dd5)
 2012-10-26 20:41:08 -04:00
Keegan McAllister
3ebee51ce0 rows.js: Use full module pattern 
(imported from commit 770741958798317401e918a7b8331cfc2f73bf77)
 2012-10-26 20:41:08 -04:00
Keegan McAllister
6bd2087d89 zephyr.js: Combine get_huddle_recipient{,_names} 
(imported from commit dcb4c32250f4ff3a3cf32d999d6469916b17b06e)
 2012-10-26 20:31:52 -04:00
Keegan McAllister
faa7565a75 Clean up duplicated code in setup.js 
(imported from commit 86566f194497b618dff0be6ea2bc829204d03366)
 2012-10-26 16:08:18 -04:00
Keegan McAllister
80ef222a60 Get the CSRF token from the DOM rather than a cookie 
This simplifies the code, and lets us set the CSRF cookie as HttpOnly, which
adds a little bit of security.

(imported from commit 9d5923a1acf19bd27e6e1d55cf627049526de245)
 2012-10-26 16:08:18 -04:00
Waseem Daher
22e6a8ac1d Revert "Hide additional search buttons when not in use." 
This reverts commit 074011dfe7dfa4d3cb331b32fc6cf465f98d095f.  For
some reason this introduces some buggy behavior, and if anything I
should debug it more locally first.

(imported from commit 182193e6bb466a5668c2bb64e41712a793fa7ca2)
 2012-10-26 15:41:38 -04:00
Waseem Daher
b0406ee1d2 update_floating_recipient_bar: Don't loop infinitely if no message selected. 
(imported from commit a75cfd41ed8a8ce5256d1caa29f6c5bc0689e7d2)
 2012-10-26 15:10:30 -04:00
Waseem Daher
9274437eb5 Hide additional search buttons when not in use. 
(imported from commit 074011dfe7dfa4d3cb331b32fc6cf465f98d095f)
 2012-10-26 14:55:42 -04:00
Waseem Daher
44a6a2b8a4 Have search bar always take on color of main area. 
(imported from commit 85f6db17ca2fd616e4c7b63a98b80332cbddc1c0)
 2012-10-26 14:31:05 -04:00
Jessica McKellar
92593b7cc8 Add basic up/down search functionality, including across narrows. 
(imported from commit c82acad95e97733b87d65287c685caf7533a774e)
 2012-10-26 14:31:05 -04:00
Zev Benjamin
652c524777 Try loading older messages after user is idle 
(imported from commit bb3c39f9b5a9b7befb353647af75001ec168fc8d)
 2012-10-26 13:31:14 -04:00
Zev Benjamin
6ed1d38743 Show persistent pointer on narrow again 
(imported from commit c871ec931ffad4bc692a908e687bb21c6cb2e7e9)
 2012-10-26 11:44:28 -04:00
Zev Benjamin
9c838c44a1 Scroll to the correct message when narrowing 
(imported from commit c6f11f3315f1d168b85f80ab524f322b399f5a85)
 2012-10-26 11:44:28 -04:00
Zev Benjamin
51a39fdb0a Remove unused variable 
(imported from commit 5a2a100aa3d9a577cde2517be3d9bacc2147fa7e)
 2012-10-25 18:11:23 -04:00
Zev Benjamin
1c904e8607 Only start get_updates call after we've gotten all old messages 
(imported from commit 8af46008a3abcdacb59e6223f38742a94a87b125)
 2012-10-25 18:11:23 -04:00
Zev Benjamin
a9583f6889 Fix get_updates missing messages between calls 
(imported from commit 2b84df2a35a9a006b8548904ebf145a351a2e92b)
 2012-10-25 18:11:23 -04:00
Waseem Daher
98d7116ee8 Delete some dead code in signup workflow. 
(imported from commit d07fffd4c0efdaaf4a233c1dbc9d09bc5ec03ad3)
 2012-10-25 16:59:37 -04:00
Zev Benjamin
a798e14d86 Remove more unused code related to get_updates not returning old messages 
(imported from commit d2cc795634c46d8a595ed15c093cfbfc113e6d10)
 2012-10-25 15:48:35 -04:00
Zev Benjamin
47eeae0d36 Restore the "load more messages" button disappearing when there are no more 
(imported from commit 4f46d49c88d9d0dadefe3e770868b6844dc80d64)
 2012-10-25 15:45:14 -04:00
Zev Benjamin
451a041919 Remove the ability to fetch old messages via get_updates 
Clients should use get_old_messages, instead.

(imported from commit 67847ef67d8ad4bf4af3f6082f85f0c76a41944c)
 2012-10-25 15:31:27 -04:00
Keegan McAllister
f8540dcdae Wrap some other extremely long lines 
(imported from commit e7d55f318c8865ca953bf4520d1b07f7e84a4aeb)
 2012-10-25 15:22:18 -04:00
Zev Benjamin
c047502840 Use get_old_messages in client instead of get_updates for loading initial messages 
(imported from commit 169b3720c1fa10606f2351039cac9655bb5165b4)
 2012-10-25 12:10:44 -04:00
Waseem Daher
22a32c09c4 Add a shortcut to pull up the shortcuts dialog. 
(imported from commit 0d6d3ba78a06f0eb1ecba8e6a571b79709980cef)
 2012-10-24 18:31:44 -04:00
Keegan McAllister
f3f9fb545d Narrow by recipient when the user presses 'S' on a huddle 
(imported from commit 7e7c3d27b0824a60f7e8379c282ec05704d842f6)
 2012-10-23 23:04:42 -04:00
Keegan McAllister
899e6d1042 Resize the compose box on show 
It doesn't work to do this immediately after we clear the contents, for some
reason.

(imported from commit b24e2464afc7a4703d4a679ab0b51ac150f1ce89)
 2012-10-23 22:08:47 -04:00
Keegan McAllister
af065005fc Automatically resize the compose box 
(imported from commit 7e9cb632bdca47fee6ad0897a55d1d3c004c34b3)
 2012-10-23 22:08:44 -04:00
Keegan McAllister
eaecaab7f4 Rename narrow.all_personals -> all_huddles 
(imported from commit 6258ddd1548b6ee8cf20c28c9b18e229ebf4e720)
 2012-10-23 20:43:23 -04:00
Keegan McAllister
f0bebe1cc0 Change 'p' hotkey to 'h', for 'huddles' 
(imported from commit 3415f1d3f679be41cb5b92827036b09829a99734)
 2012-10-23 20:41:54 -04:00
Waseem Daher
8ce8a083bb Slightly hackish way of stripping out   in narrowbar tooltips. 
(imported from commit 414738408cd1e4e53f0268b0851c903c6a1a9eda)
 2012-10-23 20:30:58 -04:00
Waseem Daher
feff1d811d Allow icons in narrowbar without putting their HTML in the title text. 
Before this commit, a hover read "<i class='icon-whatever'></i> All huddles with..."

(imported from commit e5a20678b87355d6709ec3b8776469114c92b2f6)
 2012-10-23 20:21:51 -04:00
Keegan McAllister
718018bbf6 select_message_by_id: Fix return value when already selected 
(imported from commit c86509f6cf040d6acb771764d7fe2b40afa72fe3)
 2012-10-23 19:34:54 -04:00
Tim Abbott
bcfe06c69c Don't show floating recipient bar when narrowed to huddle/subject. 
(imported from commit b7cbd83035292ed447a3da666df9326d75aac35e)
 2012-10-23 18:29:54 -04:00
Keegan McAllister
afdd3af1b6 Handle having no selected message more gracefully 
(imported from commit ba00c012061b35dfe490bf1312b3fa78a4f6582f)
 2012-10-23 17:03:31 -04:00
Keegan McAllister
0744332658 select_message: Reliably return success or failure 
(imported from commit 5e6b4066bd53a9b958ec0e752550feb423e52de5)
 2012-10-23 17:03:31 -04:00
Zev Benjamin
d4c2fd6cb6 Don't update the pointer on the server when the client receives messages 
(imported from commit 54a0d10e94d2f4d39a29d4c8596bf4712c1eb45b)
 2012-10-23 16:39:05 -04:00
Zev Benjamin
6c4b56517f Revert "Temporarily disable pointer sync" 
This reverts commit 7d8f673559ca6359923aa0bdd48edebe0955e921.

(imported from commit 32f7ad925cc4df72220a191602487620a9970f43)
 2012-10-23 16:39:04 -04:00
Keegan McAllister
e7746e97e8 select_message: Fall back to the last, not first, message 
This seems more likely to be what people want when e.g. viewing all huddles.
Later we can get more clever and select the nearest huddle, or something.

(imported from commit 8ec1aa02c050dd25eb868b1e317d114743525c7b)
 2012-10-23 16:31:05 -04:00
Keegan McAllister
37ac9d2a91 select_message: Misc cleanup 
We can safely call .is(':hidden') on an empty jQuery result and get false.

(imported from commit a73932f63b8fec7c43d8603fca95adcd4f164317)
 2012-10-23 16:28:40 -04:00
Keegan McAllister
d34bebc584 select_message: Properly fall back to the first visible message 
Our old selector here was picking up the floating recipient label, or
something.  This was breaking narrow-to-all-huddles when on a stream message --
you get no selection and the code is sad.

(imported from commit d25fab03bd6d745df6d787c0b1b6452c8c539e32)
 2012-10-23 16:28:40 -04:00
Keegan McAllister
b049749cb2 New hotkeys for narrowing 
- s for stream or huddle
  - S for subject
  - p for all personals (still buggy)

We've eliminated the 'g' prefix entirely.  And the old 'g-a' un-narrow sequence
has no new equivalent, but you can still use Esc.

(imported from commit 6bdaacce9639e3f749418e06622a317937e7d014)
 2012-10-23 15:28:07 -04:00
Zev Benjamin
ce3ea9f019 Temporarily disable pointer sync 
(imported from commit 74e6bb347e0b8c01b6450914a50448b78b9749c9)
 2012-10-23 15:24:00 -04:00
Keegan McAllister
86159813df Hide the "Load older messages" button in narrowed view 
Ideally this would be part of hiding zhome, but right now zhome/zfilt are
assumed to the tables themselves, and changing that seems unfortunately
invasive.  And it's not crazy to think of the "loading controls" as a logically
separate thing that we might show/hide independently.

Longer term, we may want an indication in narrowed view that there could be
more messages on the server.

(imported from commit eb72d720da7c03f6f1378ae18ab6e973bf98247f)
 2012-10-23 13:28:08 -04:00
Zev Benjamin
fca4cade34 Ignore long-poll successes with no data 
The server will occationally return successfully with no data during
a restart.  Previously, when we would get such responses, the page
would stop working because of JS errors.

(imported from commit 39b89907dc5ae9a9eb54ebf60d0069281e401786)
 2012-10-23 12:03:56 -04:00
Tim Abbott
9779ca9e5c Shorten get_updates timeout to under a minute. 
(imported from commit fcc87011051c25051861e3c36e442398cd3ca3c0)
 2012-10-23 11:31:32 -04:00
Zev Benjamin
ed05e28e55 Update server when selected message changes via scrolling 
(imported from commit a763baf064e73d358632f3754aba940d188f733d)
 2012-10-23 10:30:59 -04:00
Zev Benjamin
899d5c776f Check reason_empty on client when there are no new messages 
This fixes a problem where the client would never stop asking for old
messages (bug introduced during rebase)

(imported from commit eef9f19e1e9982b1e0a954eb36a81e1b7ee5b564)
 2012-10-22 18:19:14 -04:00