Cory Lynch
b13265d135
util: Remove execute_early.
...
This function was removed in favor of loading everything in
ui_init.js. The asynchronous nature of jQuery 3 document-ready
events may cause an undesirable order in which these are executed.
2017-07-04 13:54:33 -07:00
Cory Lynch
e33b178054
message_store: Move initialization to ui_init.js.
2017-07-04 13:54:33 -07:00
Harshit Bansal
d3d6712fa3
left-sidebar: Update the size of the scrollbar after narrowing to a stream.
2017-07-03 09:53:41 -07:00
vaibhav
3cddc4ac93
settings: Add node test for url input box toggle.
...
This contains node test for toggling the url inputbox of
outgoing webhooks service url in the "Add new bot" form.
2017-07-03 11:09:40 -04:00
Cory Lynch
30c7629212
Change code block typeahead to only sometimes close fence.
...
Fixes #5556 .
Some tests needed to be moved around to make sure the
stubbing wouldn't break future tests.
2017-07-03 11:05:18 -04:00
Harshit Bansal
4cb8ac100a
emoji: Fix the title and alt text for unicode emojis.
...
Unicode emojis when rendered should display canonical short name.
Similarly, the alt text should be of the format `:<short_name>:`.
For both of these we currently display the actual unicode symbol.
As some systems don't have the fonts necessary for displaying them
properly, they are rendered as empty square blocks. This commit also
ensures that the markup generated for emoji generated by canonical
name and by an unicode emoji is same.
Fixes : #5555 .
2017-07-01 11:14:24 -07:00
Cory Lynch
8abbb6d781
search: Remove in:all token from suggestions.
2017-07-01 12:19:52 -04:00
Steve Howell
3fe6d12ab6
node tests: Test server_events_dispatch.js directly.
...
The dispatch.js tests now no longer go through server_events.js,
so the tests are isolated from some of the setup you have to
do for the main event loop. They now directly call into
server_events_dispatch.js.
2017-07-01 08:50:50 -04:00
Aditya Bansal
74f40a0a58
compose.js: Add node test coverage for report_as_received() function.
2017-06-30 19:57:15 +05:30
Aditya Bansal
4b3c2931ea
compose.js: Add test coverage for mark_rendered_content_disparity().
2017-06-30 19:57:15 +05:30
Aditya Bansal
7e585acfa5
compose.js: Add coverage for send_message_success() function.
2017-06-30 19:57:15 +05:30
Aditya Bansal
7f4781e17d
compose.js: Add test coverage for update_email().
2017-06-30 19:57:15 +05:30
Aditya Bansal
3d043d0109
compose.js: Add coverage for get_invalid_recipient_emails().
2017-06-30 19:57:15 +05:30
Aditya Bansal
9437895c9e
compose.js: Add coverage for validate_stream_message() function.
2017-06-30 19:57:15 +05:30
Steve Howell
6cf4c65d92
node tests: Add 100% coverage for channel.js.
2017-06-30 09:48:04 -04:00
Steve Howell
0b60538570
node tests: Extract test_get_reaction_section().
2017-06-30 08:05:10 -04:00
Aditya Bansal
1e18863a98
timerender.js: Use stubbed version of i18n from zjsunit.
2017-06-29 15:18:08 -04:00
Aditya Bansal
5eb5b33f21
settings_org.js: Use stubbed version of i18n from zjsunit.
2017-06-29 15:18:08 -04:00
Aditya Bansal
a103949c2b
i18n.js: Fix issue of i18n stub not returning 'translated: ' prefix.
2017-06-29 15:18:08 -04:00
Aditya Bansal
4d84be16ca
i18n.js: Fix issue with i18n being cleaned up in namespace cleanup.
2017-06-29 15:18:08 -04:00
Aditya Bansal
7531a85c4d
stream_data: Add get_subscriber_count() function.
2017-06-29 10:34:47 -04:00
Aditya Bansal
cc34e3d382
compose.js: Add coverage for validate_stream_message_address_info().
2017-06-29 18:02:25 +05:30
Umair Khan
12b124ba71
single_message.handlerbars: Use __starred_status__ in tooltip.
...
We do not allow handlerbars within tranlation tags. To use variables in
translatable strings, enclose variables with double lowdashes.
2017-06-29 07:39:20 -04:00
Steve Howell
aae3250155
node tests: Add test_with_view_stubs() for reactions.js.
2017-06-29 07:19:52 -04:00
Steve Howell
791e489938
Use a proper context in insert_new_reaction().
...
Before this change, we were piggybacking fields on to the event
object, which coupled us to any other function that relies on
the event.
2017-06-29 07:19:52 -04:00
Aditya Bansal
92b43c7965
compose.js: Add test for validate_stream_message_address_info().
...
In this commit we add only one test for the case of unsubscribed
streams in validate_stream_message_address_info() function."
2017-06-28 07:45:21 -04:00
Aditya Bansal
6c787ac569
compose.js: Add test for validate_stream_message_address_info().
...
In this commit we only add a single test for the case of subscribed
stream to validate_stream_message_address_info() function.
2017-06-28 07:45:21 -04:00
Aditya Bansal
63401833b4
compose.js: Add node test coverage for validate function.
2017-06-28 07:45:21 -04:00
Aditya Bansal
232966a948
activity.js: Remove unnecessary override of i18n as global var.
2017-06-28 07:34:04 -04:00
Joshua Pan
ac64ee355d
compose_actions.js: Allow compose to empty narrow.
...
This allows r/enter hotkeys to compose to
an empty narrow (no messages).
Fixes #4500 .
2017-06-27 14:06:59 -04:00
Joshua Pan
c4914eeec9
narrow.js: Create narrowed_by_stream_reply().
...
This function returns if you are narrowed
to a stream.
2017-06-27 14:06:59 -04:00
Yago González
00a7f89ba9
node tests: Add coverage to composebox_typeahead.js.
2017-06-26 19:33:25 -04:00
Yago González
e76c9f1200
node tests: Add tests to test_begins_typeahead.
2017-06-26 19:33:25 -04:00
Yago González
4fa6aa2268
node tests: Re-sort begins_typeahead tests.
2017-06-26 19:33:25 -04:00
Aditya Bansal
7f2b6f739c
emoji.js: Add test coverage for initialize.
2017-06-26 14:24:20 -04:00
Aditya Bansal
88d9739c45
emoji.js: Add test coverage for build_emoji_upload_widget func.
2017-06-26 14:24:20 -04:00
Aditya Bansal
d1fe75ce3b
node tests: Enforce 100% node coverage in activity.js.
2017-06-26 14:24:20 -04:00
Yago González
a8c7539497
node tests: Make Othello's name match the dev server.
2017-06-26 08:38:21 -04:00
Yago González
f908c2e442
node tests: Store fake users as independent variables.
...
This makes the fake users' objects reachable along the whole test file,
allowing to make assertions that involve user data more easily.
2017-06-26 08:38:21 -04:00
Yago González
add869edcb
node tests: Fix line length.
2017-06-26 08:38:21 -04:00
Aditya Bansal
6b911959d5
pm_lists.js: Reach 100% node test coverage.
2017-06-23 09:40:00 -04:00
Cory Lynch
090d7487cf
search_suggestion: Use person matching function from people.js.
...
Instead of having a custom (duplicate) matching function in
search suggestion, it was refactored to use the function in
people.js. This also gets the diacritic-ignoring feature
of the function in people.js.
Fixes #5315 .
2017-06-23 08:29:20 -04:00
Harshit Bansal
6615f2f2e8
common.js: Migrate common.js module to use IIFE module style.
...
This module was exposing its functions as globals. This PR fixes
it use the IIFE module style that we use in our other modules.
2017-06-22 19:06:32 -04:00
Cory Lynch
df83cee86b
people.js: Ignore diacritics in search bar.
...
Fixes #5315
2017-06-21 19:13:44 -04:00
Yago González
e7bd18ec09
timerender: Make get_full_time produce a ISO 8601 date string.
...
Having get_full_time produce a date string non-compliant with RFC2822 or
ISO 8601 caused problems when showing edition timestamps on a message's
edit history.
Now it returns an ISO 8601 date string (1978-10-31T13:37:42Z).
2017-06-21 16:46:39 -04:00
Cynthia Lin
e832ebdc98
hotkeys: Add collapse/show message hotkey.
...
Fixes #4540
2017-06-21 15:54:09 -04:00
Cynthia Lin
a9afe43735
hotkeys: Add u hotkey for opening message sender profile.
...
Fixes #4873
2017-06-21 10:38:05 -04:00
Joshua Pan
1e4c133430
node tests: Test sort_recipientbox_typeahead() in typeahead_helper.js.
2017-06-21 00:03:05 -04:00
Joshua Pan
b48f8447e2
node tests: Fully cover compare_by_pms() in typeahead_helper.js.
2017-06-21 00:03:05 -04:00
Joshua Pan
1c34a3ae54
node tests: Fully cover sort_streams() in typeahead_helper.js.
2017-06-21 00:03:05 -04:00
