paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-11 01:16:19 +00:00
Code Issues Packages Projects Releases Wiki Activity
15,355 Commits 30 Branches 160 Tags
f105e8270d17fde63c742f7316fa86ceecea1be8
Commit Graph

1949 Commits

Author SHA1 Message Date
Steve Howell
06d7012113 Use people.get_all_persons() for search_suggestion.js. 
This is better than using page_params.people_list, which may
go out of sync when live updates happen.
 2016-11-01 13:55:48 -07:00
Steve Howell
2d945d7296 Add people.get_realm_persons(). 2016-11-01 13:55:48 -07:00
Steve Howell
aa07b32d58 Add people.get_all_persons(). 2016-11-01 13:55:48 -07:00
Tim Abbott
1bc9be7aed subs: Fix stream privacy changes not working after renaming. 
This fixes and issue where the change_stream_privacy template had its
own duplicate copy of the data-stream-name attribute, which wasn't
updated when streams were renamed.

Fixes #2016.
 2016-10-28 16:42:32 -07:00
Tim Abbott
6927a9bdc4 subs: Update subscription settings data when renaming streams. 2016-10-28 16:41:54 -07:00
Tim Abbott
0185764be7 subs: Fetch stream name from data-stream-name. 2016-10-28 16:12:50 -07:00
Tim Abbott
9507ed8a05 subs: Move show_settings_for earlier in file. 2016-10-28 16:10:59 -07:00
Tim Abbott
c10fd243f1 subs: Rename subscriber_count class to subscriber-count. 
Also remove the unused subscriber-count-row class.
 2016-10-28 16:07:28 -07:00
Tim Abbott
c0a774ef8c subs: Remove use of $-based variable names. 2016-10-28 16:07:02 -07:00
Tim Abbott
b8304c3359 subs: Find elements using the new data-stream-id value. 
This is preparation for no longer having the subscription inside the
subscription_row object.
 2016-10-28 16:06:40 -07:00
Tim Abbott
3727ea6fb0 subs: rename .subscription_description to .description. 2016-10-28 14:47:23 -07:00
Tim Abbott
dd2fab9374 subs: Rename data-subscription-id to data-stream-id. 2016-10-28 14:47:23 -07:00
Tim Abbott
66e2632809 subs: Rename .subscription_name to .stream-name. 2016-10-28 14:47:22 -07:00
Tim Abbott
f18d53d46a subs: Rename .subscription_row to .stream_row. 
The new name is clearer, since we show these rows for streams whether
or not you're subscribed.
 2016-10-28 14:25:00 -07:00
Steve Howell
eb64b32bc8 Fix "subjects" in JS comments. Say "topics" instead. 2016-10-28 13:52:25 -07:00
Steve Howell
5fd71a6381 Rename var in sidebar_subject_list.handlebars. 
s/subjects/topics/
 2016-10-28 13:52:25 -07:00
Steve Howell
dba3ed3d90 Rename variables in topic_list.build_list(). 
(s/subjects/topics/ in a couple places)
 2016-10-28 13:52:25 -07:00
Steve Howell
78861d4e01 Rename recent_subjects to recent_topics. 2016-10-28 13:52:25 -07:00
Steve Howell
0a4579711d Add stream_data.get_recent_topics(). 
This removes the last remaining references to
stream_data.recent_subjects() outside of stream_data.js.
 2016-10-28 13:52:25 -07:00
Steve Howell
6a54dfc127 Remove recent_subjects from node tests. 
We now use stream_data.populate_stream_topics_for_tests(),
which hides some of the implementation details of initializing
the data structure.
 2016-10-28 13:52:25 -07:00
Steve Howell
8acdf718bc Move process_message_for_recent_topics() to stream_data.js. 2016-10-28 13:52:25 -07:00
Steve Howell
c799ac3126 Extract stream_data.is_active(). 2016-10-28 13:51:21 -07:00
Steve Howell
ecbd77d8a5 Flip conditional in stream_list.add_sidebar_li(). 2016-10-28 13:51:21 -07:00
Steve Howell
15602ee6bb Stop using /json/streams on the client. 
We no longer need to fetch streams from the server when
we render the settings page.

The name populate_and_fill() may not be a great name any
more.
 2016-10-28 13:44:46 -07:00
Steve Howell
10bc093375 Stop using server data to draw "Manage Streams". 
We have all the data we need on the client side.
 2016-10-28 13:44:46 -07:00
Steve Howell
9d4debd1eb Live-update added/removed subscribers. 2016-10-28 13:43:09 -07:00
Tim Abbott
01f0be27a7 subs: Combine another set of settings show handlers. 2016-10-27 22:24:40 -07:00
Tim Abbott
426f2b0405 subs: combine some settings show handlers. 2016-10-27 22:22:28 -07:00
Tim Abbott
3fd94cc58a subs: s/subrow/sub_row/ in variable names. 2016-10-27 22:19:30 -07:00
Tim Abbott
12331e2596 subs: Extract show_subscription_settings. 2016-10-27 22:06:56 -07:00
Tim Abbott
30c654f83f templates: Fix stack traces throwing handlebars errors. 
This fixes the fact that we weren't using `throw` correctly, and also
the "handlerbars" typo.

Fixes #2143.
 2016-10-27 22:06:56 -07:00
Steve Howell
f98e605840 Extract topic_list.set_click_handlers(). 2016-10-27 15:49:25 -07:00
Steve Howell
8ebf48793c minor: Remove copy/pasted comment. 2016-10-27 15:49:25 -07:00
Steve Howell
9de7551f4f Extract topic_list.rebuild(). 
This was pulled from rebuild_recent_topics(), which still
exists to wrap passing in the stream_li parameter.
 2016-10-27 15:49:25 -07:00
Steve Howell
f7e6cfc892 Extract topic_list.build_list(). 
This used to be stream_list._build_subject_list().  The code
didn't change except for one s/subject/topic fix.
 2016-10-27 15:49:25 -07:00
Steve Howell
8783a0e51d Move remove_expanded_topics() to topic_list.js. 2016-10-27 15:49:25 -07:00
Steve Howell
9b6b743a1a Move get_topic_filter_li to topic_list.js. 
This also brought along:
    iterate_to_find (copied, see large comment explaining why)
    activate_topic (extracted from a one-liner)
    set_count (formerly stream_list.set_subject_count)

For get_topic_filter_li, we now pass in stream_li instead of
stream to decouple parent/child responsibilities between the
components.

Also, I made some s/subject/topic/ fixes.
 2016-10-27 15:49:25 -07:00
Steve Howell
4f38cfdc7f Extract topic_list.update_count_in_dom(). 
This creates the new topic_list.js module, and the first
function that we extract is topic_list.update_count_in_dom().

This function needed to be decoupled from some non-topic-list
stuff which was overly complicated.
 2016-10-27 15:49:25 -07:00
Steve Howell
65a2f012d4 Simplify pin/unpin code path. 
I make server_events slimmer by not handling a specific
property when subs.update_subscription_properties() should
do all the dispatching (and mostly did).

And then since update_subscription_properties() has
a "sub" already, I can call directly to stream_list code
and remove a function from subs.js.  Since I lose the
wrapper function in subs.js, I rename the stream_list
function as part of this commit.

The only code that gets slightly heavier here is that
we have two lines in the 'pin_to_top' case instead of one.
 2016-10-25 23:29:15 -07:00
Steve Howell
1a927a424f Avoid passing around full_name parameter in subs.js. 
All of the eventual callers to prepend_subscribers()
and format_member_list_elem() call people.get_by_email()
anyway, so now we do it one place.  The one exception
was using page_params.fullname, which is awkwardly
different than what we call that variable elsewhere
(fullname vs. full_name).
 2016-10-25 18:15:24 -07:00
Steve Howell
51f0f7c7c4 Simplify creating subscriber list. 
We were awkwardly reversing a list to use a one-line
helper method that did exactly the opposite of what
we wanted. :)  Now we just append simply.
 2016-10-25 18:15:24 -07:00
Steve Howell
89b17ec2a4 Extract prepend_subscriber(). 
This is a minor change to avoid some 2-line calls in our
code.  (We're about to introduce a third usage of this.)
 2016-10-25 18:15:24 -07:00
Tim Abbott
14dc98d8b9 server_events: Switch to using REST-style URLs. 
This eliminates our use of /json/get_events; we'll remove that
endpoint in a future commit.
 2016-10-25 18:02:16 -07:00
Brock Whittaker
fd9a3f4609 admin: Remove values from emoji form input on success. 
This removes the values after successfully creating a new realm emoji.
 2016-10-25 17:01:03 -07:00
Tim Abbott
7ebfa25f5a message_edit: Make .save() automatically call .end() if no changes. 
Previously, all of the callers of message_edit.save() would check if
it returned true, and if so, call message_edit.end().  This resulted
in various bugs in the past, so we switch to the much cleaner model of
just calling .end() inside .save().
 2016-10-25 16:34:57 -07:00
Tim Abbott
05a2e57b14 message_edit: Make enter save when editing topics. 
Fixes #1272.
 2016-10-25 16:34:57 -07:00
Tim Abbott
ff575aed99 message_edit: Fix error handling if user has re-narrowed. 2016-10-25 16:34:57 -07:00
Tim Abbott
985b4072c0 message_edit: Show a success message briefly. 2016-10-25 16:34:56 -07:00
Rishi Gupta
d14f276322 topic_edit_form: Rename message_edit_topic to inline_topic_edit. 
message_edit_form.handlebars already has a message_edit_topic that
refers to the topic edit section of message editing, and this made
things very confusing.
 2016-10-25 16:33:20 -07:00
Rishi Gupta
82a0fe0eca actions popover: Change "Topic Edit" to "View Source / Topic Edit". 
Also edit the icon to show "View Source" as the primary feature.
 2016-10-25 15:12:32 -07:00