paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,317 Commits 30 Branches 160 Tags
f6ba728a24dbbb0bec580f4090cbb7cc1d3100db
Commit Graph

1093 Commits

Author SHA1 Message Date
Zev Benjamin
f6ba728a24 Move message rendering into the MessageList 
(imported from commit c1e16b1d2fafe5c079991e7ae96a013e25bc8618)
 2013-03-05 12:48:32 -05:00
Zev Benjamin
95309539bc Move same_{stream_and_subject,recipient,sender} into the util module 
(imported from commit 0d79bc3ae29be16eba59acea8bc5fda2aba1d4de)
 2013-03-05 12:45:12 -05:00
Waseem Daher
e662db9c68 Increase the time we mark you as green or yellow. 
One of Matt Goldstein's comments is that we often make you look
like you're not at your computer, even when you are, just because
you haven't checked Humbug for a while.

While it's important to have this be accurate, right now I think
we err on the side of showing you as not present. So I increased
some of the timeouts in an attempt to fix that.

(imported from commit 9fd8f432e6684ec1b33d1d932f37caa99c627959)
 2013-03-05 11:26:55 -05:00
Tim Abbott
a92f2a5229 Rename 'Narrow to messages containing' to 'Search for'. 
(imported from commit 147164bb96bb4fdb451454956ac56f5d3b2424b6)
 2013-03-05 09:32:59 -05:00
Tim Abbott
ee3662d1da Move 'Narrow to' to text inside narrow.describe(). 
(imported from commit a5ccce0034f4c70b71958b26b60521b779837377)
 2013-03-05 09:32:59 -05:00
Tim Abbott
021052a247 search: Remove unused variable search_active. 
(imported from commit ebb907742fd38f60116fb0fe46fa622abd3b23e0)
 2013-03-04 17:57:21 -05:00
Tim Abbott
d5a185dca8 Add highlighting of search terms in "messages containing" narrows. 
(imported from commit 47fca2f20650c32e976ab01e213463d4fb4ed655)
 2013-03-04 17:57:20 -05:00
Tim Abbott
12bb641e9f Fade new messages that arrive while compose is open. 
This might need to change after we merge zev's message list branch, but
it fixes the bug and performs well and isn't a lot of code.

And it has the nice property that it'll only fade messages within the
neighbors range, so there's no need to update the unfading code to
support this.

(imported from commit c562d7335bc5635c960321e1451e4ba0f4452ee9)
 2013-03-04 17:29:16 -05:00
Waseem Daher
09a0471486 Update tutorial to reflect presence list on the right. 
(imported from commit b3616337b5bcf2b07d7c5ba87f6c0ce185cc5889)
 2013-03-04 16:27:13 -05:00
Waseem Daher
c1269d9e42 End the tutorial if they don't send us a response. 
But lengthen the length of time you're willing to wait for one,
as a consequence.

(imported from commit bbdcf29a8b9d479a08259e5ccabd464e09c18b58)
 2013-03-04 16:27:13 -05:00
Luke Faraone
d88107567a Remove "find in page" functionality. 
This was a source of user confusion and didn't provide that much value.

(imported from commit fbe9405d8bc4cb6661baa7fe7583eab5ed73d886)
 2013-03-04 10:59:41 -05:00
Waseem Daher
3ce48f8a45 Make layout more responsive. 
To be fully responsive, we can basically never specify the width of
our container in a fixed number of pixels; otherwise we'll run into
the situation where there's an inordinate amount of wasted space on
our left and right.

So everything needs to change from, e.g. row to row-fluid,
and that has a whole cascading series of changes that that implies.

(imported from commit 7e2771d916f429548c65c0a00fc4c11397054656)
 2013-03-03 11:04:57 -05:00
Tim Abbott
5502ea9f88 Don't open compose box when clicking on inline images. 
(imported from commit 1603b117a322d31e92a3b6684ce8afe33bac0b7d)
 2013-03-01 14:50:45 -05:00
Leo Franchi
7374fe53f1 Only show the "More messages below" if unread messages are in the home view 
(imported from commit 6b1ded10519305bca935b093a74b59d7ab814c55)
 2013-03-01 14:35:39 -05:00
Keegan McAllister
ac1c111489 Fill in default recipient when composing while narrowed 
Fixes #977.

(imported from commit 1abe26d94d5179a3dd1e970224a36c63bba9ff48)
 2013-03-01 14:10:51 -05:00
Jessica McKellar
bfbdb94ecf reply fading: get the table from current_msg_list. 
(imported from commit 88e504b989a6ee66d162edb424d27765bd5f2ba8)
 2013-03-01 13:29:04 -05:00
Jessica McKellar
c516ce98e9 Calculate neighbors for replying-to messages fades based on window height. 
(imported from commit 522025f16655fc1aa9776f08e991aab05a407ad4)
 2013-03-01 13:29:04 -05:00
Jeff Arnold
06a44077aa Prevent multiple enters from sending duplicate messages 
(imported from commit 872bb9971a6af3e352318665559e00b502dfb880)
 2013-03-01 11:55:01 -05:00
Tim Abbott
cad295b9d9 narrow: Fix incorrect default then_select_id. 
Previously we defaulted to current_msg_list.selected_id, which was
fine if you were narrowing from the home view, but if you navigated to
a narrow with no messages in it and then clicked something in the left
panel or used the search bar, it wouldn't work.

Fixes trac: #870.

(imported from commit 5ee480d8d2b1fb300fccbe75e04135d977a1fc07)
 2013-02-28 17:49:57 -05:00
Tim Abbott
096df2d3da typeahead_helper: Rename render_pm_object and cleanup usage. 
(imported from commit 28bca00802e189daed22dcabba1241ef2625536e)
 2013-02-28 17:49:57 -05:00
Tim Abbott
49af19aa71 Add support for narrowing by a message's sender. 
Fixes #972.

(imported from commit 2514d14c94a071f2b3e6149a2bdaeaa00e0c847f)
 2013-02-28 17:49:57 -05:00
Keegan McAllister
e8dff94bfc Clear the search box on blur if not searching or narrowed 
Fixes #978.

(imported from commit 5aefa1bf369e01e4cb6df15478080a793116628b)
 2013-02-28 12:29:52 -05:00
Keegan McAllister
db58ede658 Move some search UI code from ui.js to search.js 
(imported from commit 4e761636769b320431d34d00bfed6b2ba888fa55)
 2013-02-28 12:29:52 -05:00
Tim Abbott
a689e704ac tutorial: Clarify the initial reply instructions. 
The first change might somewhat address users asking "does it matter
which one I click on?" by not being specific that one should click on
_this message_.

The latter I think addresses a small confusion I've seen where people
try try to hit tab before starting a reply.

(imported from commit 708acdf4d4c80713795b96b1a59d681a88604670)
 2013-02-28 11:37:53 -05:00
Leo Franchi
87d294de49 Prepend messages to all_msg_list when loading old messages 
(imported from commit cbe862b2ac133a365d0da28f3b761868e01eb48f)
 2013-02-28 11:36:41 -05:00
Jessica McKellar
e3e5a0656d Wait until after reset_load_more_status to select a message upon narrow. 
This is the fix for https://trac.humbughq.com/ticket/958 (Narrowing
moves the pointer) proposed by jhurwitz. Currently on master,
narrowing can cause you to end up wildly out of place.

This branch is not a perfect fix -- you do end up with the pointer on
the expected message after the narrow, but that message is centered on
the screen; better would be for that message to not move at all.

(imported from commit b89e4e2c896add20eceb609db46c46dc025fdce2)
 2013-02-28 11:31:58 -05:00
Waseem Daher
6cceda503f Hide the 'Send' button when Enter sends. 
Like Facebook does.

Fixes Trac #1019.

(imported from commit 62bd35026ed532d5cb35be9bef5eecd5f63b34de)
 2013-02-28 00:00:27 -05:00
Waseem Daher
dcba1e3f46 Cause shift-enter to insert a newline, even if enter sends. 
This fixes Trac #1018.

(imported from commit 9f1bc3ef3c86077a8852ba7fd23a184a4eac9e68)
 2013-02-27 23:42:58 -05:00
Jessica McKellar
6a56ed0c94 Add a button on the Settings page to declare Humbug bankruptcy. 
(imported from commit 6ca635e997ada54b816abe3425980102ad8f5d2c)
 2013-02-27 18:16:51 -05:00
Jeff Arnold
fcd033e33e [schema] Save enter_sends on the server in the database. 
(imported from commit 4d82f6aaf5918f155a930253c9cc334dbcc0d97a)
 2013-02-27 17:25:29 -05:00
Jeff Arnold
221d3a6740 Introduce an "enter sends" checkbox that defaults to off 
(imported from commit abd0f260acac9fa92c651dc677e636781d75e6fd)
 2013-02-27 17:19:08 -05:00
Jessica McKellar
4e193377dd Fade out messages surrounding a reply message, to make mixing harder. 
(imported from commit da150ad2f0877d058e1a60deb7a7632e52bd3533)
 2013-02-27 15:02:47 -05:00
Waseem Daher
801723b45c Recenter your message in view after you unnarrow. 
In Safari only, if you narrow to something and scroll all the way back
up to the top and then unnarrow, your position actually remains all
the way at the top!

We explicitly call a "scroll_to_selected" as the final step of
deactivating a narrow, which brings this message into view.

This doesn't seem to be an issue on Chrome and Firefox, but I'm not
quite sure why; something about the sequence of events.

(imported from commit fc73640351be03c02eb2f3c8a23de3327723f002)
 2013-02-27 09:14:54 -05:00
Waseem Daher
d3ebe22a58 Allow Safari desktop notifications. 
Apparently the Safari version of requestPermission wants to take
a callback function as an argument and gets unhappy when you
don't give it to them.

I learned this tip from http://www.inserthtml.com/2012/07/html5-app/

But more importantly, from the draft spec at
http://dev.chromium.org/developers/design-documents/desktop-notifications/api-specification
mentions that requestPermission takes a callback function that is
invoked once the user accepts.

(imported from commit c1d98239028ffce2e294568c5711315f985160a3)
 2013-02-26 17:51:31 -05:00
Zev Benjamin
e7604e170a Make left sidebar HTML more standards-compliant 
(imported from commit 4cfc7789d4b930ea074596ddf06d16638e91c9a2)
 2013-02-26 17:18:56 -05:00
Leo Franchi
45322a2791 Always add messageds from get_updates to the home and all lists 
(imported from commit d922fa2d80b339ef0f6b76c83d30a7c0fcc29888)
 2013-02-26 15:09:55 -05:00
Reid Barton
d5ac00aa68 Display timestamps as "Today", "Yesterday" 
(imported from commit 7f24d1a86c5ffc9b02d35f43f60ad5cf9143f2e3)
 2013-02-26 15:06:45 -05:00
Reid Barton
318ee5df7d Move timestamp updating to an exported function for testing purposes 
(imported from commit 9d632eb03564899fe2c8ad937d9e2aaac94e1396)
 2013-02-26 15:06:45 -05:00
Reid Barton
593af9daa8 Fix two comments in time rendering 
(imported from commit 056c8eb7f77947ac967a73ace404f9262bf05923)
 2013-02-26 15:06:45 -05:00
Leo Franchi
1300b684e5 Don't let clicking 'Show in home' change the scroll position 
(imported from commit b760abdaa23f9549f15670b14fdaf57c45dc0aeb)
 2013-02-26 14:13:35 -05:00
Leo Franchi
19d107e42b Add a home_msg_list that contains all messages shown in the home view 
By splitting up all_msg_list and home_msg_list, we can properly add/remove
streams from the home view without having to jump through hoops.

(imported from commit 92767197759f7519197dfc58be951b60fa823fbb)
 2013-02-26 14:13:35 -05:00
Keegan McAllister
d4e02f10eb Set the favicon href directly on Webkit browsers 
We still delete and re-create the node on other browsers.

Fixes #960.

(imported from commit 3f0862793042c4a52d18104060ac2fe2ad21b3e6)
 2013-02-25 16:01:29 -05:00
Leo Franchi
64bb48421b Fix jQuery usage and properly show/hide messages table 
(imported from commit b6d82a6e717b23ce88407499dc8edb4d4c609270)
 2013-02-25 10:04:10 -05:00
Jessica McKellar
11a01dac6c When a narrow would have no messages and just be grey, show a notice instead. 
(imported from commit 2b2b653805cb1ebdb545f83b20c01f1d6cbde9b7)
 2013-02-23 14:38:25 -05:00
Jessica McKellar
cf72ca441f Add the feedback bot to the people autocomplete list. 
(imported from commit d32724ca647da5053677dbb7bc720465823d79f1)
 2013-02-23 14:38:21 -05:00
Jessica McKellar
c1d4bc58e8 Un-break get_updates when you have no messages. 
(imported from commit 5221682c8dacdb8d57b4f65749a28f39f2875f3d)
 2013-02-23 12:33:58 -05:00
Leo Franchi
d08b8459ed Only show unread notifications in the title bar if a message is shown in the home view. 
(imported from commit 795a6cb55d480c57e84ea5e17ef3afdc5d62d68b)
 2013-02-22 17:05:36 -05:00
Zev Benjamin
6e4093a0a5 Fix the copy-paste code copying too few or too many messages 
(imported from commit 2e379618b29cd5c8b168e3f4bdbaa278c5247462)
 2013-02-22 15:52:51 -05:00
Zev Benjamin
296d7d89a3 Disallow replying when there are no messages 
(imported from commit b2fb2d9508afcf0470665bd9d42bb50826d838e4)
 2013-02-22 13:07:26 -05:00
Zev Benjamin
06d69f10d9 Remove superfluous call to MessageList.closest_id 
(imported from commit 11d4f096517df4b9ed89f184a1d383c8a55697bc)
 2013-02-22 11:46:05 -05:00