docs: Request showing touches/clicks in screencast videos.

CLDR 46 added this alias, which is not accurate; remove it.

docs/contributing/reviewable-prs.md

@@ -172,10 +172,19 @@ review:
   </details>
   ```
 
-- Screencasts are difficult to review, so use them only when necessary to
-  demonstrate an interaction. Keep videos as short as possible. If your changes
-  can be seen on a screenshot, be sure to include screenshots in addition to any
-  videos.
+- Screenshots are much easier to review than screencast videos.
+  Wherever possible, use still screenshots instead of videos.
+  Use a video only when necessary to demonstrate an interaction,
+  and include screenshots too for any aspects of your changes
+  which can be seen on a still screenshot.
+
+  Keep any videos as short as possible, so that the reviewer can
+  quickly get to the relevant part.
+
+  In screencast videos, make sure a person watching your video
+  can see where on the screen you're touching or clicking.
+  Use the "show touches" or "include the mouse pointer" feature
+  of your screen-recording software.
 
 - For before and after images or videos of changes, using GithHub's table
   syntax renders them side-by-side for quick and clear comparison.

tools/screenshots/generate-user-messages-screenshot

@@ -246,7 +246,6 @@ group = parser.add_mutually_exclusive_group(required=True)
 group.add_argument(
     "--thread",
     nargs="+",
-    type=str,
     help="Path of the file where the thread for screenshot is present",
 )
 fixture_group = parser.add_argument_group("thread")

tools/semgrep-py.yml

@@ -379,3 +379,15 @@ rules:
       - pattern: urllib.parse.ParseResult
     severity: ERROR
     message: "Use urlsplit rather than urlparse"
+
+  - id: argparse-redundant-str
+    patterns:
+      - pattern: |
+          ....add_argument(..., type=str, ...)
+    message: |
+      The `type=str` argument is redundant in `argparse` because `str` is the default type.
+    fix-regex:
+      regex: ',\s*type=str'
+      replacement: ""
+    languages: [python]
+    severity: ERROR

tools/setup/emoji/custom_emoji_names.py

@@ -1292,9 +1292,11 @@ CUSTOM_EMOJI_NAME_MAPS: dict[str, dict[str, Any]] = {
     "262a": {"canonical_name": "star_and_crescent", "aliases": ["islam"]},
     "1f549": {"canonical_name": "om", "aliases": ["hinduism"]},
     "2638": {"canonical_name": "wheel_of_dharma", "aliases": ["buddhism"]},
-    "2721": {"canonical_name": "star_of_david", "aliases": ["judaism"]},
-    # can't find any explanation of this at all. Is an alternate star of david?
-    # '1f52f': {'canonical_name': 'X', 'aliases': ['six_pointed_star']},
+    "2721": {"canonical_name": "star_of_david", "aliases": ["judaism", "jewish"]},
+    "1f52f": {
+        "canonical_name": "dotted_six_pointed_star",
+        "aliases": ["six_pointed"],
+    },  # Hindu Shatkona, not a Star of David
     "1f54e": {"canonical_name": "menorah", "aliases": []},
     "262f": {"canonical_name": "yin_yang", "aliases": []},
     "2626": {"canonical_name": "orthodox_cross", "aliases": []},

tools/setup/emoji/emoji_names.py

@@ -1119,7 +1119,7 @@ EMOJI_NAME_MAPS: dict[str, dict[str, Any]] = {
     "1f52c": {"canonical_name": "science", "aliases": ["microscope"]},
     "1f52d": {"canonical_name": "telescope", "aliases": []},
     "1f52e": {"canonical_name": "crystal_ball", "aliases": ["oracle", "future", "fortune_telling"]},
-    "1f52f": {"canonical_name": "dotted_six_pointed_star", "aliases": ["jewish", "six_pointed"]},
+    "1f52f": {"canonical_name": "dotted_six_pointed_star", "aliases": ["six_pointed"]},
     "1f530": {"canonical_name": "beginner", "aliases": []},
     "1f531": {"canonical_name": "trident", "aliases": []},
     "1f532": {"canonical_name": "white_and_black_square", "aliases": []},
@@ -2191,7 +2191,7 @@ EMOJI_NAME_MAPS: dict[str, dict[str, Any]] = {
     },
     "1fae5": {
         "canonical_name": "dotted_line_face",
-        "aliases": ["depressed", "introvert", "invisible", "line"],
+        "aliases": ["depressed", "dotted", "introvert", "invisible", "line"],
     },
     "1fae6": {
         "canonical_name": "biting_lip",
@@ -2371,7 +2371,7 @@ EMOJI_NAME_MAPS: dict[str, dict[str, Any]] = {
     "2714": {"canonical_name": "check_mark", "aliases": []},
     "2716": {"canonical_name": "multiplication", "aliases": ["multiply"]},
     "271d": {"canonical_name": "cross", "aliases": ["christianity"]},
-    "2721": {"canonical_name": "star_of_david", "aliases": ["judaism"]},
+    "2721": {"canonical_name": "star_of_david", "aliases": ["judaism", "jewish"]},
     "2728": {"canonical_name": "sparkles", "aliases": ["glamour"]},
     "2733": {"canonical_name": "eight_spoked_asterisk", "aliases": []},
     "2734": {"canonical_name": "eight_pointed_star", "aliases": []},

zerver/management/commands/change_auth_backends.py

@@ -17,12 +17,10 @@ class Command(ZulipBaseCommand):
         group = parser.add_mutually_exclusive_group(required=True)
         group.add_argument(
             "--enable",
-            type=str,
             help="Name of the authentication backend to enable",
         )
         group.add_argument(
             "--disable",
-            type=str,
             help="Name of the authentication backend to disable",
         )
         group.add_argument(

zerver/management/commands/email_server.py

@@ -20,13 +20,11 @@ class Command(BaseCommand):
         parser.add_argument(
             "--user",
             help="User to drop privileges to, if started as root.",
-            type=str,
             required=(os.geteuid() == 0),
         )
         parser.add_argument(
             "--group",
             help="Group to drop privileges to, if started as root.",
-            type=str,
             required=(os.geteuid() == 0),
         )
         tls_cert: str | None = None
@@ -44,13 +42,11 @@ class Command(BaseCommand):
         parser.add_argument(
             "--tls-cert",
             help="Path to TLS certificate chain file",
-            type=str,
             default=tls_cert,
         )
         parser.add_argument(
             "--tls-key",
             help="Path to TLS private key file",
-            type=str,
             default=tls_key,
         )
 

zerver/management/commands/runtusd.py

@@ -14,9 +14,7 @@ class Command(BaseCommand):
 
     @override
     def add_arguments(self, parser: CommandParser) -> None:
-        parser.add_argument(
-            "listen", help="[Port, or address:port, to bind HTTP server to]", type=str
-        )
+        parser.add_argument("listen", help="[Port, or address:port, to bind HTTP server to]")
         local_port = 80
         config_file = get_config_file()
         if get_config(config_file, "application_server", "http_only", False):

zilencer/management/commands/manage_push_registration_encryption_keys.py

@@ -29,7 +29,6 @@ Usage:
         )
         parser.add_argument(
             "--remove-key",
-            type=str,
             metavar="PUBLIC_KEY",
             help="Remove the key pair associated with the given public key from the `push_registration_encryption_keys` map.",
         )