mirror of
https://github.com/zulip/zulip.git
synced 2025-10-26 09:34:02 +00:00
27e4f5da92
This extends the /json/typing endpoint to also accept
stream_id and topic. With this change, the requests
sent to /json/typing should have these:
* `to`: a list set to
- recipients for a PM
- stream_id for a stream message
* `topic`, in case of stream message
along with `op`(start or stop).
On receiving a request with stream_id and topic, we send
typing events to clients with stream_typing_notifications set
to True for all users subscribed to that stream.
51 lines
1.9 KiB
Python
51 lines
1.9 KiB
Python
from typing import List, Optional
|
|
|
|
from django.http import HttpRequest, HttpResponse
|
|
from django.utils.translation import gettext as _
|
|
|
|
from zerver.decorator import REQ, has_request_variables
|
|
from zerver.lib.actions import check_send_typing_notification, do_send_stream_typing_notification
|
|
from zerver.lib.response import json_error, json_success
|
|
from zerver.lib.streams import access_stream_by_id, access_stream_for_send_message
|
|
from zerver.lib.validator import check_int, check_list, check_string_in
|
|
from zerver.models import UserProfile
|
|
|
|
VALID_OPERATOR_TYPES = ["start", "stop"]
|
|
VALID_MESSAGE_TYPES = ["private", "stream"]
|
|
|
|
|
|
@has_request_variables
|
|
def send_notification_backend(
|
|
request: HttpRequest,
|
|
user_profile: UserProfile,
|
|
message_type: str = REQ(
|
|
"type", str_validator=check_string_in(VALID_MESSAGE_TYPES), default="private"
|
|
),
|
|
operator: str = REQ("op", str_validator=check_string_in(VALID_OPERATOR_TYPES)),
|
|
notification_to: List[int] = REQ("to", json_validator=check_list(check_int)),
|
|
topic: Optional[str] = REQ("topic", default=None),
|
|
) -> HttpResponse:
|
|
to_length = len(notification_to)
|
|
|
|
if to_length == 0:
|
|
return json_error(_("Empty 'to' list"))
|
|
|
|
if message_type == "stream":
|
|
if to_length > 1:
|
|
return json_error(_("Cannot send to multiple streams"))
|
|
|
|
if topic is None:
|
|
return json_error(_("Missing topic"))
|
|
|
|
stream_id = notification_to[0]
|
|
# Verify that the user has access to the stream and has
|
|
# permission to send messages to it.
|
|
stream = access_stream_by_id(user_profile, stream_id)[0]
|
|
access_stream_for_send_message(user_profile, stream, forwarder_user_profile=None)
|
|
do_send_stream_typing_notification(user_profile, operator, stream, topic)
|
|
else:
|
|
user_ids = notification_to
|
|
check_send_typing_notification(user_profile, user_ids, operator)
|
|
|
|
return json_success()
|