mirror of
https://github.com/zulip/zulip.git
synced 2025-11-05 06:23:38 +00:00
We explicitly bind `this` to MessageState class which otherwise was defaulting to `window`. This resulted in variables like `this.received` and `this.local_id` being incorrectly interpreted by called function as `window.(received | local_id)` which are `undefined`. Hence, frontend thinks that the message was never received. It was noticed since this was the common log message when a double message send bug was observed. This change in no was indicates fixing of the double send bug, but is hopefully one step forward in that direction.
173 lines
3.9 KiB
JavaScript
173 lines
3.9 KiB
JavaScript
"use strict";
|
|
|
|
exports.messages = new Map();
|
|
|
|
exports.reset_id_state = function () {
|
|
exports.next_local_id = 0;
|
|
};
|
|
|
|
exports.get_new_local_id = function () {
|
|
exports.next_local_id += 1;
|
|
const local_id = exports.next_local_id;
|
|
return "loc-" + local_id.toString();
|
|
};
|
|
|
|
function report_send_time(send_time, receive_time, locally_echoed, rendered_changed) {
|
|
const data = {
|
|
time: send_time.toString(),
|
|
received: receive_time.toString(),
|
|
locally_echoed,
|
|
};
|
|
|
|
if (locally_echoed) {
|
|
data.rendered_content_disparity = rendered_changed;
|
|
}
|
|
|
|
channel.post({
|
|
url: "/json/report/send_times",
|
|
data,
|
|
});
|
|
}
|
|
|
|
exports.start_tracking_message = function (opts) {
|
|
const local_id = opts.local_id;
|
|
|
|
if (!opts.local_id) {
|
|
blueslip.error("You must supply a local_id");
|
|
return;
|
|
}
|
|
|
|
if (exports.messages.has(local_id)) {
|
|
blueslip.error("We are re-using a local_id");
|
|
return;
|
|
}
|
|
|
|
const state = new exports.MessageState(opts);
|
|
|
|
exports.messages.set(local_id, state);
|
|
};
|
|
|
|
class MessageState {
|
|
start = new Date();
|
|
|
|
received = undefined;
|
|
send_finished = undefined;
|
|
rendered_content_disparity = false;
|
|
|
|
constructor(opts) {
|
|
this.local_id = opts.local_id;
|
|
this.locally_echoed = opts.locally_echoed;
|
|
}
|
|
|
|
start_resend() {
|
|
this.start = new Date();
|
|
this.received = undefined;
|
|
this.send_finished = undefined;
|
|
this.rendered_content_disparity = false;
|
|
}
|
|
|
|
maybe_restart_event_loop() {
|
|
if (this.received) {
|
|
// We got our event, no need to do anything
|
|
return;
|
|
}
|
|
|
|
blueslip.log(
|
|
`Restarting get_events due to delayed receipt of sent message ${this.local_id}`,
|
|
);
|
|
|
|
server_events.restart_get_events();
|
|
}
|
|
|
|
maybe_report_send_times() {
|
|
if (!this.ready()) {
|
|
return;
|
|
}
|
|
report_send_time(
|
|
this.send_finished - this.start,
|
|
this.received - this.start,
|
|
this.locally_echoed,
|
|
this.rendered_content_disparity,
|
|
);
|
|
}
|
|
|
|
report_event_received() {
|
|
this.received = new Date();
|
|
this.maybe_report_send_times();
|
|
}
|
|
|
|
mark_disparity() {
|
|
this.rendered_content_disparity = true;
|
|
}
|
|
|
|
report_server_ack() {
|
|
this.send_finished = new Date();
|
|
this.maybe_report_send_times();
|
|
|
|
// We only start our timer for events coming in here,
|
|
// since it's plausible the server rejected our message,
|
|
// or took a while to process it, but there is nothing
|
|
// wrong with our event loop.
|
|
|
|
if (!this.received) {
|
|
setTimeout(this.maybe_restart_event_loop.bind(this), 5000);
|
|
}
|
|
}
|
|
|
|
ready() {
|
|
return this.send_finished !== undefined && this.received !== undefined;
|
|
}
|
|
}
|
|
exports.MessageState = MessageState;
|
|
|
|
exports.get_message_state = function (local_id) {
|
|
const state = exports.messages.get(local_id);
|
|
|
|
if (!state) {
|
|
blueslip.warn("Unknown local_id: " + local_id);
|
|
}
|
|
|
|
return state;
|
|
};
|
|
|
|
exports.mark_disparity = function (local_id) {
|
|
const state = exports.get_message_state(local_id);
|
|
if (!state) {
|
|
return;
|
|
}
|
|
state.mark_disparity();
|
|
};
|
|
|
|
exports.report_event_received = function (local_id) {
|
|
const state = exports.get_message_state(local_id);
|
|
if (!state) {
|
|
return;
|
|
}
|
|
|
|
state.report_event_received();
|
|
};
|
|
|
|
exports.start_resend = function (local_id) {
|
|
const state = exports.get_message_state(local_id);
|
|
if (!state) {
|
|
return;
|
|
}
|
|
|
|
state.start_resend();
|
|
};
|
|
|
|
exports.report_server_ack = function (local_id) {
|
|
const state = exports.get_message_state(local_id);
|
|
if (!state) {
|
|
return;
|
|
}
|
|
|
|
state.report_server_ack();
|
|
};
|
|
|
|
exports.initialize = function () {
|
|
exports.reset_id_state();
|
|
};
|
|
|
|
window.sent_messages = exports;
|