mirror of
https://github.com/zulip/zulip.git
synced 2025-11-03 13:33:24 +00:00
02511bff1c
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
131 lines
4.8 KiB
JavaScript
131 lines
4.8 KiB
JavaScript
set_global('$', global.make_zjquery());
|
|
set_global('page_params', {
|
|
emojiset: 'google',
|
|
realm_emoji: {},
|
|
});
|
|
set_global('upload_widget', {});
|
|
set_global('blueslip', global.make_zblueslip());
|
|
|
|
set_global('emoji_codes', zrequire('emoji_codes', 'generated/emoji/emoji_codes'));
|
|
zrequire('emoji');
|
|
zrequire('markdown');
|
|
zrequire('util');
|
|
|
|
run_test('build_emoji_upload_widget', () => {
|
|
let build_widget_stub = false;
|
|
upload_widget.build_widget = function (
|
|
get_file_input,
|
|
file_name_field,
|
|
input_error,
|
|
clear_button,
|
|
upload_button
|
|
) {
|
|
assert.deepEqual(get_file_input(), $('#emoji_file_input'));
|
|
assert.deepEqual(file_name_field, $('#emoji-file-name'));
|
|
assert.deepEqual(input_error, $('#emoji_file_input_error'));
|
|
assert.deepEqual(clear_button, $('#emoji_image_clear_button'));
|
|
assert.deepEqual(upload_button, $('#emoji_upload_button'));
|
|
build_widget_stub = true;
|
|
};
|
|
emoji.build_emoji_upload_widget();
|
|
assert(build_widget_stub);
|
|
});
|
|
|
|
run_test('initialize', () => {
|
|
let image_stub = false;
|
|
let urls = [];
|
|
let calls = 0;
|
|
class Image {
|
|
set src(data) {
|
|
image_stub = true;
|
|
urls.push(data);
|
|
calls += 1;
|
|
}
|
|
}
|
|
set_global('Image', Image);
|
|
emoji.initialize();
|
|
assert(image_stub);
|
|
assert.equal(calls, 2);
|
|
assert.deepEqual(urls, ['/static/generated/emoji/sheet-google-64.png',
|
|
'/static/generated/emoji/images-google-64/1f419.png']);
|
|
|
|
// Check initialization sequence for `text` emojiset.
|
|
page_params.emojiset = 'text';
|
|
image_stub = false;
|
|
urls = [];
|
|
calls = 0;
|
|
emoji.initialize();
|
|
assert(image_stub);
|
|
assert.equal(calls, 2);
|
|
assert.deepEqual(urls, ['/static/generated/emoji/sheet-google-blob-64.png',
|
|
'/static/generated/emoji/images-google-blob-64/1f419.png']);
|
|
});
|
|
|
|
run_test('get_canonical_name', () => {
|
|
emoji.active_realm_emojis = new Map(Object.entries({
|
|
realm_emoji: 'TBD',
|
|
}));
|
|
let canonical_name = emoji.get_canonical_name('realm_emoji');
|
|
assert.equal(canonical_name, 'realm_emoji');
|
|
|
|
const orig_emoji_codes = global.emoji_codes;
|
|
global.emoji_codes = {
|
|
name_to_codepoint: {
|
|
'+1': '1f44d',
|
|
},
|
|
codepoint_to_name: {
|
|
'1f44d': 'thumbs_up',
|
|
},
|
|
};
|
|
canonical_name = emoji.get_canonical_name('+1');
|
|
assert.equal(canonical_name, 'thumbs_up');
|
|
|
|
emoji.active_realm_emojis = new Map(Object.entries({
|
|
'+1': 'TBD',
|
|
}));
|
|
canonical_name = emoji.get_canonical_name('+1');
|
|
assert.equal(canonical_name, '+1');
|
|
|
|
blueslip.set_test_data('error', 'Invalid emoji name: non_existent');
|
|
emoji.get_canonical_name('non_existent');
|
|
assert.equal(blueslip.get_test_logs('error').length, 1);
|
|
blueslip.clear_test_data();
|
|
global.emoji_codes = orig_emoji_codes;
|
|
});
|
|
|
|
run_test('translate_emoticons_to_names', () => {
|
|
// Simple test
|
|
const test_text = 'Testing :)';
|
|
const expected = 'Testing :slight_smile:';
|
|
const result = emoji.translate_emoticons_to_names(test_text);
|
|
assert.equal(expected, result);
|
|
|
|
// Extensive tests.
|
|
// The following code loops over the test cases and each emoticon conversion
|
|
// to generate multiple test cases.
|
|
const testcases = [
|
|
{name: 'only emoticon', original: '<original>', expected: '<converted>'},
|
|
{name: 'space at start', original: ' <original>', expected: ' <converted>'},
|
|
{name: 'space at end', original: '<original> ', expected: '<converted> '},
|
|
{name: 'symbol at end', original: '<original>!', expected: '<converted>!'},
|
|
{name: 'symbol at start', original: 'Hello,<original>', expected: 'Hello,<converted>'},
|
|
{name: 'after a word', original: 'Hello<original>', expected: 'Hello<original>'},
|
|
{name: 'between words', original: 'Hello<original>World', expected: 'Hello<original>World'},
|
|
{name: 'end of sentence', original: 'End of sentence. <original>', expected: 'End of sentence. <converted>'},
|
|
{name: 'between symbols', original: 'Hello.<original>! World.', expected: 'Hello.<original>! World.'},
|
|
{name: 'before end of sentence', original: 'Hello <original>!', expected: 'Hello <converted>!'},
|
|
];
|
|
for (const [shortcut, full_name] of Object.entries(emoji_codes.emoticon_conversions)) {
|
|
for (const t of testcases) {
|
|
const converted_value = full_name;
|
|
let original = t.original;
|
|
let expected = t.expected;
|
|
original = original.replace(/(<original>)/g, shortcut);
|
|
expected = expected.replace(/(<original>)/g, shortcut)
|
|
.replace(/(<converted>)/g, converted_value);
|
|
const result = emoji.translate_emoticons_to_names(original);
|
|
assert.equal(result, expected);
|
|
}
|
|
}
|
|
});
|