mirror of
https://github.com/zulip/zulip.git
synced 2025-11-05 06:23:38 +00:00
This is intended as a pure refactor, making the data flow clearer in preparation for further changes. In particular, this makes it manifest that the calls to `get_recipient` and `is_valid_conversation` don't depend on anything else that has happened during the call to `handle_text_input`. This is indeed a pure refactor because * is_valid_conversation itself has no side effects, either in the implementation in typing.js or in any reasonable implementation, so calling it sooner doesn't affect anything else; * if we do reach it, the only potentially-side-effecting code it's moving before is a call to `stop_last_notification`, and that in turn (with the existing, or any reasonable, implementation of `notify_server_stop`) has no effect on the data consulted by the implementation of `is_valid_conversation`.
137 lines
4.1 KiB
JavaScript
137 lines
4.1 KiB
JavaScript
import _ from "underscore";
|
|
|
|
// See docs/subsystems/typing-indicators.md for details on typing indicators.
|
|
|
|
// The following constants are tuned to work with
|
|
// TYPING_STARTED_EXPIRY_PERIOD, which is what the other
|
|
// users will use to time out our messages. (Or us,
|
|
// depending on your perspective.) See typing_events.js.
|
|
|
|
// How frequently 'still typing' notifications are sent
|
|
// to extend the expiry
|
|
var TYPING_STARTED_WAIT_PERIOD = 10000; // 10s
|
|
// How long after someone stops editing in the compose box
|
|
// do we send a 'stopped typing' notification
|
|
var TYPING_STOPPED_WAIT_PERIOD = 5000; // 5s
|
|
|
|
/*
|
|
|
|
Our parent should pass in a worker object with the following
|
|
callbacks:
|
|
|
|
notify_server_start
|
|
notify_server_stop
|
|
get_recipient
|
|
get_current_time
|
|
is_valid_conversation
|
|
|
|
See typing.js for the implementations of the above. (Our
|
|
node tests also act as workers and will stub those functions
|
|
appropriately.)
|
|
*/
|
|
|
|
/** Exported only for tests. */
|
|
export const state = {};
|
|
|
|
/** Exported only for tests. */
|
|
export function initialize_state() {
|
|
state.current_recipient = undefined;
|
|
state.next_send_start_time = undefined;
|
|
state.idle_timer = undefined;
|
|
}
|
|
|
|
initialize_state();
|
|
|
|
/** Exported only for tests. */
|
|
export function stop_last_notification(worker) {
|
|
if (state.idle_timer) {
|
|
clearTimeout(state.idle_timer);
|
|
}
|
|
worker.notify_server_stop(state.current_recipient);
|
|
initialize_state();
|
|
}
|
|
|
|
/** Exported only for tests. */
|
|
export function start_or_extend_idle_timer(worker) {
|
|
function on_idle_timeout() {
|
|
// We don't do any real error checking here, because
|
|
// if we've been idle, we need to tell folks, and if
|
|
// our current recipient has changed, previous code will
|
|
// have stopped the timer.
|
|
stop_last_notification(worker);
|
|
}
|
|
|
|
if (state.idle_timer) {
|
|
clearTimeout(state.idle_timer);
|
|
}
|
|
state.idle_timer = setTimeout(
|
|
on_idle_timeout,
|
|
TYPING_STOPPED_WAIT_PERIOD
|
|
);
|
|
}
|
|
|
|
function set_next_start_time(current_time) {
|
|
state.next_send_start_time = current_time + TYPING_STARTED_WAIT_PERIOD;
|
|
}
|
|
|
|
function actually_ping_server(worker, recipient, current_time) {
|
|
worker.notify_server_start(recipient);
|
|
set_next_start_time(current_time);
|
|
}
|
|
|
|
/** Exported only for tests. */
|
|
export function maybe_ping_server(worker, recipient) {
|
|
var current_time = worker.get_current_time();
|
|
if (current_time > state.next_send_start_time) {
|
|
actually_ping_server(worker, recipient, current_time);
|
|
}
|
|
}
|
|
|
|
export function handle_text_input(worker) {
|
|
var new_recipient = worker.get_recipient();
|
|
var conversation_is_valid = worker.is_valid_conversation(new_recipient);
|
|
|
|
var current_recipient = state.current_recipient;
|
|
if (current_recipient) {
|
|
// We need to use _.isEqual for comparisons; === doesn't work
|
|
// on arrays.
|
|
if (_.isEqual(new_recipient, current_recipient)) {
|
|
// Nothing has really changed, except we may need
|
|
// to send a ping to the server.
|
|
maybe_ping_server(worker, new_recipient);
|
|
|
|
// We can also extend out our idle time.
|
|
start_or_extend_idle_timer(worker);
|
|
|
|
return;
|
|
}
|
|
|
|
// We apparently stopped talking to our old recipient,
|
|
// so we must stop the old notification. Don't return
|
|
// yet, because we may have a new recipient.
|
|
stop_last_notification(worker);
|
|
}
|
|
|
|
if (!conversation_is_valid) {
|
|
// If we are not talking to somebody we care about,
|
|
// then there is no more action to take.
|
|
return;
|
|
}
|
|
|
|
// We just started talking to this recipient, so notify
|
|
// the server.
|
|
state.current_recipient = new_recipient;
|
|
var current_time = worker.get_current_time();
|
|
actually_ping_server(worker, new_recipient, current_time);
|
|
start_or_extend_idle_timer(worker);
|
|
}
|
|
|
|
export function stop(worker) {
|
|
// We get this if somebody closes the compose box, but
|
|
// it doesn't necessarily mean we had typing indicators
|
|
// active before this.
|
|
if (state.current_recipient) {
|
|
stop_last_notification(worker);
|
|
}
|
|
}
|