mirror of
https://github.com/zulip/zulip.git
synced 2025-11-03 13:33:24 +00:00
cb6373210b
Some exceptions happening in queue processors were being incorrectly emailed out in the subject line, rather than the body, of the error report.
115 lines
4.3 KiB
Python
115 lines
4.3 KiB
Python
from __future__ import absolute_import
|
|
|
|
from django.conf import settings
|
|
from typing import Any, Dict, Optional
|
|
|
|
import logging
|
|
import traceback
|
|
import platform
|
|
|
|
from django.core import mail
|
|
from django.http import HttpRequest
|
|
from django.utils.log import AdminEmailHandler
|
|
from django.views.debug import ExceptionReporter, get_exception_reporter_filter
|
|
|
|
from zerver.lib.queue import queue_json_publish
|
|
|
|
def add_request_metadata(report, request):
|
|
# type: (Dict[str, Any], HttpRequest) -> None
|
|
report['path'] = request.path
|
|
report['method'] = request.method
|
|
report['remote_addr'] = request.META.get('REMOTE_ADDR', None),
|
|
report['query_string'] = request.META.get('QUERY_STRING', None),
|
|
report['server_name'] = request.META.get('SERVER_NAME', None),
|
|
try:
|
|
from django.contrib.auth.models import AnonymousUser
|
|
user_profile = request.user
|
|
if isinstance(user_profile, AnonymousUser):
|
|
user_full_name = None
|
|
user_email = None
|
|
else:
|
|
user_full_name = user_profile.full_name
|
|
user_email = user_profile.email
|
|
except Exception:
|
|
# Unexpected exceptions here should be handled gracefully
|
|
traceback.print_exc()
|
|
user_full_name = None
|
|
user_email = None
|
|
report['user_email'] = user_email
|
|
report['user_full_name'] = user_full_name
|
|
|
|
exception_filter = get_exception_reporter_filter(request)
|
|
try:
|
|
report['data'] = request.GET if request.method == 'GET' else \
|
|
exception_filter.get_post_parameters(request)
|
|
except Exception:
|
|
# exception_filter.get_post_parameters will throw
|
|
# RequestDataTooBig if there's a really big file uploaded
|
|
report['data'] = {}
|
|
|
|
try:
|
|
report['host'] = request.get_host().split(':')[0]
|
|
except Exception:
|
|
# request.get_host() will throw a DisallowedHost
|
|
# exception if the host is invalid
|
|
report['host'] = platform.node()
|
|
|
|
class AdminZulipHandler(logging.Handler):
|
|
"""An exception log handler that sends the exception to the queue to be
|
|
sent to the Zulip feedback server.
|
|
"""
|
|
|
|
# adapted in part from django/utils/log.py
|
|
|
|
def __init__(self):
|
|
# type: () -> None
|
|
logging.Handler.__init__(self)
|
|
|
|
def emit(self, record):
|
|
# type: (logging.LogRecord) -> None
|
|
try:
|
|
if record.exc_info:
|
|
stack_trace = ''.join(traceback.format_exception(*record.exc_info)) # type: Optional[str]
|
|
message = str(record.exc_info[1])
|
|
else:
|
|
stack_trace = None
|
|
message = record.getMessage()
|
|
if '\n' in message:
|
|
# Some exception code paths in queue processors
|
|
# seem to result in super-long messages
|
|
stack_trace = message
|
|
message = message.split('\n')[0]
|
|
|
|
report = dict(
|
|
node = platform.node(),
|
|
host = platform.node(),
|
|
message = message,
|
|
stack_trace = stack_trace,
|
|
)
|
|
if hasattr(record, "request"):
|
|
add_request_metadata(report, record.request) # type: ignore # record.request is added dynamically
|
|
except Exception:
|
|
traceback.print_exc()
|
|
report = dict(
|
|
node = platform.node(),
|
|
host = platform.node(),
|
|
message = record.getMessage(),
|
|
stack_trace = "See /var/log/zulip/errors.log",
|
|
)
|
|
|
|
try:
|
|
if settings.STAGING_ERROR_NOTIFICATIONS:
|
|
# On staging, process the report directly so it can happen inside this
|
|
# try/except to prevent looping
|
|
from zerver.lib.error_notify import notify_server_error
|
|
notify_server_error(report)
|
|
else:
|
|
queue_json_publish('error_reports', dict(
|
|
type = "server",
|
|
report = report,
|
|
), lambda x: None)
|
|
except Exception:
|
|
# If this breaks, complain loudly but don't pass the traceback up the stream
|
|
# However, we *don't* want to use logging.exception since that could trigger a loop.
|
|
logging.warning("Reporting an exception triggered an exception!", exc_info=True)
|