mirror of
https://github.com/zulip/zulip.git
synced 2025-11-06 15:03:34 +00:00
fde9b1d366
This was added by commit 7f174213ed, and
appears to have been designed for responses that are *successful* but
falsy. Logically, these should not implicitly represent a failure to
be retried if it were.
Note from tabbott: The background is that this idempotent retry loop
was a hacky workaround for a bug we never understood but saw daily in
production. Especially during server restarts / client reloads,
something would result in 200 responses with no data being seen by the
frontend, despite the Django server not having received/processed the
request. Fortunately, this strange failure mode appears to have
stopped happening in late 2019, so we can delete this hack.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
70 lines
2.9 KiB
JavaScript
70 lines
2.9 KiB
JavaScript
import $ from "jquery";
|
|
import SimpleBar from "simplebar";
|
|
|
|
import render_read_receipts from "../templates/read_receipts.hbs";
|
|
import render_read_receipts_modal from "../templates/read_receipts_modal.hbs";
|
|
|
|
import * as channel from "./channel";
|
|
import {$t} from "./i18n";
|
|
import * as loading from "./loading";
|
|
import * as overlays from "./overlays";
|
|
import * as people from "./people";
|
|
import * as popovers from "./popovers";
|
|
import * as ui_report from "./ui_report";
|
|
|
|
export function show_user_list(message_id) {
|
|
$("body").append(render_read_receipts_modal());
|
|
overlays.open_modal("read_receipts_modal", {
|
|
autoremove: true,
|
|
on_show: () => {
|
|
loading.make_indicator($("#read_receipts_modal .loading_indicator"));
|
|
channel.get({
|
|
url: `/json/messages/${message_id}/read_receipts`,
|
|
success(data) {
|
|
const users = data.user_ids.map((id) => {
|
|
const user = people.get_by_user_id(id);
|
|
return {
|
|
user_id: user.user_id,
|
|
full_name: user.full_name,
|
|
avatar_url: people.small_avatar_url_for_person(user),
|
|
};
|
|
});
|
|
users.sort(people.compare_by_name);
|
|
|
|
loading.destroy_indicator($("#read_receipts_modal .loading_indicator"));
|
|
if (users.length === 0) {
|
|
$("#read_receipts_modal .read_receipts_info").text(
|
|
$t({defaultMessage: "No one has read this message yet."}),
|
|
);
|
|
} else {
|
|
$("#read_receipts_modal .read_receipts_info").text(
|
|
$t(
|
|
{
|
|
defaultMessage:
|
|
"This message has been read by {num_of_people} people:",
|
|
},
|
|
{num_of_people: users.length},
|
|
),
|
|
);
|
|
$("#read_receipts_modal .modal__container").addClass(
|
|
"showing_read_receipts_list",
|
|
);
|
|
$("#read_receipts_modal .modal__content").append(
|
|
render_read_receipts({users}),
|
|
);
|
|
new SimpleBar($("#read_receipts_modal .modal__content")[0]);
|
|
}
|
|
},
|
|
error(xhr) {
|
|
ui_report.error("", xhr, $("#read_receipts_error"));
|
|
loading.destroy_indicator($("#read_receipts_modal .loading_indicator"));
|
|
},
|
|
});
|
|
},
|
|
on_hide: () => {
|
|
// Ensure any user info popovers are closed
|
|
popovers.hide_all();
|
|
},
|
|
});
|
|
}
|