mirror of
				https://github.com/zulip/zulip.git
				synced 2025-11-04 05:53:43 +00:00 
			
		
		
		
	I pushed a bunch of commits that attempted to introduce the concept of `client_message_id` into our server, as part of cleaning up our codepaths related to messages you sent (both for the locally echoed case and for the host case). When we deployed this, we had some strange failures involving double-echoed messages and issues advancing the pointer that appeared related to #5779. We didn't get to the bottom of exactly why the PR caused havoc, but I decided there was a cleaner approach, anyway.
		
			
				
	
	
		
			39 lines
		
	
	
		
			941 B
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			39 lines
		
	
	
		
			941 B
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
var message_util = (function () {
 | 
						|
 | 
						|
var exports = {};
 | 
						|
 | 
						|
exports.do_unread_count_updates = function do_unread_count_updates(messages) {
 | 
						|
    unread.process_loaded_messages(messages);
 | 
						|
    unread_ui.update_unread_counts();
 | 
						|
    resize.resize_page_components();
 | 
						|
};
 | 
						|
 | 
						|
exports.add_messages = function add_messages(messages, msg_list, opts) {
 | 
						|
    if (!messages) {
 | 
						|
        return;
 | 
						|
    }
 | 
						|
 | 
						|
    opts = _.extend({messages_are_new: false, delay_render: false}, opts);
 | 
						|
 | 
						|
    loading.destroy_indicator($('#page_loading_indicator'));
 | 
						|
    $('#first_run_message').remove();
 | 
						|
 | 
						|
    msg_list.add_messages(messages, opts);
 | 
						|
 | 
						|
    if (msg_list === home_msg_list && opts.messages_are_new) {
 | 
						|
        _.each(messages, function (message) {
 | 
						|
            if (message.local_id === undefined) {
 | 
						|
                compose.report_as_received(message);
 | 
						|
            }
 | 
						|
        });
 | 
						|
    }
 | 
						|
};
 | 
						|
 | 
						|
 | 
						|
return exports;
 | 
						|
 | 
						|
}());
 | 
						|
if (typeof module !== 'undefined') {
 | 
						|
    module.exports = message_util;
 | 
						|
}
 |