mirror of
https://github.com/zulip/zulip.git
synced 2025-10-30 03:23:50 +00:00
0fc19732bc
We now allow only content edit in message_edit_form which can be opened by pencil icon in the message row, "Edit message" option in popover and by using e hotkey. As a result of this change, we also do not show topic and stream edit options when using "View source" options. We would instead support changing stream and topic from the modal which will be opened from the "Move message" option in message actions popover.
104 lines
3.5 KiB
TypeScript
104 lines
3.5 KiB
TypeScript
import {strict as assert} from "assert";
|
|
|
|
import type {Page} from "puppeteer";
|
|
|
|
import * as common from "../puppeteer_lib/common";
|
|
|
|
async function trigger_edit_last_message(page: Page): Promise<void> {
|
|
const msg = (await page.$$("#zhome .message_row")).at(-1);
|
|
assert.ok(msg !== undefined);
|
|
const id = await (await msg.getProperty("id")).jsonValue();
|
|
await msg.hover();
|
|
const info = await page.waitForSelector(
|
|
`#${CSS.escape(id)} .message_control_button.actions_hover`,
|
|
{visible: true},
|
|
);
|
|
assert.ok(info !== null);
|
|
await info.click();
|
|
await page.waitForSelector(".popover_edit_message", {visible: true});
|
|
await page.click(".popover_edit_message");
|
|
await page.waitForSelector(".message_edit_content", {visible: true});
|
|
}
|
|
|
|
async function edit_stream_message(page: Page, content: string): Promise<void> {
|
|
await trigger_edit_last_message(page);
|
|
|
|
await common.clear_and_type(page, ".message_edit_content", content);
|
|
await page.click(".message_edit_save");
|
|
|
|
await common.wait_for_fully_processed_message(page, content);
|
|
}
|
|
|
|
async function test_stream_message_edit(page: Page): Promise<void> {
|
|
await common.send_message(page, "stream", {
|
|
stream: "Verona",
|
|
topic: "edits",
|
|
content: "test editing",
|
|
});
|
|
|
|
await edit_stream_message(page, "test edited");
|
|
|
|
await common.check_messages_sent(page, "zhome", [["Verona > edits", ["test edited"]]]);
|
|
}
|
|
|
|
async function test_edit_message_with_slash_me(page: Page): Promise<void> {
|
|
const last_message_xpath = `(//*[@id="zhome"]//*[${common.has_class_x("messagebox")}])[last()]`;
|
|
|
|
await common.send_message(page, "stream", {
|
|
stream: "Verona",
|
|
topic: "edits",
|
|
content: "/me test editing a message with me",
|
|
});
|
|
await page.waitForSelector(
|
|
`xpath/${last_message_xpath}//*[${common.has_class_x(
|
|
"status-message",
|
|
)} and text()="test editing a message with me"]`,
|
|
);
|
|
await page.waitForSelector(
|
|
`xpath/${last_message_xpath}//*[${common.has_class_x(
|
|
"sender_name-in-status",
|
|
)} and normalize-space()="Desdemona"]`,
|
|
);
|
|
|
|
await edit_stream_message(page, "/me test edited a message with me");
|
|
|
|
await page.waitForSelector(
|
|
`xpath/${last_message_xpath}//*[${common.has_class_x(
|
|
"status-message",
|
|
)} and text()="test edited a message with me"]`,
|
|
);
|
|
await page.waitForSelector(
|
|
`xpath/${last_message_xpath}//*[${common.has_class_x(
|
|
"sender_name-in-status",
|
|
)} and normalize-space()="Desdemona"]`,
|
|
);
|
|
}
|
|
|
|
async function test_edit_private_message(page: Page): Promise<void> {
|
|
await common.send_message(page, "private", {
|
|
recipient: "cordelia@zulip.com",
|
|
content: "test editing pm",
|
|
});
|
|
await trigger_edit_last_message(page);
|
|
|
|
await common.clear_and_type(page, ".message_edit_content", "test edited pm");
|
|
await page.click(".message_edit_save");
|
|
await common.wait_for_fully_processed_message(page, "test edited pm");
|
|
|
|
await common.check_messages_sent(page, "zhome", [
|
|
["You and Cordelia, Lear's daughter", ["test edited pm"]],
|
|
]);
|
|
}
|
|
|
|
async function edit_tests(page: Page): Promise<void> {
|
|
await common.log_in(page);
|
|
await page.click(".top_left_all_messages");
|
|
await page.waitForSelector("#zhome .message_row", {visible: true});
|
|
|
|
await test_stream_message_edit(page);
|
|
await test_edit_message_with_slash_me(page);
|
|
await test_edit_private_message(page);
|
|
}
|
|
|
|
common.run_test(edit_tests);
|