Files
zulip/static/js/alert_words_ui.js
Anders Kaseorg 719546641f js: Convert a.indexOf(…) !== -1 to a.includes(…).
Babel polyfills this for us for Internet Explorer.

import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import K from "ast-types/gen/kinds";
import fs from "fs";
import path from "path";
import process from "process";

const checkExpression = (node: n.Node): node is K.ExpressionKind =>
  n.Expression.check(node);

for (const file of process.argv.slice(2)) {
  console.log("Parsing", file);
  const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
    parser: path.extname(file) === ".ts" ? tsParser : babelParser,
  });
  let changed = false;

  recast.visit(ast, {
    visitBinaryExpression(path) {
      const { operator, left, right } = path.node;
      if (
        n.CallExpression.check(left) &&
        n.MemberExpression.check(left.callee) &&
        !left.callee.computed &&
        n.Identifier.check(left.callee.property) &&
        left.callee.property.name === "indexOf" &&
        left.arguments.length === 1 &&
        checkExpression(left.arguments[0]) &&
        ((["===", "!==", "==", "!=", ">", "<="].includes(operator) &&
          n.UnaryExpression.check(right) &&
          right.operator == "-" &&
          n.Literal.check(right.argument) &&
          right.argument.value === 1) ||
          ([">=", "<"].includes(operator) &&
            n.Literal.check(right) &&
            right.value === 0))
      ) {
        const test = b.callExpression(
          b.memberExpression(left.callee.object, b.identifier("includes")),
          [left.arguments[0]]
        );
        path.replace(
          ["!==", "!=", ">", ">="].includes(operator)
            ? test
            : b.unaryExpression("!", test)
        );
        changed = true;
      }
      this.traverse(path);
    },
  });

  if (changed) {
    console.log("Writing", file);
    fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
  }
}

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-10 14:08:12 -08:00

111 lines
3.5 KiB
JavaScript

const render_alert_word_settings_item = require('../templates/alert_word_settings_item.hbs');
exports.render_alert_words_ui = function () {
const words = alert_words.words;
const word_list = $('#alert_words_list');
word_list.find('.alert-word-item').remove();
for (const alert_word of words) {
const rendered_alert_word = render_alert_word_settings_item({
word: alert_word,
editing: false,
});
word_list.append(rendered_alert_word);
}
const new_alert_word_form = render_alert_word_settings_item({
word: '',
editing: true,
});
word_list.append(new_alert_word_form);
// Focus new alert word name text box.
$('#create_alert_word_name').focus();
};
function update_alert_word_status(status_text, is_error) {
const alert_word_status = $('#alert_word_status');
if (is_error) {
alert_word_status.removeClass('alert-success').addClass('alert-danger');
} else {
alert_word_status.removeClass('alert-danger').addClass('alert-success');
}
alert_word_status.find('.alert_word_status_text').text(status_text);
alert_word_status.show();
}
function add_alert_word(alert_word) {
alert_word = $.trim(alert_word);
if (alert_word === '') {
update_alert_word_status(i18n.t("Alert word can't be empty!"), true);
return;
} else if (alert_words.words.includes(alert_word)) {
update_alert_word_status(i18n.t("Alert word already exists!"), true);
return;
}
const words_to_be_added = [alert_word];
channel.post({
url: '/json/users/me/alert_words',
data: {alert_words: JSON.stringify(words_to_be_added)},
success: function () {
update_alert_word_status(i18n.t("Alert word added successfully!"), false);
},
error: function () {
update_alert_word_status(i18n.t("Error adding alert word!"), true);
},
});
}
function remove_alert_word(alert_word) {
const words_to_be_removed = [alert_word];
channel.del({
url: '/json/users/me/alert_words',
data: {alert_words: JSON.stringify(words_to_be_removed)},
success: function () {
update_alert_word_status(i18n.t("Alert word removed successfully!"), false);
},
error: function () {
update_alert_word_status(i18n.t("Error removing alert word!"), true);
},
});
}
exports.set_up_alert_words = function () {
// The settings page must be rendered before this function gets called.
exports.render_alert_words_ui();
$('#alert_words_list').on('click', '#create_alert_word_button', function () {
const word = $('#create_alert_word_name').val();
add_alert_word(word);
});
$('#alert_words_list').on('click', '.remove-alert-word', function (event) {
const word = $(event.currentTarget).parents('li').find('.value').text();
remove_alert_word(word);
});
$('#alert_words_list').on('keypress', '#create_alert_word_name', function (event) {
const key = event.which;
// Handle enter (13) as "add".
if (key === 13) {
event.preventDefault();
const word = $(event.target).val();
add_alert_word(word);
}
});
$('#alert-word-settings').on('click', '.close-alert-word-status', function (event) {
event.preventDefault();
const alert = $(event.currentTarget).parents('.alert');
alert.hide();
});
};
window.alert_words_ui = exports;