mirror of
https://github.com/zulip/zulip.git
synced 2025-11-06 06:53:25 +00:00
02511bff1c
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
145 lines
4.4 KiB
JavaScript
145 lines
4.4 KiB
JavaScript
const render_muted_topic_ui_row = require('../templates/muted_topic_ui_row.hbs');
|
|
const render_topic_muted = require('../templates/topic_muted.hbs');
|
|
|
|
function timestamp_ms() {
|
|
return new Date().getTime();
|
|
}
|
|
|
|
let last_topic_update = 0;
|
|
|
|
exports.rerender = function () {
|
|
// Note: We tend to optimistically rerender muting preferences before
|
|
// the back end actually acknowledges the mute. This gives a more
|
|
// immediate feel to the user, and if the back end fails temporarily,
|
|
// re-doing a mute or unmute is a pretty recoverable thing.
|
|
|
|
stream_list.update_streams_sidebar();
|
|
if (current_msg_list.muting_enabled) {
|
|
current_msg_list.update_muting_and_rerender();
|
|
}
|
|
if (current_msg_list !== home_msg_list) {
|
|
home_msg_list.update_muting_and_rerender();
|
|
}
|
|
};
|
|
|
|
exports.persist_mute = function (stream_id, topic_name) {
|
|
const data = {
|
|
stream_id: stream_id,
|
|
topic: topic_name,
|
|
op: 'add',
|
|
};
|
|
last_topic_update = timestamp_ms();
|
|
channel.patch({
|
|
url: '/json/users/me/subscriptions/muted_topics',
|
|
idempotent: true,
|
|
data: data,
|
|
});
|
|
};
|
|
|
|
exports.persist_unmute = function (stream_id, topic_name) {
|
|
const data = {
|
|
stream_id: stream_id,
|
|
topic: topic_name,
|
|
op: 'remove',
|
|
};
|
|
last_topic_update = timestamp_ms();
|
|
channel.patch({
|
|
url: '/json/users/me/subscriptions/muted_topics',
|
|
idempotent: true,
|
|
data: data,
|
|
});
|
|
};
|
|
|
|
exports.handle_updates = function (muted_topics) {
|
|
if (timestamp_ms() < last_topic_update + 1000) {
|
|
// This topic update is either the one that we just rendered, or,
|
|
// much less likely, it's coming from another device and would probably
|
|
// be overwriting this device's preferences with stale data.
|
|
return;
|
|
}
|
|
|
|
exports.update_muted_topics(muted_topics);
|
|
exports.rerender();
|
|
};
|
|
|
|
exports.update_muted_topics = function (muted_topics) {
|
|
muting.set_muted_topics(muted_topics);
|
|
unread_ui.update_unread_counts();
|
|
};
|
|
|
|
exports.set_up_muted_topics_ui = function (muted_topics) {
|
|
const muted_topics_table = $("#muted_topics_table tbody");
|
|
muted_topics_table.empty();
|
|
|
|
for (const tup of muted_topics) {
|
|
const stream_id = tup[0];
|
|
const topic = tup[1];
|
|
|
|
const stream = stream_data.maybe_get_stream_name(stream_id);
|
|
|
|
if (!stream) {
|
|
blueslip.warn('Unknown stream_id in set_up_muted_topics_ui: ' + stream_id);
|
|
continue;
|
|
}
|
|
|
|
const template_data = {
|
|
stream: stream,
|
|
stream_id: stream_id,
|
|
topic: topic,
|
|
};
|
|
|
|
const row = render_muted_topic_ui_row(template_data);
|
|
muted_topics_table.append(row);
|
|
}
|
|
};
|
|
|
|
exports.mute = function (stream_id, topic) {
|
|
const stream_name = stream_data.maybe_get_stream_name(stream_id);
|
|
|
|
stream_popover.hide_topic_popover();
|
|
muting.add_muted_topic(stream_id, topic);
|
|
unread_ui.update_unread_counts();
|
|
exports.rerender();
|
|
exports.persist_mute(stream_id, topic);
|
|
feedback_widget.show({
|
|
populate: function (container) {
|
|
const rendered_html = render_topic_muted();
|
|
container.html(rendered_html);
|
|
container.find(".stream").text(stream_name);
|
|
container.find(".topic").text(topic);
|
|
},
|
|
on_undo: function () {
|
|
exports.unmute(stream_id, topic);
|
|
},
|
|
title_text: i18n.t("Topic muted"),
|
|
undo_button_text: i18n.t("Unmute"),
|
|
});
|
|
exports.set_up_muted_topics_ui(muting.get_muted_topics());
|
|
};
|
|
|
|
exports.unmute = function (stream_id, topic) {
|
|
// we don't run a unmute_notify function because it isn't an issue as much
|
|
// if someone accidentally unmutes a stream rather than if they mute it
|
|
// and miss out on info.
|
|
stream_popover.hide_topic_popover();
|
|
muting.remove_muted_topic(stream_id, topic);
|
|
unread_ui.update_unread_counts();
|
|
exports.rerender();
|
|
exports.persist_unmute(stream_id, topic);
|
|
exports.set_up_muted_topics_ui(muting.get_muted_topics());
|
|
feedback_widget.dismiss();
|
|
};
|
|
|
|
exports.toggle_mute = function (message) {
|
|
const stream_id = message.stream_id;
|
|
const topic = util.get_message_topic(message);
|
|
|
|
if (muting.is_topic_muted(stream_id, topic)) {
|
|
exports.unmute(stream_id, topic);
|
|
} else if (message.type === 'stream') {
|
|
exports.mute(stream_id, topic);
|
|
}
|
|
};
|
|
|
|
window.muting_ui = exports;
|