mirror of
https://github.com/zulip/zulip.git
synced 2025-11-06 06:53:25 +00:00
When we were preparing the conversion to ES modules in 2019, the primary obstacle was that the Node tests extensively relied on the ability to reach into modules and mutate their CommonJS exports in order to mock things. ES module bindings are not mutable, so in commit173c9cee42we added babel-plugin-rewire-ts as a kludgy transpilation-based workaround for this to unblock the conversion. However, babel-plugin-rewire-ts is slow, buggy, nonstandard, confusing, and unmaintained. It’s incompatible with running our ES modules as native ES modules, and prevents us from taking advantage of modern tools for ES modules. So we want to excise all use of __Rewire__ (and the disallow_rewire, override_rewire helper functions that rely on it) from the tests and remove babel-plugin-rewire-ts. Commits64abdc199eande17ba5260a(#20730) prepared for this by letting us see where __Rewire__ is being used. Now we go through and remove most of the uses that are easy to remove without modifying the production code at all. Signed-off-by: Anders Kaseorg <anders@zulip.com>
268 lines
7.1 KiB
JavaScript
268 lines
7.1 KiB
JavaScript
"use strict";
|
|
|
|
const {strict: assert} = require("assert");
|
|
|
|
const {$t} = require("../zjsunit/i18n");
|
|
const {mock_cjs, mock_esm, set_global, zrequire} = require("../zjsunit/namespace");
|
|
const {run_test} = require("../zjsunit/test");
|
|
const $ = require("../zjsunit/zjquery");
|
|
const {page_params} = require("../zjsunit/zpage_params");
|
|
|
|
const noop = function () {};
|
|
|
|
class Clipboard {
|
|
on() {}
|
|
}
|
|
mock_cjs("clipboard", Clipboard);
|
|
|
|
const rows = mock_esm("../../static/js/rows");
|
|
mock_esm("../../static/js/emoji_picker", {
|
|
hide_emoji_popover: noop,
|
|
});
|
|
mock_esm("../../static/js/giphy", {
|
|
hide_giphy_popover: noop,
|
|
});
|
|
const message_lists = mock_esm("../../static/js/message_lists", {
|
|
current: {
|
|
view: {
|
|
message_containers: {},
|
|
},
|
|
},
|
|
});
|
|
mock_esm("../../static/js/message_viewport", {
|
|
height: () => 500,
|
|
});
|
|
mock_esm("../../static/js/stream_popover", {
|
|
hide_stream_popover: noop,
|
|
hide_topic_popover: noop,
|
|
hide_all_messages_popover: noop,
|
|
hide_starred_messages_popover: noop,
|
|
hide_drafts_popover: noop,
|
|
hide_streamlist_sidebar: noop,
|
|
});
|
|
|
|
const people = zrequire("people");
|
|
const user_status = zrequire("user_status");
|
|
const message_edit = zrequire("message_edit");
|
|
const popovers = zrequire("popovers");
|
|
|
|
const alice = {
|
|
email: "alice@example.com",
|
|
full_name: "Alice Smith",
|
|
user_id: 42,
|
|
avatar_version: 5,
|
|
is_guest: false,
|
|
is_admin: false,
|
|
role: 400,
|
|
date_joined: "2021-11-01T16:32:16.458735+00:00",
|
|
};
|
|
|
|
const me = {
|
|
email: "me@example.com",
|
|
user_id: 30,
|
|
full_name: "Me Myself",
|
|
timezone: "America/Los_Angeles",
|
|
};
|
|
|
|
const e = {
|
|
stopPropagation: noop,
|
|
};
|
|
|
|
function initialize_people() {
|
|
people.init();
|
|
people.add_active_user(me);
|
|
people.add_active_user(alice);
|
|
people.initialize_current_user(me.user_id);
|
|
}
|
|
|
|
initialize_people();
|
|
|
|
function make_image_stubber() {
|
|
const images = [];
|
|
|
|
class Image {
|
|
constructor() {
|
|
images.push(this);
|
|
}
|
|
to_$() {
|
|
return {
|
|
on: (name, f) => {
|
|
assert.equal(name, "load");
|
|
this.load_f = f;
|
|
},
|
|
};
|
|
}
|
|
}
|
|
|
|
set_global("Image", Image);
|
|
|
|
return {
|
|
get: (i) => images[i],
|
|
};
|
|
}
|
|
|
|
function test_ui(label, f) {
|
|
run_test(label, (handlers) => {
|
|
page_params.is_admin = false;
|
|
page_params.realm_email_address_visibility = 3;
|
|
page_params.custom_profile_fields = [];
|
|
popovers.clear_for_testing();
|
|
popovers.register_click_handlers();
|
|
f(handlers);
|
|
});
|
|
}
|
|
|
|
test_ui("sender_hover", ({override, mock_template}) => {
|
|
page_params.is_spectator = false;
|
|
override($.fn, "popover", noop);
|
|
|
|
const selection = ".sender_name, .sender_name-in-status, .inline_profile_picture";
|
|
const handler = $("#main_div").get_on_handler("click", selection);
|
|
|
|
const message = {
|
|
id: 999,
|
|
sender_id: alice.user_id,
|
|
};
|
|
|
|
user_status.set_status_text({
|
|
user_id: alice.user_id,
|
|
status_text: "on the beach",
|
|
});
|
|
|
|
const status_emoji_info = {
|
|
emoji_name: "car",
|
|
emoji_code: "1f697",
|
|
reaction_type: "unicode_emoji",
|
|
emoji_alt_code: false,
|
|
};
|
|
user_status.set_status_emoji({user_id: alice.user_id, ...status_emoji_info});
|
|
|
|
rows.id = () => message.id;
|
|
|
|
message_lists.current.get = (msg_id) => {
|
|
assert.equal(msg_id, message.id);
|
|
return message;
|
|
};
|
|
|
|
message_lists.current.select_id = (msg_id) => {
|
|
assert.equal(msg_id, message.id);
|
|
};
|
|
|
|
const $target = $.create("click target");
|
|
|
|
$target.closest = (sel) => {
|
|
assert.equal(sel, ".message_row");
|
|
return {};
|
|
};
|
|
|
|
mock_template("no_arrow_popover.hbs", false, (opts) => {
|
|
assert.deepEqual(opts, {
|
|
class: "message-info-popover",
|
|
});
|
|
return "popover-html";
|
|
});
|
|
|
|
mock_template("user_info_popover_title.hbs", false, (opts) => {
|
|
assert.deepEqual(opts, {
|
|
user_avatar: "http://zulip.zulipdev.com/avatar/42?s=50",
|
|
user_is_guest: false,
|
|
});
|
|
return "title-html";
|
|
});
|
|
|
|
mock_template("user_info_popover_content.hbs", false, (opts) => {
|
|
assert.deepEqual(opts, {
|
|
can_set_away: false,
|
|
can_revoke_away: false,
|
|
can_mute: true,
|
|
can_manage_user: false,
|
|
can_send_private_message: true,
|
|
can_unmute: false,
|
|
user_full_name: "Alice Smith",
|
|
user_email: "alice@example.com",
|
|
user_id: 42,
|
|
user_time: undefined,
|
|
user_type: $t({defaultMessage: "Member"}),
|
|
user_circle_class: "user_circle_empty",
|
|
user_last_seen_time_status:
|
|
"translated: Last active: translated: More than 2 weeks ago",
|
|
pm_with_url: "#narrow/pm-with/42-alice",
|
|
sent_by_uri: "#narrow/sender/42-alice",
|
|
private_message_class: "respond_personal_button",
|
|
show_email: false,
|
|
show_user_profile: true,
|
|
is_me: false,
|
|
is_active: true,
|
|
is_bot: undefined,
|
|
is_sender_popover: true,
|
|
has_message_context: true,
|
|
status_content_available: true,
|
|
status_text: "on the beach",
|
|
status_emoji_info,
|
|
user_mention_syntax: "@**Alice Smith**",
|
|
date_joined: undefined,
|
|
spectator_view: false,
|
|
});
|
|
return "content-html";
|
|
});
|
|
|
|
$.create(".user_popover_email", {children: []});
|
|
const image_stubber = make_image_stubber();
|
|
handler.call($target, e);
|
|
|
|
const avatar_img = image_stubber.get(0);
|
|
assert.equal(avatar_img.src.toString(), "/avatar/42/medium");
|
|
|
|
// todo: load image
|
|
});
|
|
|
|
test_ui("actions_popover", ({override, mock_template}) => {
|
|
override($.fn, "popover", noop);
|
|
|
|
const $target = $.create("click target");
|
|
|
|
const handler = $("#main_div").get_on_handler("click", ".actions_hover");
|
|
|
|
const message = {
|
|
id: 999,
|
|
topic: "Actions (1)",
|
|
type: "stream",
|
|
stream_id: 123,
|
|
sent_by_me: true,
|
|
};
|
|
|
|
message_lists.current.get = (msg_id) => {
|
|
assert.equal(msg_id, message.id);
|
|
return message;
|
|
};
|
|
|
|
message_lists.current.view.message_containers.get = (msg_id) => {
|
|
assert.equal(msg_id, message.id);
|
|
return {
|
|
is_hidden: false,
|
|
};
|
|
};
|
|
|
|
override(page_params, "realm_allow_message_editing", true);
|
|
override(page_params, "realm_message_content_edit_limit_seconds", 0);
|
|
assert.equal(message_edit.get_editability(message), message_edit.editability_types.FULL);
|
|
|
|
$target.closest = (sel) => {
|
|
assert.equal(sel, ".message_row");
|
|
return {
|
|
toggleClass: noop,
|
|
};
|
|
};
|
|
|
|
mock_template("actions_popover_content.hbs", false, (opts) => {
|
|
// TODO: Test all the properties of the popover
|
|
assert.equal(
|
|
opts.conversation_time_uri,
|
|
"http://zulip.zulipdev.com/#narrow/stream/123-unknown/topic/Actions.20.281.29/near/999",
|
|
);
|
|
return "actions-content";
|
|
});
|
|
|
|
handler.call($target, e);
|
|
});
|