mirror of
https://github.com/zulip/zulip.git
synced 2025-10-23 04:52:12 +00:00
68c3e86ffa
Previously, if we had syntax in a URL slug that looked like a channel ID, but we couldn't find the channel (say, beacuse it's a link to a channel we're not subscribed to), parse_narrow would fail to parse it, resulting in incorrect error handling. This could break rendering of topic links that we want to process via rendered_markdown.ts. I've confirmed that the web app's logic for processing message_view.show does not require its caller to check the channel ID is accessible. The updated logic matches what we do in the mobile apps.
274 lines
9.4 KiB
JavaScript
274 lines
9.4 KiB
JavaScript
"use strict";
|
|
|
|
const assert = require("node:assert/strict");
|
|
|
|
const message_link_test_cases = require("../../zerver/tests/fixtures/message_link_test_cases.json");
|
|
|
|
const {zrequire} = require("./lib/namespace.cjs");
|
|
const {run_test} = require("./lib/test.cjs");
|
|
|
|
const hash_parser = zrequire("hash_parser");
|
|
const hash_util = zrequire("hash_util");
|
|
const stream_data = zrequire("stream_data");
|
|
const people = zrequire("people");
|
|
const spectators = zrequire("spectators");
|
|
|
|
const hamlet = {
|
|
user_id: 15,
|
|
email: "hamlet@example.com",
|
|
full_name: "Hamlet",
|
|
};
|
|
|
|
people.add_active_user(hamlet);
|
|
|
|
const frontend_id = 99;
|
|
const frontend = {
|
|
stream_id: frontend_id,
|
|
name: "frontend",
|
|
};
|
|
|
|
stream_data.add_sub(frontend);
|
|
|
|
run_test("hash_util", () => {
|
|
// Test encode_operand and decode_operand
|
|
function encode_decode_operand(operator, operand, expected_val) {
|
|
const encode_result = hash_util.encode_operand(operator, operand);
|
|
assert.equal(encode_result, expected_val);
|
|
const new_operand = encode_result;
|
|
const decode_result = hash_util.decode_operand(operator, new_operand);
|
|
assert.equal(decode_result, operand);
|
|
}
|
|
|
|
let operator = "sender";
|
|
let operand = hamlet.email;
|
|
|
|
encode_decode_operand(operator, operand, "15-Hamlet");
|
|
|
|
operator = "stream";
|
|
operand = frontend_id.toString();
|
|
|
|
encode_decode_operand(operator, operand, "99-frontend");
|
|
|
|
operator = "topic";
|
|
operand = "testing 123";
|
|
|
|
encode_decode_operand(operator, operand, "testing.20123");
|
|
});
|
|
|
|
run_test("test_get_hash_category", () => {
|
|
assert.deepEqual(hash_parser.get_hash_category("channels/subscribed"), "channels");
|
|
assert.deepEqual(hash_parser.get_hash_category("#settings/preferences"), "settings");
|
|
assert.deepEqual(hash_parser.get_hash_category("#drafts"), "drafts");
|
|
assert.deepEqual(hash_parser.get_hash_category("invites"), "invites");
|
|
|
|
window.location.hash = "#settings/profile";
|
|
assert.deepEqual(hash_parser.get_current_hash_category(), "settings");
|
|
});
|
|
|
|
run_test("test_get_hash_section", () => {
|
|
assert.equal(hash_parser.get_hash_section("channels/subscribed"), "subscribed");
|
|
assert.equal(hash_parser.get_hash_section("#settings/profile"), "profile");
|
|
|
|
assert.equal(hash_parser.get_hash_section("settings/10/general/"), "10");
|
|
|
|
assert.equal(hash_parser.get_hash_section("#drafts"), "");
|
|
assert.equal(hash_parser.get_hash_section(""), "");
|
|
|
|
window.location.hash = "#settings/profile";
|
|
assert.deepEqual(hash_parser.get_current_hash_section(), "profile");
|
|
});
|
|
|
|
run_test("get_current_nth_hash_section", () => {
|
|
window.location.hash = "#settings/profile";
|
|
assert.equal(hash_parser.get_current_nth_hash_section(0), "#settings");
|
|
assert.equal(hash_parser.get_current_nth_hash_section(1), "profile");
|
|
|
|
window.location.hash = "#settings/10/general";
|
|
assert.equal(hash_parser.get_current_nth_hash_section(0), "#settings");
|
|
assert.equal(hash_parser.get_current_nth_hash_section(1), "10");
|
|
assert.equal(hash_parser.get_current_nth_hash_section(2), "general");
|
|
assert.equal(hash_parser.get_current_nth_hash_section(3), "");
|
|
});
|
|
|
|
run_test("test_is_same_server_message_link", () => {
|
|
for (const message_link_test_case of message_link_test_cases) {
|
|
assert.equal(
|
|
hash_parser.is_same_server_message_link(message_link_test_case.message_link),
|
|
message_link_test_case.expected_output,
|
|
);
|
|
}
|
|
});
|
|
|
|
run_test("build_reload_url", () => {
|
|
window.location.hash = "#settings/profile";
|
|
assert.equal(hash_util.build_reload_url(), "+oldhash=settings%2Fprofile");
|
|
|
|
window.location.hash = "#test";
|
|
assert.equal(hash_util.build_reload_url(), "+oldhash=test");
|
|
|
|
window.location.hash = "#";
|
|
assert.equal(hash_util.build_reload_url(), "+oldhash=");
|
|
|
|
window.location.hash = "";
|
|
assert.equal(hash_util.build_reload_url(), "+oldhash=");
|
|
});
|
|
|
|
run_test("test is_editing_stream", () => {
|
|
window.location.hash = "#channels/1/announce";
|
|
assert.equal(hash_parser.is_editing_stream(1), true);
|
|
assert.equal(hash_parser.is_editing_stream(2), false);
|
|
|
|
// url is missing name at end
|
|
window.location.hash = "#channels/1";
|
|
assert.equal(hash_parser.is_editing_stream(1), false);
|
|
|
|
window.location.hash = "#channels/bogus/bogus";
|
|
assert.equal(hash_parser.is_editing_stream(1), false);
|
|
|
|
window.location.hash = "#test/narrow";
|
|
assert.equal(hash_parser.is_editing_stream(1), false);
|
|
});
|
|
|
|
run_test("test_is_create_new_stream_narrow", () => {
|
|
window.location.hash = "#channels/new";
|
|
assert.equal(hash_parser.is_create_new_stream_narrow(), true);
|
|
|
|
window.location.hash = "#some/random/hash";
|
|
assert.equal(hash_parser.is_create_new_stream_narrow(), false);
|
|
});
|
|
|
|
run_test("test_is_subscribers_section_opened_for_stream", () => {
|
|
window.location.hash = "#channels/1/Design/subscribers";
|
|
assert.equal(hash_parser.is_subscribers_section_opened_for_stream(), true);
|
|
|
|
window.location.hash = "#channels/99/.EC.A1.B0.EB.A6.AC.EB.B2.95.20.F0.9F.98.8E/subscribers";
|
|
assert.equal(hash_parser.is_subscribers_section_opened_for_stream(), true);
|
|
|
|
window.location.hash = "#channels/random/subscribers";
|
|
assert.equal(hash_parser.is_subscribers_section_opened_for_stream(), false);
|
|
|
|
window.location.hash = "#some/random/place/subscribers";
|
|
assert.equal(hash_parser.is_subscribers_section_opened_for_stream(), false);
|
|
|
|
window.location.hash = "#";
|
|
assert.equal(hash_parser.is_subscribers_section_opened_for_stream(), false);
|
|
});
|
|
|
|
run_test("test_is_in_specified_hash_category", () => {
|
|
window.location.hash = "#channels/1/Design/subscribers";
|
|
assert.equal(hash_parser.is_in_specified_hash_category(["channels", "channel"]), true);
|
|
|
|
window.location.hash = "#channels/99/.EC.A1.B0.EB.A6.AC.EB.B2.95.20.F0.9F.98.8E/subscribers";
|
|
assert.equal(hash_parser.is_in_specified_hash_category(["channels", "channel"]), true);
|
|
|
|
window.location.hash = "#gro/channels/channel";
|
|
assert.equal(hash_parser.is_in_specified_hash_category(["stream", "channel", "group"]), false);
|
|
|
|
window.location.hash = "#some/stream/channel/group";
|
|
assert.equal(hash_parser.is_in_specified_hash_category(["stream", "channel", "group"]), false);
|
|
|
|
window.location.hash = "#some/stream/channel/group";
|
|
assert.equal(hash_parser.is_in_specified_hash_category([""]), false);
|
|
|
|
window.location.hash = "#some/stream/channel/group";
|
|
assert.equal(hash_parser.is_in_specified_hash_category([]), false);
|
|
});
|
|
|
|
run_test("test_parse_narrow", () => {
|
|
assert.deepEqual(hash_util.parse_narrow(["narrow", "stream", "99-frontend"]), [
|
|
{negated: false, operator: "stream", operand: frontend_id.toString()},
|
|
]);
|
|
|
|
assert.deepEqual(hash_util.parse_narrow(["narrow", "-stream", "99-frontend"]), [
|
|
{negated: true, operator: "stream", operand: frontend_id.toString()},
|
|
]);
|
|
|
|
assert.equal(hash_util.parse_narrow(["narrow", "BOGUS"]), undefined);
|
|
|
|
// For unknown channel IDs, we still parse it; it could be a valid channel we do
|
|
// not have access to. We'll end up showing "Invalid stream" in the navbar.
|
|
assert.deepEqual(hash_util.parse_narrow(["narrow", "stream", "42-bogus"]), [
|
|
{negated: false, operator: "stream", operand: "42"},
|
|
]);
|
|
|
|
// Empty string as a topic name is valid.
|
|
assert.deepEqual(hash_util.parse_narrow(["narrow", "stream", "99-frontend", "topic", ""]), [
|
|
{negated: false, operator: "stream", operand: frontend_id.toString()},
|
|
{negated: false, operator: "topic", operand: ""},
|
|
]);
|
|
|
|
// Empty string used as an operand in other cases is invalid.
|
|
assert.deepEqual(
|
|
hash_util.parse_narrow(["narrow", "stream", "99-frontend", "topic", "", "near", ""]),
|
|
undefined,
|
|
);
|
|
});
|
|
|
|
run_test("test_channels_settings_edit_url", () => {
|
|
const sub = {
|
|
name: "research & development",
|
|
stream_id: 42,
|
|
};
|
|
assert.equal(
|
|
hash_util.channels_settings_edit_url(sub, "general"),
|
|
"#channels/42/research.20.26.20development/general",
|
|
);
|
|
});
|
|
|
|
run_test("test_by_conversation_and_time_url", () => {
|
|
let message = {
|
|
type: "stream",
|
|
stream_id: frontend.stream_id,
|
|
topic: "testing",
|
|
id: 42,
|
|
};
|
|
|
|
assert.equal(
|
|
hash_util.by_conversation_and_time_url(message),
|
|
"http://zulip.zulipdev.com/#narrow/channel/99-frontend/topic/testing/near/42",
|
|
);
|
|
|
|
message = {
|
|
type: "private",
|
|
display_recipient: [
|
|
{
|
|
id: hamlet.user_id,
|
|
},
|
|
],
|
|
id: 43,
|
|
};
|
|
|
|
assert.equal(
|
|
hash_util.by_conversation_and_time_url(message),
|
|
"http://zulip.zulipdev.com/#narrow/dm/15-dm/near/43",
|
|
);
|
|
});
|
|
|
|
run_test("test_search_public_streams_notice_url", () => {
|
|
function get_terms(url) {
|
|
return hash_util.parse_narrow(url.split("/"));
|
|
}
|
|
|
|
assert.equal(
|
|
hash_util.search_public_streams_notice_url(get_terms("#narrow/search/abc")),
|
|
"#narrow/channels/public/search/abc",
|
|
);
|
|
|
|
assert.equal(
|
|
hash_util.search_public_streams_notice_url(
|
|
get_terms("#narrow/has/link/has/image/has/attachment"),
|
|
),
|
|
"#narrow/channels/public/has/link/has/image/has/attachment",
|
|
);
|
|
|
|
assert.equal(
|
|
hash_util.search_public_streams_notice_url(get_terms("#narrow/sender/15")),
|
|
"#narrow/channels/public/sender/15-Hamlet",
|
|
);
|
|
});
|
|
|
|
run_test("test_current_hash_as_next", () => {
|
|
window.location.hash = "#foo";
|
|
assert.equal(spectators.current_hash_as_next(), "next=/%23foo");
|
|
});
|