mirror of
https://github.com/zulip/zulip.git
synced 2025-11-07 07:23:22 +00:00
ddcf2cb86e
We've been noticing a long delay between switching to a window with unread messages and the time that those messages actually appear. This got much worse around the time we added Notificon. Our hypothesis (supported by some testing) is that the work done by Notificon in creating a <canvas>, drawing into it, serializing it to PNG, etc. is using up some quota of background operations that would be better spent rendering messages. Switching to precomputed images should mitigate this problem. Resolves #896. May resolve #882 to our satisfaction. (imported from commit a2d98a163486bdd35fdfb5351f96c5529ba5c7e9)
96 lines
3.1 KiB
JavaScript
96 lines
3.1 KiB
JavaScript
var util = (function () {
|
|
|
|
var exports = {};
|
|
|
|
// From MDN: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Math/random
|
|
exports.random_int = function random_int(min, max) {
|
|
return Math.floor(Math.random() * (max - min + 1)) + min;
|
|
};
|
|
|
|
var favicon_selector = 'link[rel="shortcut icon"]';
|
|
|
|
// We need to reset the favicon after changing the
|
|
// window.location.hash or Firefox will drop the favicon. See
|
|
// https://bugzilla.mozilla.org/show_bug.cgi?id=519028
|
|
exports.reset_favicon = function () {
|
|
$(favicon_selector).detach().appendTo('head');
|
|
};
|
|
|
|
exports.set_favicon = function (url) {
|
|
// I'm not sure whether setting the href attr on the existing
|
|
// node would be sufficient. Notificon recreates the node.
|
|
$(favicon_selector).remove();
|
|
$('head').append($('<link>')
|
|
.attr('rel', 'shortcut icon')
|
|
.attr('href', url));
|
|
};
|
|
|
|
exports.make_loading_indicator = function (container, text) {
|
|
container.empty();
|
|
var spinner_elem = $('<div class="loading_indicator_spinner"></div>');
|
|
container.append(spinner_elem);
|
|
var text_width = 0;
|
|
|
|
if (text !== '' && text !== undefined) {
|
|
var text_elem = $('<span class="loading_indicator_text"></span>');
|
|
text_elem.text(text);
|
|
container.append(text_elem);
|
|
// See note, below
|
|
text_width = 20 + text_elem.width();
|
|
}
|
|
|
|
// These width calculations are tied to the spinner width and
|
|
// margins defined via CSS
|
|
//
|
|
// TODO: We set white-space to 'nowrap' because under some
|
|
// unknown circumstances (it happens on Keegan's laptop) the text
|
|
// width calculation, above, returns a result that's a few pixels
|
|
// too small. The container's div will be slightly too small,
|
|
// but that's probably OK for our purposes.
|
|
container.css({width: 38 + text_width,
|
|
height: 38,
|
|
display: 'block',
|
|
'white-space': 'nowrap'});
|
|
|
|
var spinner = new Spinner({
|
|
lines: 8,
|
|
length: 0,
|
|
width: 9,
|
|
radius: 9,
|
|
speed: 1.25,
|
|
shadow: false,
|
|
zIndex: 1000
|
|
}).spin(spinner_elem[0]);
|
|
container.data("spinner_obj", spinner);
|
|
|
|
// Make the spinner appear in the center of its enclosing
|
|
// element. spinner.el is a 0x0 div. The parts of the spinner
|
|
// are arranged so that they're centered on the upper-left corner
|
|
// of spinner.el. So, by setting spinner.el's position to
|
|
// relative and top/left to 50%, the center of the spinner will
|
|
// be located at the center of spinner_elem.
|
|
$(spinner.el).css({left: '50%', top: '50%'});
|
|
};
|
|
|
|
exports.destroy_loading_indicator = function (container) {
|
|
var spinner = container.data("spinner_obj");
|
|
if (spinner !== undefined) {
|
|
spinner.stop();
|
|
}
|
|
container.removeData("spinner_obj");
|
|
container.empty();
|
|
container.css({width: 0, height: 0, display: 'none'});
|
|
};
|
|
|
|
exports.show_first_run_message = function () {
|
|
$('#first_run_message').show();
|
|
};
|
|
|
|
exports.destroy_first_run_message = function () {
|
|
// A no-op if the element no longer exists
|
|
$('#first_run_message').remove();
|
|
};
|
|
|
|
return exports;
|
|
}());
|