mirror of
https://github.com/zulip/zulip.git
synced 2025-11-03 21:43:21 +00:00
8ab526a25a
In #23380, we are changing all occurrences of uri with url in order to follow the latest URL standard. Previous PRs #25038 and #25045 has replaced the occurences of uri that has no direct relation with realm. This commit changes just the model property, which has no API compatibility concerns.
88 lines
3.0 KiB
Python
88 lines
3.0 KiB
Python
from email.headerregistry import Address
|
|
from typing import Any
|
|
|
|
from django.conf import settings
|
|
from django.core.exceptions import ValidationError
|
|
from django.core.validators import validate_email
|
|
from django.db import migrations
|
|
from django.db.backends.base.schema import BaseDatabaseSchemaEditor
|
|
from django.db.migrations.state import StateApps
|
|
|
|
|
|
def host_for_subdomain(subdomain: str) -> str:
|
|
if subdomain == "":
|
|
return settings.EXTERNAL_HOST
|
|
default_host = f"{subdomain}.{settings.EXTERNAL_HOST}"
|
|
return settings.REALM_HOSTS.get(subdomain, default_host)
|
|
|
|
|
|
def get_fake_email_domain(realm: Any) -> str:
|
|
"""
|
|
Taken from zerver.models. Adjusted to work in a migration without changing
|
|
behavior.
|
|
"""
|
|
try:
|
|
# Check that realm.host can be used to form valid email addresses.
|
|
realm_host = host_for_subdomain(realm.string_id)
|
|
validate_email(Address(username="bot", domain=realm_host).addr_spec)
|
|
return realm_host
|
|
except ValidationError:
|
|
pass
|
|
|
|
try:
|
|
# Check that the fake email domain can be used to form valid email addresses.
|
|
validate_email(Address(username="bot", domain=settings.FAKE_EMAIL_DOMAIN).addr_spec)
|
|
except ValidationError:
|
|
raise Exception(
|
|
settings.FAKE_EMAIL_DOMAIN + " is not a valid domain. "
|
|
"Consider setting the FAKE_EMAIL_DOMAIN setting."
|
|
)
|
|
|
|
return settings.FAKE_EMAIL_DOMAIN
|
|
|
|
|
|
def fix_dummy_users(apps: StateApps, schema_editor: BaseDatabaseSchemaEditor) -> None:
|
|
"""
|
|
do_delete_users had two bugs:
|
|
1. Creating the replacement dummy users with active=True
|
|
2. Creating the replacement dummy users with email domain set to realm.url,
|
|
which may not be a valid email domain.
|
|
Prior commits fixed the bugs, and this migration fixes the pre-existing objects.
|
|
"""
|
|
|
|
UserProfile = apps.get_model("zerver", "UserProfile")
|
|
Subscription = apps.get_model("zerver", "Subscription")
|
|
users_to_fix = UserProfile.objects.filter(
|
|
is_mirror_dummy=True, is_active=True, delivery_email__regex=r"^deleteduser\d+@.+"
|
|
)
|
|
|
|
update_fields = ["is_active"]
|
|
for user_profile in users_to_fix:
|
|
user_profile.is_active = False
|
|
try:
|
|
validate_email(user_profile.delivery_email)
|
|
except ValidationError:
|
|
user_profile.delivery_email = Address(
|
|
username=f"deleteduser{user_profile.id}",
|
|
domain=get_fake_email_domain(user_profile.realm),
|
|
).addr_spec
|
|
|
|
update_fields.append("delivery_email")
|
|
|
|
UserProfile.objects.bulk_update(users_to_fix, update_fields)
|
|
# The denormalized is_user_active field needs to be updated too.
|
|
Subscription.objects.filter(user_profile__in=users_to_fix).update(is_user_active=False)
|
|
|
|
|
|
class Migration(migrations.Migration):
|
|
dependencies = [
|
|
("zerver", "0372_realmemoji_unique_realm_emoji_when_false_deactivated"),
|
|
]
|
|
|
|
operations = [
|
|
migrations.RunPython(
|
|
fix_dummy_users,
|
|
reverse_code=migrations.RunPython.noop,
|
|
)
|
|
]
|