Files
zulip/static/js/todo_widget.js
Anders Kaseorg 02511bff1c js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.

import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";

const checkExpression = (node: n.Node): node is K.ExpressionKind =>
  n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
  n.Statement.check(node);

for (const file of process.argv.slice(2)) {
  console.log("Parsing", file);
  const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
    parser: path.extname(file) === ".ts" ? tsParser : babelParser,
  });
  let changed = false;
  let inLoop = false;
  let replaceReturn = false;

  const visitLoop = (...args: string[]) =>
    function(this: Context, path: NodePath) {
      for (const arg of args) {
        this.visit(path.get(arg));
      }
      const old = { inLoop };
      inLoop = true;
      this.visit(path.get("body"));
      inLoop = old.inLoop;
      return false;
    };

  recast.visit(ast, {
    visitDoWhileStatement: visitLoop("test"),

    visitExpressionStatement(path) {
      const { expression, comments } = path.node;
      let valueOnly;
      if (
        n.CallExpression.check(expression) &&
        n.MemberExpression.check(expression.callee) &&
        !expression.callee.computed &&
        n.Identifier.check(expression.callee.object) &&
        expression.callee.object.name === "_" &&
        n.Identifier.check(expression.callee.property) &&
        ["each", "forEach"].includes(expression.callee.property.name) &&
        [2, 3].includes(expression.arguments.length) &&
        checkExpression(expression.arguments[0]) &&
        (n.FunctionExpression.check(expression.arguments[1]) ||
          n.ArrowFunctionExpression.check(expression.arguments[1])) &&
        [1, 2].includes(expression.arguments[1].params.length) &&
        n.Identifier.check(expression.arguments[1].params[0]) &&
        ((valueOnly = expression.arguments[1].params[1] === undefined) ||
          n.Identifier.check(expression.arguments[1].params[1])) &&
        (expression.arguments[2] === undefined ||
          n.ThisExpression.check(expression.arguments[2]))
      ) {
        const old = { inLoop, replaceReturn };
        inLoop = false;
        replaceReturn = true;
        this.visit(
          path
            .get("expression")
            .get("arguments")
            .get(1)
            .get("body")
        );
        inLoop = old.inLoop;
        replaceReturn = old.replaceReturn;

        const [right, { body, params }] = expression.arguments;
        const loop = b.forOfStatement(
          b.variableDeclaration("let", [
            b.variableDeclarator(
              valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
            ),
          ]),
          valueOnly
            ? right
            : b.callExpression(
                b.memberExpression(right, b.identifier("entries")),
                []
              ),
          checkStatement(body) ? body : b.expressionStatement(body)
        );
        loop.comments = comments;
        path.replace(loop);
        changed = true;
      }
      this.traverse(path);
    },

    visitForStatement: visitLoop("init", "test", "update"),

    visitForInStatement: visitLoop("left", "right"),

    visitForOfStatement: visitLoop("left", "right"),

    visitFunction(path) {
      this.visit(path.get("params"));
      const old = { replaceReturn };
      replaceReturn = false;
      this.visit(path.get("body"));
      replaceReturn = old.replaceReturn;
      return false;
    },

    visitReturnStatement(path) {
      if (replaceReturn) {
        assert(!inLoop); // could use labeled continue if this ever fires
        const { argument, comments } = path.node;
        if (argument === null) {
          const s = b.continueStatement();
          s.comments = comments;
          path.replace(s);
        } else {
          const s = b.expressionStatement(argument);
          s.comments = comments;
          path.replace(s, b.continueStatement());
        }
        return false;
      }
      this.traverse(path);
    },

    visitWhileStatement: visitLoop("test"),
  });

  if (changed) {
    console.log("Writing", file);
    fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
  }
}

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-07 14:09:47 -08:00

177 lines
4.8 KiB
JavaScript

const render_widgets_todo_widget = require('../templates/widgets/todo_widget.hbs');
const render_widgets_todo_widget_tasks = require('../templates/widgets/todo_widget_tasks.hbs');
exports.task_data_holder = function () {
const self = {};
const all_tasks = [];
const pending_tasks = [];
const completed_tasks = [];
let my_idx = 0;
self.get_widget_data = function () {
const widget_data = {
pending_tasks: pending_tasks,
completed_tasks: completed_tasks,
};
return widget_data;
};
self.check_task = {
task_exists: function (task) {
const task_exists = _.any(all_tasks, function (item) {
return item.task === task;
});
return task_exists;
},
};
self.handle = {
new_task: {
outbound: function (task) {
const event = {
type: 'new_task',
key: my_idx,
task: task,
completed: false,
};
my_idx += 1;
if (!self.check_task.task_exists(task)) {
return event;
}
return;
},
inbound: function (sender_id, data) {
const idx = data.key;
const task = data.task;
const completed = data.completed;
const task_data = {
task: task,
user_id: sender_id,
key: idx,
completed: completed,
};
if (!self.check_task.task_exists(task)) {
pending_tasks.push(task_data);
all_tasks.push(task_data);
if (my_idx <= idx) {
my_idx = idx + 1;
}
}
},
},
strike: {
outbound: function (key) {
const event = {
type: 'strike',
key: key,
};
return event;
},
inbound: function (sender_id, data) {
const key = data.key;
const task = all_tasks[key];
let index;
if (task === undefined) {
blueslip.error('unknown key for tasks: ' + key);
return;
}
all_tasks[key].completed = !all_tasks[key].completed;
// toggle
if (task.completed) {
index = pending_tasks.indexOf(task);
pending_tasks.splice(index, 1);
completed_tasks.unshift(task);
} else {
index = completed_tasks.indexOf(task);
completed_tasks.splice(index, 1);
pending_tasks.push(task);
}
},
},
};
self.handle_event = function (sender_id, data) {
const type = data.type;
if (self.handle[type]) {
self.handle[type].inbound(sender_id, data);
}
};
return self;
};
exports.activate = function (opts) {
const elem = opts.elem;
const callback = opts.callback;
const task_data = exports.task_data_holder();
function render() {
const html = render_widgets_todo_widget();
elem.html(html);
elem.find("button.add-task").on('click', function (e) {
e.stopPropagation();
elem.find(".widget-error").text('');
const task = elem.find("input.add-task").val().trim();
if (task === '') {
return;
}
elem.find(".add-task").val('').focus();
const task_exists = task_data.check_task.task_exists(task);
if (task_exists) {
elem.find(".widget-error").text(i18n.t('Task already exists'));
return;
}
const data = task_data.handle.new_task.outbound(task);
callback(data);
});
}
function render_results() {
const widget_data = task_data.get_widget_data();
const html = render_widgets_todo_widget_tasks(widget_data);
elem.find('ul.todo-widget').html(html);
elem.find(".widget-error").text('');
elem.find("button.task").on('click', function (e) {
e.stopPropagation();
const key = $(e.target).attr('data-key');
const data = task_data.handle.strike.outbound(key);
callback(data);
});
}
elem.handle_events = function (events) {
for (const event of events) {
task_data.handle_event(event.sender_id, event.data);
}
render_results();
};
render();
render_results();
};
window.todo_widget = exports;