mirror of
https://github.com/zulip/zulip.git
synced 2025-11-06 06:53:25 +00:00
e96ede0ef6
For spectators, the chunk of page_params that originates from do_events_register isn’t assigned until ui_init.js. That means the TypeScript type of page_params is mostly a lie during module load time: reading a parameter too early silently results in undefined rather than the declared type, with unpredictable results later on. We want to make such an early read into an immediate runtime error, for both users and spectators consistently, and pave the way for runtime validation of the page_params type. As a first step, split out the subset of fields that pertain to the current user. Signed-off-by: Anders Kaseorg <anders@zulip.com>
81 lines
2.6 KiB
JavaScript
81 lines
2.6 KiB
JavaScript
"use strict";
|
|
|
|
const {strict: assert} = require("assert");
|
|
|
|
const {zrequire} = require("./lib/namespace");
|
|
const {run_test} = require("./lib/test");
|
|
const {current_user} = require("./lib/zpage_params");
|
|
|
|
const people = zrequire("people");
|
|
const stream_create_subscribers_data = zrequire("stream_create_subscribers_data");
|
|
|
|
const me = {
|
|
email: "me@zulip.com",
|
|
full_name: "Zed", // Zed will sort to the top by virtue of being the current user.
|
|
user_id: 400,
|
|
};
|
|
|
|
const test_user101 = {
|
|
email: "test101@zulip.com",
|
|
full_name: "Test User 101",
|
|
user_id: 101,
|
|
};
|
|
|
|
const test_user102 = {
|
|
email: "test102@zulip.com",
|
|
full_name: "Test User 102",
|
|
user_id: 102,
|
|
};
|
|
|
|
const test_user103 = {
|
|
email: "test102@zulip.com",
|
|
full_name: "Test User 103",
|
|
user_id: 103,
|
|
};
|
|
|
|
function test(label, f) {
|
|
run_test(label, (helpers) => {
|
|
current_user.is_admin = false;
|
|
people.init();
|
|
people.add_active_user(me);
|
|
people.add_active_user(test_user101);
|
|
people.add_active_user(test_user102);
|
|
people.add_active_user(test_user103);
|
|
current_user.user_id = me.user_id;
|
|
people.initialize_current_user(me.user_id);
|
|
f(helpers);
|
|
});
|
|
}
|
|
|
|
test("basics", () => {
|
|
stream_create_subscribers_data.initialize_with_current_user();
|
|
|
|
assert.deepEqual(stream_create_subscribers_data.sorted_user_ids(), [me.user_id]);
|
|
assert.deepEqual(stream_create_subscribers_data.get_principals(), [me.user_id]);
|
|
|
|
const all_user_ids = stream_create_subscribers_data.get_all_user_ids();
|
|
assert.deepEqual(all_user_ids, [101, 102, 103, 400]);
|
|
|
|
stream_create_subscribers_data.add_user_ids(all_user_ids);
|
|
assert.deepEqual(stream_create_subscribers_data.sorted_user_ids(), [400, 101, 102, 103]);
|
|
|
|
stream_create_subscribers_data.remove_user_ids([101, 103]);
|
|
assert.deepEqual(stream_create_subscribers_data.sorted_user_ids(), [400, 102]);
|
|
assert.deepEqual(stream_create_subscribers_data.get_potential_subscribers(), [
|
|
test_user101,
|
|
test_user103,
|
|
]);
|
|
|
|
assert.ok(stream_create_subscribers_data.must_be_subscribed(me.user_id));
|
|
assert.ok(!stream_create_subscribers_data.must_be_subscribed(test_user101.user_id));
|
|
});
|
|
|
|
test("must_be_subscribed", () => {
|
|
current_user.is_admin = false;
|
|
assert.ok(stream_create_subscribers_data.must_be_subscribed(me.user_id));
|
|
assert.ok(!stream_create_subscribers_data.must_be_subscribed(test_user101.user_id));
|
|
current_user.is_admin = true;
|
|
assert.ok(!stream_create_subscribers_data.must_be_subscribed(me.user_id));
|
|
assert.ok(!stream_create_subscribers_data.must_be_subscribed(test_user101.user_id));
|
|
});
|