mirror of
https://github.com/zulip/zulip.git
synced 2025-11-01 04:23:46 +00:00
Now, the system uses word='' and an editing=True for rendering an form for addition of alert words. This is a very vulnerable way to implement said feature and this commit fixes that. The addition form has been moved to alert_word_settings.hbs thereby rendering it only once but always. Now, we do not have to manually add an empty word and editing for the form to be rendered. As part of refactoring, the editing parameter has also been removed as there is no purpose left.
107 lines
3.4 KiB
JavaScript
107 lines
3.4 KiB
JavaScript
const render_alert_word_settings_item = require('../templates/alert_word_settings_item.hbs');
|
|
|
|
exports.render_alert_words_ui = function () {
|
|
const words = alert_words.get_word_list();
|
|
words.sort();
|
|
const word_list = $('#alert_words_list');
|
|
|
|
word_list.find('.alert-word-item').remove();
|
|
|
|
for (const alert_word of words) {
|
|
const rendered_alert_word = render_alert_word_settings_item({
|
|
word: alert_word,
|
|
});
|
|
word_list.append(rendered_alert_word);
|
|
}
|
|
|
|
// Focus new alert word name text box.
|
|
$('#create_alert_word_name').focus();
|
|
};
|
|
|
|
function update_alert_word_status(status_text, is_error) {
|
|
const alert_word_status = $('#alert_word_status');
|
|
if (is_error) {
|
|
alert_word_status.removeClass('alert-success').addClass('alert-danger');
|
|
} else {
|
|
alert_word_status.removeClass('alert-danger').addClass('alert-success');
|
|
}
|
|
alert_word_status.find('.alert_word_status_text').text(status_text);
|
|
alert_word_status.show();
|
|
}
|
|
|
|
function add_alert_word(alert_word) {
|
|
alert_word = $.trim(alert_word);
|
|
if (alert_word === '') {
|
|
update_alert_word_status(i18n.t("Alert word can't be empty!"), true);
|
|
return;
|
|
} else if (alert_words.has_alert_word(alert_word)) {
|
|
update_alert_word_status(i18n.t("Alert word already exists!"), true);
|
|
return;
|
|
}
|
|
|
|
const words_to_be_added = [alert_word];
|
|
|
|
channel.post({
|
|
url: '/json/users/me/alert_words',
|
|
data: {alert_words: JSON.stringify(words_to_be_added)},
|
|
success: function () {
|
|
const message = "Alert word \"" + words_to_be_added + "\" added successfully!";
|
|
update_alert_word_status(i18n.t(message), false);
|
|
$('#create_alert_word_name').val('');
|
|
},
|
|
error: function () {
|
|
update_alert_word_status(i18n.t("Error adding alert word!"), true);
|
|
},
|
|
});
|
|
}
|
|
|
|
function remove_alert_word(alert_word) {
|
|
const words_to_be_removed = [alert_word];
|
|
|
|
channel.del({
|
|
url: '/json/users/me/alert_words',
|
|
data: {alert_words: JSON.stringify(words_to_be_removed)},
|
|
success: function () {
|
|
update_alert_word_status(i18n.t("Alert word removed successfully!"), false);
|
|
},
|
|
error: function () {
|
|
update_alert_word_status(i18n.t("Error removing alert word!"), true);
|
|
},
|
|
});
|
|
}
|
|
|
|
exports.set_up_alert_words = function () {
|
|
// The settings page must be rendered before this function gets called.
|
|
|
|
exports.render_alert_words_ui();
|
|
|
|
$('#create_alert_word_form').on('click', '#create_alert_word_button', function () {
|
|
const word = $('#create_alert_word_name').val();
|
|
add_alert_word(word);
|
|
});
|
|
|
|
$('#alert_words_list').on('click', '.remove-alert-word', function (event) {
|
|
const word = $(event.currentTarget).parents('li').find('.value').text();
|
|
remove_alert_word(word);
|
|
});
|
|
|
|
$('#create_alert_word_form').on('keypress', '#create_alert_word_name', function (event) {
|
|
const key = event.which;
|
|
// Handle enter (13) as "add".
|
|
if (key === 13) {
|
|
event.preventDefault();
|
|
|
|
const word = $(event.target).val();
|
|
add_alert_word(word);
|
|
}
|
|
});
|
|
|
|
$('#alert-word-settings').on('click', '.close-alert-word-status', function (event) {
|
|
event.preventDefault();
|
|
const alert = $(event.currentTarget).parents('.alert');
|
|
alert.hide();
|
|
});
|
|
};
|
|
|
|
window.alert_words_ui = exports;
|