mirror of
https://github.com/zulip/zulip.git
synced 2025-10-29 02:53:52 +00:00
We now just use a module._load hook to inject stubs into our code. For conversion purposes I temporarily maintain the API of rewiremock, apart from the enable/disable pieces, but I will make a better wrapper in an upcoming commit. We can detect when rewiremock is called after zrequire now, and I fix all the violations in this commit, mostly by using override. We can also detect when a mock is needlessly created, and I fix all the violations in this commit. The one minor nuisance that this commit introduces is that you can only stub out modules in the Zulip source tree, which is now static/js. This should not really be a problem--there are usually better techniques to deal with third party depenencies. In the prior commit I show a typical workaround, which is to create a one-line wrapper in your test code. It's often the case that you can simply use override(), as well. In passing I kill off `reset_modules`, and I eliminated the second argument to zrequire, which dates back to pre-es6 days.
179 lines
3.9 KiB
JavaScript
179 lines
3.9 KiB
JavaScript
"use strict";
|
|
|
|
const {strict: assert} = require("assert");
|
|
|
|
const {rewiremock, zrequire} = require("../zjsunit/namespace");
|
|
const {run_test} = require("../zjsunit/test");
|
|
|
|
rewiremock("../../static/js/message_scroll").with({
|
|
hide_loading_older: () => {},
|
|
show_loading_older: () => {},
|
|
hide_loading_newer: () => {},
|
|
show_loading_newer: () => {},
|
|
});
|
|
|
|
const {FetchStatus} = zrequire("fetch_status");
|
|
|
|
let fetch_status = new FetchStatus();
|
|
|
|
function reset() {
|
|
fetch_status = new FetchStatus();
|
|
}
|
|
|
|
function can_load_newer() {
|
|
assert.equal(fetch_status.can_load_newer_messages(), true);
|
|
}
|
|
|
|
function blocked_newer() {
|
|
assert.equal(fetch_status.can_load_newer_messages(), false);
|
|
}
|
|
|
|
function can_load_older() {
|
|
assert.equal(fetch_status.can_load_older_messages(), true);
|
|
}
|
|
|
|
function blocked_older() {
|
|
assert.equal(fetch_status.can_load_older_messages(), false);
|
|
}
|
|
|
|
function has_found_oldest() {
|
|
assert.equal(fetch_status.has_found_oldest(), true);
|
|
}
|
|
|
|
function has_not_found_oldest() {
|
|
assert.equal(fetch_status.has_found_oldest(), false);
|
|
}
|
|
|
|
function has_found_newest() {
|
|
assert.equal(fetch_status.has_found_newest(), true);
|
|
}
|
|
|
|
function has_not_found_newest() {
|
|
assert.equal(fetch_status.has_found_newest(), false);
|
|
}
|
|
|
|
function can_load_history() {
|
|
assert.equal(fetch_status.history_limited(), false);
|
|
}
|
|
|
|
function blocked_history() {
|
|
assert.equal(fetch_status.history_limited(), true);
|
|
}
|
|
|
|
run_test("basics", () => {
|
|
reset();
|
|
|
|
fetch_status.start_newer_batch({update_loading_indicator: false});
|
|
fetch_status.start_older_batch({update_loading_indicator: false});
|
|
|
|
blocked_newer();
|
|
blocked_older();
|
|
can_load_history();
|
|
has_not_found_oldest();
|
|
has_not_found_newest();
|
|
|
|
let data = {
|
|
update_loading_indicator: false,
|
|
found_oldest: true,
|
|
found_newest: true,
|
|
history_limited: true,
|
|
};
|
|
fetch_status.finish_newer_batch([], data);
|
|
fetch_status.finish_older_batch(data);
|
|
|
|
has_found_oldest();
|
|
has_found_newest();
|
|
blocked_newer();
|
|
blocked_older();
|
|
blocked_history();
|
|
|
|
reset();
|
|
|
|
fetch_status.start_newer_batch({update_loading_indicator: true});
|
|
fetch_status.start_older_batch({update_loading_indicator: true});
|
|
|
|
blocked_newer();
|
|
blocked_older();
|
|
can_load_history();
|
|
|
|
data = {
|
|
update_loading_indicator: false,
|
|
found_oldest: false,
|
|
found_newest: false,
|
|
history_limited: false,
|
|
};
|
|
fetch_status.finish_newer_batch([], data);
|
|
fetch_status.finish_older_batch(data);
|
|
|
|
can_load_older();
|
|
can_load_newer();
|
|
can_load_history();
|
|
|
|
reset();
|
|
|
|
can_load_older();
|
|
|
|
fetch_status.start_older_batch({update_loading_indicator: false});
|
|
|
|
blocked_older();
|
|
can_load_newer();
|
|
can_load_history();
|
|
|
|
fetch_status.finish_older_batch({
|
|
update_loading_indicator: true,
|
|
found_oldest: false,
|
|
history_limited: false,
|
|
});
|
|
|
|
can_load_older();
|
|
can_load_newer();
|
|
can_load_history();
|
|
|
|
fetch_status.start_older_batch({update_loading_indicator: true});
|
|
|
|
blocked_older();
|
|
can_load_newer();
|
|
can_load_history();
|
|
|
|
fetch_status.finish_older_batch({
|
|
update_loading_indicator: true,
|
|
found_oldest: true,
|
|
history_limited: true,
|
|
});
|
|
|
|
blocked_older();
|
|
can_load_newer();
|
|
blocked_history();
|
|
|
|
reset();
|
|
|
|
can_load_older();
|
|
can_load_newer();
|
|
|
|
fetch_status.start_newer_batch({update_loading_indicator: false});
|
|
|
|
can_load_older();
|
|
blocked_newer();
|
|
|
|
fetch_status.finish_newer_batch([], {
|
|
update_loading_indicator: true,
|
|
found_newest: false,
|
|
});
|
|
|
|
can_load_older();
|
|
can_load_newer();
|
|
|
|
fetch_status.start_newer_batch({update_loading_indicator: true});
|
|
|
|
can_load_older();
|
|
blocked_newer();
|
|
|
|
fetch_status.finish_newer_batch([], {
|
|
update_loading_indicator: true,
|
|
found_newest: true,
|
|
});
|
|
|
|
can_load_older();
|
|
blocked_newer();
|
|
});
|