mirror of
				https://github.com/zulip/zulip.git
				synced 2025-10-30 19:43:47 +00:00 
			
		
		
		
	We now just use a module._load hook to inject stubs into our code. For conversion purposes I temporarily maintain the API of rewiremock, apart from the enable/disable pieces, but I will make a better wrapper in an upcoming commit. We can detect when rewiremock is called after zrequire now, and I fix all the violations in this commit, mostly by using override. We can also detect when a mock is needlessly created, and I fix all the violations in this commit. The one minor nuisance that this commit introduces is that you can only stub out modules in the Zulip source tree, which is now static/js. This should not really be a problem--there are usually better techniques to deal with third party depenencies. In the prior commit I show a typical workaround, which is to create a one-line wrapper in your test code. It's often the case that you can simply use override(), as well. In passing I kill off `reset_modules`, and I eliminated the second argument to zrequire, which dates back to pre-es6 days.
		
			
				
	
	
		
			196 lines
		
	
	
		
			4.6 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			196 lines
		
	
	
		
			4.6 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
| "use strict";
 | |
| 
 | |
| const {strict: assert} = require("assert");
 | |
| 
 | |
| const {rewiremock, set_global, zrequire} = require("../zjsunit/namespace");
 | |
| const {run_test} = require("../zjsunit/test");
 | |
| 
 | |
| const noop = () => {};
 | |
| 
 | |
| const page_params = set_global("page_params", {});
 | |
| const channel = {__esModule: true};
 | |
| rewiremock("../../static/js/channel").with(channel);
 | |
| const reload = {__esModule: true};
 | |
| rewiremock("../../static/js/reload").with(reload);
 | |
| const reload_state = {__esModule: true};
 | |
| rewiremock("../../static/js/reload_state").with(reload_state);
 | |
| const sent_messages = {
 | |
|     __esModule: true,
 | |
|     start_tracking_message: noop,
 | |
|     report_server_ack: noop,
 | |
| };
 | |
| 
 | |
| rewiremock("../../static/js/sent_messages").with(sent_messages);
 | |
| 
 | |
| const people = zrequire("people");
 | |
| const transmit = zrequire("transmit");
 | |
| 
 | |
| run_test("transmit_message_ajax", () => {
 | |
|     let success_func_called;
 | |
|     const success = () => {
 | |
|         success_func_called = true;
 | |
|     };
 | |
| 
 | |
|     const request = {foo: "bar"};
 | |
| 
 | |
|     channel.post = (opts) => {
 | |
|         assert.equal(opts.url, "/json/messages");
 | |
|         assert.equal(opts.data.foo, "bar");
 | |
|         opts.success();
 | |
|     };
 | |
| 
 | |
|     transmit.send_message(request, success);
 | |
| 
 | |
|     assert(success_func_called);
 | |
| 
 | |
|     channel.xhr_error_message = (msg) => {
 | |
|         assert.equal(msg, "Error sending message");
 | |
|         return msg;
 | |
|     };
 | |
| 
 | |
|     channel.post = (opts) => {
 | |
|         assert.equal(opts.url, "/json/messages");
 | |
|         assert.equal(opts.data.foo, "bar");
 | |
|         const xhr = "whatever";
 | |
|         opts.error(xhr, "timeout");
 | |
|     };
 | |
| 
 | |
|     let error_func_called;
 | |
|     const error = (response) => {
 | |
|         assert.equal(response, "Error sending message");
 | |
|         error_func_called = true;
 | |
|     };
 | |
|     transmit.send_message(request, success, error);
 | |
|     assert(error_func_called);
 | |
| });
 | |
| 
 | |
| run_test("transmit_message_ajax_reload_pending", () => {
 | |
|     const success = () => {
 | |
|         throw new Error("unexpected success");
 | |
|     };
 | |
| 
 | |
|     reload_state.is_pending = () => true;
 | |
| 
 | |
|     let reload_initiated;
 | |
|     reload.initiate = (opts) => {
 | |
|         reload_initiated = true;
 | |
|         assert.deepEqual(opts, {
 | |
|             immediate: true,
 | |
|             save_pointer: true,
 | |
|             save_narrow: true,
 | |
|             save_compose: true,
 | |
|             send_after_reload: true,
 | |
|         });
 | |
|     };
 | |
| 
 | |
|     const request = {foo: "bar"};
 | |
| 
 | |
|     let error_func_called;
 | |
|     const error = (response) => {
 | |
|         assert.equal(response, "Error sending message");
 | |
|         error_func_called = true;
 | |
|     };
 | |
| 
 | |
|     error_func_called = false;
 | |
|     channel.post = (opts) => {
 | |
|         assert.equal(opts.url, "/json/messages");
 | |
|         assert.equal(opts.data.foo, "bar");
 | |
|         const xhr = "whatever";
 | |
|         opts.error(xhr, "bad request");
 | |
|     };
 | |
|     transmit.send_message(request, success, error);
 | |
|     assert(!error_func_called);
 | |
|     assert(reload_initiated);
 | |
| });
 | |
| 
 | |
| run_test("reply_message_stream", () => {
 | |
|     const stream_message = {
 | |
|         type: "stream",
 | |
|         stream: "social",
 | |
|         topic: "lunch",
 | |
|         sender_full_name: "Alice",
 | |
|         sender_id: 123,
 | |
|     };
 | |
| 
 | |
|     const content = "hello";
 | |
| 
 | |
|     let send_message_args;
 | |
| 
 | |
|     transmit.__Rewire__("send_message", (args) => {
 | |
|         send_message_args = args;
 | |
|     });
 | |
| 
 | |
|     page_params.user_id = 44;
 | |
|     page_params.queue_id = 66;
 | |
|     sent_messages.get_new_local_id = () => "99";
 | |
| 
 | |
|     transmit.reply_message({
 | |
|         message: stream_message,
 | |
|         content,
 | |
|     });
 | |
| 
 | |
|     assert.deepEqual(send_message_args, {
 | |
|         sender_id: 44,
 | |
|         queue_id: 66,
 | |
|         local_id: "99",
 | |
|         type: "stream",
 | |
|         to: "social",
 | |
|         content: "@**Alice** hello",
 | |
|         topic: "lunch",
 | |
|     });
 | |
| });
 | |
| 
 | |
| run_test("reply_message_private", () => {
 | |
|     const fred = {
 | |
|         user_id: 3,
 | |
|         email: "fred@example.com",
 | |
|         full_name: "Fred Frost",
 | |
|     };
 | |
|     people.add_active_user(fred);
 | |
| 
 | |
|     people.is_my_user_id = () => false;
 | |
| 
 | |
|     const pm_message = {
 | |
|         type: "private",
 | |
|         display_recipient: [{id: fred.user_id}],
 | |
|     };
 | |
| 
 | |
|     const content = "hello";
 | |
| 
 | |
|     let send_message_args;
 | |
| 
 | |
|     transmit.__Rewire__("send_message", (args) => {
 | |
|         send_message_args = args;
 | |
|     });
 | |
| 
 | |
|     page_params.user_id = 155;
 | |
|     page_params.queue_id = 177;
 | |
|     sent_messages.get_new_local_id = () => "199";
 | |
| 
 | |
|     transmit.reply_message({
 | |
|         message: pm_message,
 | |
|         content,
 | |
|     });
 | |
| 
 | |
|     assert.deepEqual(send_message_args, {
 | |
|         sender_id: 155,
 | |
|         queue_id: 177,
 | |
|         local_id: "199",
 | |
|         type: "private",
 | |
|         to: '["fred@example.com"]',
 | |
|         content: "hello",
 | |
|     });
 | |
| });
 | |
| 
 | |
| run_test("reply_message_errors", () => {
 | |
|     const bogus_message = {
 | |
|         type: "bogus",
 | |
|     };
 | |
| 
 | |
|     blueslip.expect("error", "unknown message type: bogus");
 | |
| 
 | |
|     transmit.reply_message({
 | |
|         message: bogus_message,
 | |
|     });
 | |
| });
 |