mirror of
https://github.com/zulip/zulip.git
synced 2025-10-31 03:53:50 +00:00
02511bff1c
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
79 lines
2.2 KiB
JavaScript
79 lines
2.2 KiB
JavaScript
const render_confirm_dialog = require("../templates/confirm_dialog.hbs");
|
|
|
|
/*
|
|
Look for confirm_dialog in settings_user_groups
|
|
to see an example of how to use this widget. It's
|
|
pretty simple to use!
|
|
|
|
Some things to note:
|
|
|
|
1) We create DOM on the fly, and we remove
|
|
the DOM once it's closed.
|
|
|
|
2) We attach the DOM for the modal to conf.parent,
|
|
and this temporary DOM location will influence
|
|
how styles work.
|
|
|
|
3) The cancel button is driven by bootstrap.js.
|
|
|
|
4) For settings, we have a click handler in settings.js
|
|
that will close the dialog via overlays.close_active_modal.
|
|
|
|
5) We assume that since this is a modal, you will
|
|
only ever have one confirm dialog active at any
|
|
time.
|
|
|
|
*/
|
|
|
|
exports.launch = function (conf) {
|
|
const html = render_confirm_dialog();
|
|
const confirm_dialog = $(html);
|
|
|
|
const conf_fields = [
|
|
// The next three fields should be safe HTML. If callers
|
|
// interpolate user data into strings, they should use
|
|
// templates.
|
|
'html_heading',
|
|
'html_body',
|
|
'html_yes_button',
|
|
'on_click',
|
|
'parent',
|
|
];
|
|
|
|
for (const f of conf_fields) {
|
|
if (!conf[f]) {
|
|
blueslip.error('programmer omitted ' + f);
|
|
}
|
|
}
|
|
|
|
conf.parent.append(confirm_dialog);
|
|
|
|
// Close any existing modals--on settings screens you can
|
|
// have multiple buttons that need confirmation.
|
|
if (overlays.is_modal_open()) {
|
|
overlays.close_modal('confirm_dialog_modal');
|
|
}
|
|
|
|
confirm_dialog.find('.confirm_dialog_heading').html(conf.html_heading);
|
|
confirm_dialog.find('.confirm_dialog_body').html(conf.html_body);
|
|
|
|
const yes_button = confirm_dialog.find('.confirm_dialog_yes_button');
|
|
|
|
yes_button.html(conf.html_yes_button);
|
|
|
|
// Set up handlers.
|
|
yes_button.on('click', function () {
|
|
overlays.close_modal('confirm_dialog_modal');
|
|
conf.on_click();
|
|
});
|
|
|
|
confirm_dialog.on('hide', function () {
|
|
confirm_dialog.remove();
|
|
});
|
|
|
|
// Open the modal
|
|
overlays.open_modal('confirm_dialog_modal');
|
|
};
|
|
|
|
window.confirm_dialog = exports;
|