Files
zulip/tools/check-frontend-i18n
Anders Kaseorg 365fe0b3d5 python: Sort imports with isort.
Fixes #2665.

Regenerated by tabbott with `lint --fix` after a rebase and change in
parameters.

Note from tabbott: In a few cases, this converts technical debt in the
form of unsorted imports into different technical debt in the form of
our largest files having very long, ugly import sequences at the
start.  I expect this change will increase pressure for us to split
those files, which isn't a bad thing.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-11 16:45:32 -07:00

54 lines
1.5 KiB
Python
Executable File

#!/usr/bin/env python3
from typing import List
# check for the venv
from lib import sanity_check
sanity_check.check_venv(__file__)
import argparse
import json
import os
import subprocess
import sys
sys.path.append(os.path.join(os.path.dirname(__file__), '..'))
from scripts.lib.zulip_tools import ENDC, FAIL, WARNING
def find_handlebars(translatable_strings: List[str]) -> List[str]:
errored = []
for string in translatable_strings:
if '{{' in string:
errored.append(string)
return errored
if __name__ == '__main__':
parser = argparse.ArgumentParser()
parser.add_argument('--no-generate',
action='store_true', dest='no_generate', default=False,
help="Don't run makemessages command.")
args = parser.parse_args()
if not args.no_generate:
subprocess.call(['./manage.py', 'makemessages', '--locale', 'en'],
stderr=subprocess.STDOUT)
with open('locale/en/translations.json') as f:
data = json.load(f)
found = find_handlebars(list(data.keys()))
if not found:
sys.exit(0)
print(WARNING + "Translation strings contain handlebars:" + ENDC)
print('\n'.join(found))
print(WARNING +
"See https://zulip.readthedocs.io/en/latest/translating/translating.html#frontend-translations "
"on how you can insert variables in the frontend translatable "
"strings." +
ENDC)
print(FAIL + "Failed!" + ENDC)
sys.exit(1)