mirror of
https://github.com/zulip/zulip.git
synced 2025-11-05 06:23:38 +00:00
6de39ae92d
The only reason to use typeof foo === "undefined" is when foo is a global identifier that might not have been declared at all, so it might raise a ReferenceError if evaluated. For a variable declared with const or let or import, a function argument, or a complex expression, simply foo === undefined is equivalent. Some of these conditions have become impossible and can be removed entirely, and some can be replaced more idiomatically with default parameters (note that JavaScript does not share the Python misfeature of evaluating the default parameter at function declaration time). Signed-off-by: Anders Kaseorg <anders@zulip.com>
69 lines
1.8 KiB
JavaScript
69 lines
1.8 KiB
JavaScript
import * as blueslip from "./blueslip";
|
|
import * as hash_util from "./hash_util";
|
|
import * as ui_util from "./ui_util";
|
|
|
|
const state = {
|
|
is_internal_change: false,
|
|
hash_before_overlay: null,
|
|
old_hash: window.location.hash,
|
|
};
|
|
|
|
export function clear_for_testing() {
|
|
state.is_internal_change = false;
|
|
state.hash_before_overlay = null;
|
|
state.old_hash = "#";
|
|
}
|
|
|
|
export function old_hash() {
|
|
return state.old_hash;
|
|
}
|
|
|
|
export function set_hash_before_overlay(hash) {
|
|
state.hash_before_overlay = hash;
|
|
}
|
|
|
|
export function save_old_hash() {
|
|
state.old_hash = window.location.hash;
|
|
|
|
const was_internal_change = state.is_internal_change;
|
|
state.is_internal_change = false;
|
|
|
|
return was_internal_change;
|
|
}
|
|
|
|
export function update(new_hash) {
|
|
const old_hash = window.location.hash;
|
|
|
|
if (!new_hash.startsWith("#")) {
|
|
blueslip.error("programming error: prefix hashes with #: " + new_hash);
|
|
return;
|
|
}
|
|
|
|
if (old_hash === new_hash) {
|
|
// If somebody is calling us with the same hash we already have, it's
|
|
// probably harmless, and we just ignore it. But it could be a symptom
|
|
// of disorganized code that's prone to an infinite loop of repeatedly
|
|
// assigning the same hash.
|
|
blueslip.info("ignoring probably-harmless call to browser_history.update: " + new_hash);
|
|
return;
|
|
}
|
|
|
|
state.old_hash = old_hash;
|
|
state.is_internal_change = true;
|
|
window.location.hash = new_hash;
|
|
}
|
|
|
|
export function exit_overlay() {
|
|
if (hash_util.is_overlay_hash(window.location.hash)) {
|
|
ui_util.blur_active_element();
|
|
const new_hash = state.hash_before_overlay || "#";
|
|
update(new_hash);
|
|
}
|
|
}
|
|
|
|
export function go_to_location(hash) {
|
|
// Call this function when you WANT the hashchanged
|
|
// function to run.
|
|
window.location.hash = hash;
|
|
}
|