mirror of
https://github.com/zulip/zulip.git
synced 2025-11-02 04:53:36 +00:00
4f80823191
Opening settings and stream settings UI was not working for guests if they could not access all users. This was because is_person_active did not handle inaccessible users correctly, if they were not added in the users data, when being called in get_group_members to render group pills.
67 lines
1.6 KiB
JavaScript
67 lines
1.6 KiB
JavaScript
"use strict";
|
|
|
|
const assert = require("node:assert/strict");
|
|
|
|
const _ = require("lodash");
|
|
|
|
const {make_user, make_bot} = require("./lib/example_user.cjs");
|
|
const {mock_esm, zrequire} = require("./lib/namespace.cjs");
|
|
const {run_test} = require("./lib/test.cjs");
|
|
|
|
const people = zrequire("people");
|
|
const {ConversationParticipants} = zrequire("../src/conversation_participants.ts");
|
|
|
|
mock_esm("../src/settings_data", {
|
|
user_can_access_all_other_users: () => true,
|
|
});
|
|
|
|
const user1 = make_user();
|
|
const user2 = make_user();
|
|
const bot1 = make_bot();
|
|
const bot2 = make_bot();
|
|
|
|
people._add_user(user1);
|
|
people._add_user(user2);
|
|
people._add_user(bot1);
|
|
people._add_user(bot2);
|
|
|
|
const human_messages = [
|
|
{
|
|
id: 1,
|
|
sender_id: user1.user_id,
|
|
sent_by_me: true,
|
|
},
|
|
{
|
|
id: 2,
|
|
sender_id: user2.user_id,
|
|
sent_by_me: false,
|
|
},
|
|
];
|
|
|
|
const bot_messages = [
|
|
{
|
|
id: 4,
|
|
sender_id: bot1.user_id,
|
|
sent_by_me: false,
|
|
},
|
|
{
|
|
id: 5,
|
|
sender_id: bot2.user_id,
|
|
sent_by_me: false,
|
|
},
|
|
];
|
|
|
|
const all_messages = [...human_messages, ...bot_messages];
|
|
|
|
run_test("Add participants", () => {
|
|
const participants = new ConversationParticipants(all_messages);
|
|
assert.ok(_.isEqual(participants.humans, new Set([user1.user_id, user2.user_id])));
|
|
assert.ok(_.isEqual(participants.bots, new Set([bot1.user_id, bot2.user_id])));
|
|
// None since they were not added as active users.
|
|
assert.equal(participants.visible().size, 0);
|
|
|
|
// Add user1 as active user.
|
|
people.add_active_user(user1);
|
|
assert.ok(_.isEqual(participants.visible(), new Set([user1.user_id])));
|
|
});
|