paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
4f6cd6577c300d38ec98eba3019e525abe857c27
zulip/static/js
History
sahil839 04ef6ba63a compose: Set wildcard_mention for message before further validation. 
We do not show the warning while sending messages to announce
stream if there is a wildcard mention in the message (i.e.
when wildcard_mention != null)

There are two cases where we should ideally show the warning
but we don't-

 - When there is no wildcard mention in the message and
   wildcard_mention is set to undefined (initial value of
   wildcard_mention).
   This is because "wildcard_mention != null" returns true for
   this case and thus the warning is not shown, assuming the
   message to have wildcard mention.

 - When previous message had a wildcard mention and now a message
   is being sent with no wildcard mention.
   This is because the condition "wildcard_mention != null" is
   checked with the previous value of wildcard_mention and not
   with the value according to current message content, and thus
   the warning is not shown, assuming the message to have wildcard
   mention.

This commit changes the code to set wildcard_mention from the
latest message content before performing other validations and
thus solves the problems described above.
2020-07-07 10:42:55 -07:00
..
analytics
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
billing
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
bundles
CSS: Extract image_upload_widget.scss with all related upload widget CSS.
2020-06-30 10:16:33 -07:00
portico
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
stats
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
types
…
activity.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
admin.js
admin: Remove ".not(can-edit)" selector filter from insert_tip_box.
2020-06-28 14:11:27 -07:00
alert_words_ui.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
alert_words.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
archive.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
attachments_ui.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
avatar.js
avatar: Fix user avatar delete button bug.
2020-07-03 17:32:28 -07:00
blueslip_stacktrace.ts
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
blueslip.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
bot_data.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
buddy_data.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
buddy_list.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
channel.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
click_handlers.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
color_data.js
eslint: Enable arrow-parens.
2020-07-03 16:53:39 -07:00
colorspace.js
…
common.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
components.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
compose_actions.js
compose: Rewrite Zoom video call integration to use OAuth.
2020-06-03 16:39:12 -07:00
compose_fade.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
compose_pm_pill.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
compose_state.js
…
compose_ui.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
compose.js
compose: Set wildcard_mention for message before further validation.
2020-07-07 10:42:55 -07:00
composebox_typeahead.js
timestamp: Extract and improve timerender.get_timestamp_for_flatpickr.
2020-07-06 15:53:56 -07:00
condense.js
…
confirm_dialog.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
copy_and_paste.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
csrf.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
debug.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
drafts.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
dropdown_list_widget.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
echo.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
emoji_picker.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
emoji.js
emoji: Abstract all name_to_codepoint, codepoint_to_name accesses.
2020-05-26 23:33:40 -07:00
emojisets.js
…
favicon.js
…
feature_flags.js
…
feedback_widget.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
fenced_code.js
eslint: Enable arrow-parens.
2020-07-03 16:53:39 -07:00
fetch_status.js
message view: Fetch again when "newest" is discarded.
2020-06-16 11:11:16 -07:00
filter.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
floating_recipient_bar.js
…
fold_dict.ts
…
gear_menu.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
global.d.ts
dead code: Remove integration_bot_widget code.
2020-06-13 15:35:39 -07:00
hash_util.js
message view: Fix link generation logic of the end of results notice.
2020-06-20 16:26:25 -07:00
hashchange.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
hbs.d.ts
…
hotkey.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
hotspots.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
huddle_data.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
i18n.js
…
info_overlay.js
eslint: Enable arrow-parens.
2020-07-03 16:53:39 -07:00
input_pill.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
invite.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
keydown_util.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
lazy_set.js
…
lightbox_canvas.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
lightbox.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
list_cursor.js
list_cursor: Avoid tracebacks.
2020-06-18 09:08:46 -07:00
list_render.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
list_util.js
right sidebar: Remove "GROUP PMs" section.
2020-05-27 17:57:50 -07:00
loading.js
…
local_message.js
…
localstorage.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
markdown_config.js
…
markdown.js
markdown: Remove !avatar() and !gravatar() syntax.
2020-07-07 10:39:44 -07:00
message_edit_history.js
edit_history: Respect time format setting (12h/24h).
2020-06-07 13:57:28 -07:00
message_edit.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
message_events.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
message_fetch.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
message_flags.js
eslint: Enable arrow-parens.
2020-07-03 16:53:39 -07:00
message_list_data.js
message list: Change locally echoed message ids synchronously.
2020-07-06 15:36:33 -07:00
message_list_view.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
message_list.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
message_live_update.js
…
message_scroll.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
message_store.js
pointer: Remove frontend logic tracking furthest_read.
2020-06-18 12:55:59 -07:00
message_util.js
eslint: Enable arrow-body-style.
2020-07-03 16:55:50 -07:00
message_viewport.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
muting_ui.js
recent_topics: Add filter button to show muted topics.
2020-06-09 22:08:31 -07:00
muting.js
…
narrow_state.js
…
narrow.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
navigate.js
pointer: Move planned scroll logic to navigate.js.
2020-06-18 12:55:59 -07:00
night_mode.js
settings: Add automatic theme detection feature.
2020-06-21 01:09:01 -07:00
notifications.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
overlays.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
padded_widget.js
…
page_params.js
…
panels.js
pointer: Stop sending bankruptcy pointer updates.
2020-06-18 12:55:59 -07:00
people.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
pm_conversations.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
pm_list_dom.js
eslint: Enable arrow-body-style.
2020-07-03 16:55:50 -07:00
pm_list.js
…
poll_widget.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
popovers.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
presence.js
code cleanup: Use exports for internal references.
2020-06-11 11:05:06 -07:00
reactions.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
ready.js
…
realm_icon.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
realm_logo.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
recent_senders.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
recent_topics.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
reload_state.js
…
reload.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
reminder.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
rendered_markdown.js
minor: Format comments to be sentences and fix typo.
2020-07-06 15:53:56 -07:00
resize.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
rows.js
rows: Convert valid_table_names from object to Set.
2020-05-26 23:33:40 -07:00
rtl.js
…
schema.js
…
scroll_bar.js
…
scroll_util.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
search_pill_widget.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
search_pill.js
eslint: Enable arrow-parens.
2020-07-03 16:53:39 -07:00
search_suggestion.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
search_util.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
search.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
sent_messages.js
…
server_events_dispatch.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
server_events.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
settings_account.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
settings_bots.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
settings_config.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
settings_data.js
settings org: Use image_upload_widget.hbs for realm day/night logo.
2020-06-17 17:47:49 -07:00
settings_display.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
settings_emoji.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
settings_exports.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
settings_invites.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
settings_linkifiers.js
…
settings_muting.js
…
settings_notifications.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
settings_org.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
settings_panel_menu.js
settings_panel_menu: Remove "settings-wrapper" class from jquery selectors.
2020-07-03 16:48:06 -07:00
settings_profile_fields.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
settings_sections.js
…
settings_streams.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
settings_toggle.js
…
settings_ui.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
settings_user_groups.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
settings_users.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
settings.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
setup.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
spoilers.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
starred_messages.js
…
stream_color.js
date_row: Update color via update_table_stream_color.
2020-07-06 18:37:35 -07:00
stream_create.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
stream_data.js
compose: Modify validate_stream_message to check invalid stream name early.
2020-07-06 15:30:01 -07:00
stream_edit.js
subscriptions: Fix buggy behaviour of click event handlers.
2020-07-06 15:43:41 -07:00
stream_events.js
stream_data: Modify remove_subscriber to use stream id.
2020-06-22 13:39:47 -07:00
stream_list.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
stream_muting.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
stream_popover.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
stream_sort.js
eslint: Enable arrow-parens.
2020-07-03 16:53:39 -07:00
stream_topic_history.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
stream_ui_updates.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
submessage.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
subs.js
subscriptions: Fix scrolling of streams list.
2020-07-06 15:43:41 -07:00
tab_bar.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
templates.js
streams: Format subscriber count according to browser locale.
2020-07-06 11:27:43 -07:00
tictactoe_widget.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
timerender.js
timestamp: Extract and improve timerender.get_timestamp_for_flatpickr.
2020-07-06 15:53:56 -07:00
todo_widget.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
top_left_corner.js
…
topic_generator.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
topic_list_data.js
…
topic_list.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
topic_zoom.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
transmit.js
…
tslint.json
…
tutorial.js
…
typeahead_helper.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
typing_data.js
eslint: Enable arrow-parens.
2020-07-03 16:53:39 -07:00
typing_events.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
typing.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
ui_init.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
ui_report.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
ui_util.js
…
ui.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
unread_ops.js
pointer: Stop sending bankruptcy pointer updates.
2020-06-18 12:55:59 -07:00
unread_ui.js
…
unread.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
upload_widget.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
upload.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
user_events.js
user avatar: Remove image-block id.
2020-06-16 12:12:21 -07:00
user_groups.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
user_pill.js
eslint: Enable arrow-parens.
2020-07-03 16:53:39 -07:00
user_search.js
resize: Resize sidebars when toggling user search.
2020-05-27 17:57:50 -07:00
user_status_ui.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
user_status.js
…
util.js
eslint: Enable prefer-arrow-callback.
2020-07-03 16:55:50 -07:00
vdom.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
widgetize.js
…
zcommand.js
…
zform.js
eslint: Enable comma-dangle for functions.
2020-07-03 16:55:51 -07:00
zulip.js
…