mirror of
https://github.com/zulip/zulip.git
synced 2025-11-06 15:03:34 +00:00
50bfbb588e
get_active_subscriptions_for_stream_id should allow specifying whether subscriptions of deactivated users should be included in the result. Active subs of deactivated users are a subtlety that's easy to miss when writing relevant code, so we make include_deactivated_users a mandatory kwarg - this will force callers to definitely give thought to whether such subs should be included or not. This commit is just a refactoring, we keep original behavior everywhere - there are places where subs of deactivates users should probably be excluded but aren't - we don't fix that here, it'll be addressed in follow-up commits.
34 lines
1.0 KiB
Python
34 lines
1.0 KiB
Python
from typing import Set
|
|
|
|
from django.db.models.query import QuerySet
|
|
|
|
from zerver.lib.stream_subscription import get_active_subscriptions_for_stream_id
|
|
from zerver.models import MutedTopic
|
|
|
|
|
|
class StreamTopicTarget:
|
|
"""
|
|
This class is designed to help us move to a
|
|
StreamTopic table or something similar. It isolates
|
|
places where we are are still using `topic_name` as
|
|
a key into tables.
|
|
"""
|
|
|
|
def __init__(self, stream_id: int, topic_name: str) -> None:
|
|
self.stream_id = stream_id
|
|
self.topic_name = topic_name
|
|
|
|
def user_ids_muting_topic(self) -> Set[int]:
|
|
query = MutedTopic.objects.filter(
|
|
stream_id=self.stream_id,
|
|
topic_name__iexact=self.topic_name,
|
|
).values(
|
|
"user_profile_id",
|
|
)
|
|
return {row["user_profile_id"] for row in query}
|
|
|
|
def get_active_subscriptions(self) -> QuerySet:
|
|
return get_active_subscriptions_for_stream_id(
|
|
self.stream_id, include_deactivated_users=True
|
|
)
|