mirror of
https://github.com/zulip/zulip.git
synced 2025-11-03 13:33:24 +00:00
828759d2ba
This commit replaces the allow_community_topic_editing boolean with integer field edit_topic_policy and includes both frontend and backend changes. We also update settings_ui.disable_sub_settings_onchange to not change the color of label as we did previously when the setting was a checkbox. But now as the setting is dropdown we keep the label as it is and we don't do anything with label when disabling dropdowns. Also, this function was used only here so we can safely change this.
83 lines
2.9 KiB
JavaScript
83 lines
2.9 KiB
JavaScript
import $ from "jquery";
|
|
|
|
import {$t, $t_html} from "./i18n";
|
|
import * as loading from "./loading";
|
|
import * as ui_report from "./ui_report";
|
|
|
|
export function display_checkmark($elem) {
|
|
const check_mark = document.createElement("img");
|
|
check_mark.src = "/static/images/checkbox-green.svg";
|
|
$elem.prepend(check_mark);
|
|
$(check_mark).css("width", "13px");
|
|
}
|
|
|
|
export const strings = {
|
|
success_html: $t_html({defaultMessage: "Saved"}),
|
|
failure_html: $t_html({defaultMessage: "Save failed"}),
|
|
saving: $t({defaultMessage: "Saving"}),
|
|
};
|
|
|
|
// Generic function for informing users about changes to the settings
|
|
// UI. Intended to replace the old system that was built around
|
|
// direct calls to `ui_report`.
|
|
export function do_settings_change(
|
|
request_method,
|
|
url,
|
|
data,
|
|
status_element,
|
|
{
|
|
success_msg_html = strings.success_html,
|
|
failure_msg_html = strings.failure_html,
|
|
success_continuation,
|
|
error_continuation,
|
|
sticky = false,
|
|
error_msg_element,
|
|
} = {},
|
|
) {
|
|
const spinner = $(status_element).expectOne();
|
|
spinner.fadeTo(0, 1);
|
|
loading.make_indicator(spinner, {text: strings.saving});
|
|
const remove_after = sticky ? null : 1000;
|
|
const appear_after = 500;
|
|
|
|
request_method({
|
|
url,
|
|
data,
|
|
success(reponse_data) {
|
|
setTimeout(() => {
|
|
ui_report.success(success_msg_html, spinner, remove_after);
|
|
display_checkmark(spinner);
|
|
}, appear_after);
|
|
if (success_continuation !== undefined) {
|
|
success_continuation(reponse_data);
|
|
}
|
|
},
|
|
error(xhr) {
|
|
if (error_msg_element) {
|
|
loading.destroy_indicator(spinner);
|
|
ui_report.error(failure_msg_html, xhr, error_msg_element);
|
|
} else {
|
|
ui_report.error(failure_msg_html, xhr, spinner);
|
|
}
|
|
if (error_continuation !== undefined) {
|
|
error_continuation(xhr);
|
|
}
|
|
},
|
|
});
|
|
}
|
|
|
|
// This function is used to disable sub-setting when main setting is checked or unchecked
|
|
// or two settings are inter-dependent on their values values.
|
|
// * is_checked is boolean, shows if the main setting is checked or not.
|
|
// * sub_setting_id is sub setting or setting which depend on main setting,
|
|
// string id of setting.
|
|
// * disable_on_uncheck is boolean, true if sub setting should be disabled
|
|
// when main setting unchecked.
|
|
export function disable_sub_setting_onchange(is_checked, sub_setting_id, disable_on_uncheck) {
|
|
if ((is_checked && disable_on_uncheck) || (!is_checked && !disable_on_uncheck)) {
|
|
$(`#${CSS.escape(sub_setting_id)}`).prop("disabled", false);
|
|
} else if ((is_checked && !disable_on_uncheck) || (!is_checked && disable_on_uncheck)) {
|
|
$(`#${CSS.escape(sub_setting_id)}`).prop("disabled", true);
|
|
}
|
|
}
|