Steve Howell 5a8bccfe08 topic_data.js: Refactor topic history internals. ...

This commit introduces a per-stream topic_history class
inside of topic_data.js to better encapsulate how we store topic
history.

To the callers, nothing changes here.  (Some of our non-black-box
node tests change their way of setting up data, though, since the
internal data structures are different.)

The new class has the following improvements:

    * We use message_id instead of timestamp as our sorting key.
      (We could have done this in a prep commit, but it wouldn't
      have made the diff much cleaner here.)

    * We use a dictionary instead of a sorted list to store the
      data, so that writes are O(1) instead of O(NlogN).  Reads
      now do sorts, so they're O(NlogN) instead of O(N), but reads
      are fairly infrequent.  (The main goal here isn't actually
      performance, but instead it just simplifies the
      implementation.)

    * We isolate `topic_history` from the format of the messages.
      This prepares us for upcoming changes where updates to the
      data structure may come from topic history queries as well
      as messages.

    * We split out the message-add path from the message-remove
      path.  This prepares us to eventually get rid of the "count"
      mechanism that is kind of fragile and which has to be
      bypassed for historical topics.

2017-07-27 14:26:22 -07:00

..

portico

Fix: Change .on => .bind.

2017-07-26 17:30:25 -07:00

stats

Change from deprecated $.parseJSON to JSON.parse.

2017-07-27 14:16:57 -07:00

.eslintrc.json

…

activity.js

jQuery: Remove broken use of "removeAttr".

2017-07-24 10:54:47 -07:00

admin_sections.js

Split out Organization Permissions page.

2017-05-18 12:37:03 -07:00

admin.js

org-permissions: Add allow_edit_history organiztion setting.

2017-07-16 10:10:06 -07:00

alert_words_ui.js

alert_words: Fix the UI to not allow users to create duplicate alert words.

2017-06-13 16:37:49 -07:00

alert_words.js

alert_words: Remove the page_params.alert_words after initialization.

2017-06-13 16:36:11 -07:00

attachments_ui.js

attachment: Add file icon to the green box when file has no extension.

2017-03-09 00:56:37 -08:00

avatar.js

Add size limit for uploading user avatars and realm icons.

2017-03-07 22:13:01 -08:00

blueslip.js

Move preview_node() to blueslip.js.

2017-06-07 19:45:46 -05:00

bot_data.js

bots: Add UI to view bot types of existing bots in "Your bots".

2017-06-15 10:08:31 -07:00

channel.js

middleware: Use a proper error code on CSRF failure.

2017-07-25 14:02:12 -07:00

click_handlers.js

overlays: Fix compose box closing when clicking on overlays.

2017-07-22 12:06:00 -07:00

colorspace.js

…

common.js

Enable Hot Module Replacement in webpack.

2017-07-18 11:02:05 -07:00

components.js

i18n: Fix a smattering of strings that weren't getting translated.

2017-07-07 16:59:23 -07:00

compose_actions.js

compose_actions.js: Allow compose to empty narrow.

2017-06-27 14:06:59 -04:00

compose_fade.js

Introduce compose_fade.initialize().

2017-05-24 17:41:40 -07:00

compose_state.js

compose: Distinguish get_message_type() from composing().

2017-04-24 12:42:06 -07:00

compose_ui.js

Break compose.js and drafts.js dependency.

2017-05-08 14:43:49 -07:00

compose.js

compose.js: Prevent sending empty messages in preview mode.

2017-07-25 22:33:22 -04:00

composebox_typeahead.js

emoji: Create tests to check the typeahead resuts.

2017-07-26 09:27:17 -07:00

condense.js

hotkeys: Add collapse/show message hotkey.

2017-06-21 15:54:09 -04:00

copy_and_paste.js

Remove instances of deprecated jQuery "bind".

2017-07-24 10:47:16 -07:00

custom_markdown.js

Remove deprecated jQuery "delegate" function.

2017-07-24 10:47:16 -07:00

debug.js

webpack: Move app_debug.js to webpack bundle.

2017-06-13 12:45:40 -07:00

dict.js

Add Dict.is_empty().

2017-04-21 21:59:22 -07:00

drafts.js

drafts: Re-narrow on restoring draft.

2017-06-25 12:26:42 -04:00

dynamic_text.js

js: Implement DynamicText class.

2017-05-11 17:23:53 -07:00

echo.js

Extract topic_data.js.

2017-07-27 14:26:22 -07:00

emoji_picker.js

emoji: Allow searching of emojis using spaces in emoji picker.

2017-07-26 09:27:17 -07:00

emoji.js

emoji: Rename emoji.realm_emojis to emoji.all_realm_emojis.

2017-07-05 13:02:41 -07:00

favicon.js

…

feature_flags.js

Make local_echo an official feature.

2017-05-09 11:06:10 -07:00

fenced_code.js

Support special characters for code block languages.

2017-06-19 06:53:25 -04:00

filter.js

filter.js: Allow quotes to handle spaces in operand.

2017-07-14 17:33:09 -07:00

floating_recipient_bar.js

Fix outerHeight to OR with 0 to not produce NaN.

2017-07-27 14:16:57 -07:00

gear_menu.js

gear_menu: Fix traceback accessing i18n before it is initialized.

2017-06-02 14:03:56 -07:00

hash_util.js

js dependencies: Split hash_util.js from hashchange.js.

2017-03-18 20:40:34 -07:00

hashchange.js

narrow: Remove redundant from_reload option.

2017-06-15 12:16:27 -07:00

hotkey.js

compose_actions.js: Allow compose to empty narrow.

2017-06-27 14:06:59 -04:00

hotspots.js

hotspots: Change hotspots to have a name and a description.

2017-06-13 12:59:33 -07:00

integration_bot_widget.js

bots: Add a widget file to directly create bot from integration pages.

2017-06-22 11:07:30 -04:00

invite.js

ui-refactor: Rename modals.js to overlays.js.

2017-05-29 11:24:46 -07:00

lightbox.js

ui-refactor: Rename modals.js to overlays.js.

2017-05-29 11:24:46 -07:00

list_rendering.js

Move preview_node() to blueslip.js.

2017-06-07 19:45:46 -05:00

list_util.js

Extract list_util.js for navigating lists.

2017-04-05 11:53:52 -07:00

loading.js

loading-spinner: Fix improper display in upload avatar setting.

2017-04-06 09:06:14 +05:30

localstorage.js

localstorage: Allow regex based delete.

2017-04-26 09:11:44 -07:00

markdown.js

emoji: Change emoji image titles to use spaces instead of underscores.

2017-07-26 09:27:17 -07:00

message_edit.js

eslint: Remove no-new rule.

2017-07-27 11:31:33 -07:00

message_events.js

Extract topic_data.js.

2017-07-27 14:26:22 -07:00

message_fetch.js

message_fetch: Move initialization to ui_init.js.

2017-07-04 13:54:33 -07:00

message_flags.js

Add explicit message field for locally_echoed.

2017-07-21 11:38:25 -07:00

message_list_view.js

message_list_view: Add starred_status to message objs.

2017-06-29 07:39:20 -04:00

message_list.js

Refactor to delete mousewheel.js.

2017-07-03 11:04:20 -04:00

message_live_update.js

avatar live updates: Do full re-render.

2017-02-22 22:46:44 -08:00

message_store.js

Extract topic_data.js.

2017-07-27 14:26:22 -07:00

message_util.js

Revert commits related to client_message_id.

2017-07-14 12:13:35 -07:00

message_viewport.js

Fix outerHeight to OR with 0 to not produce NaN.

2017-07-27 14:16:57 -07:00

muting_ui.js

muting_ui.js: Remove any popups when unmuting.

2017-03-25 12:49:14 -07:00

muting.js

Revert "muting.js: Track muted streams using stream id."

2017-05-17 07:06:32 -07:00

narrow_state.js

narrow.js: Create narrowed_by_stream_reply().

2017-06-27 14:06:59 -04:00

narrow.js

narrow.js: Use the singular 'they' pronoun.

2017-07-05 09:27:43 -07:00

navigate.js

Fix outerHeight to OR with 0 to not produce NaN.

2017-07-27 14:16:57 -07:00

notifications.js

Extract get_local_notify_mix_reason().

2017-07-18 12:11:43 -07:00

overlays.js

frontend: Change inaccurate aria-hidden assignments on buttons.

2017-07-17 16:40:28 -07:00

people.js

people.js: Refactor to split out 'person_matches_query' function.

2017-06-23 08:29:20 -04:00

pm_conversations.js

typeahead: Add pm_conversations module.

2017-06-01 08:05:37 +00:00

pm_list.js

Avoid type errors for bad PM narrows.

2017-06-15 15:52:42 -04:00

pointer.js

Add explicit message field for locally_echoed.

2017-07-21 11:38:25 -07:00

popovers.js

eslint: Remove no-new rule.

2017-07-27 11:31:33 -07:00

presence.js

user_popover: Handle the case when user presence is unknown.

2017-06-19 17:25:06 -04:00

reactions.js

reactions: Simplify markup related to message ids.

2017-07-21 11:38:25 -07:00

realm_icon.js

Add size limit for uploading user avatars and realm icons.

2017-03-07 22:13:01 -08:00

recent_senders.js

typeahead: Add recent_senders module.

2017-06-01 08:05:37 +00:00

reload.js

alerts: Restyle alert banners.

2017-05-16 23:34:45 -07:00

resize.js

Fix outerHeight to OR with 0 to not produce NaN.

2017-07-27 14:16:57 -07:00

rows.js

rows.js: Add get_message_id() helper.

2017-07-21 11:38:25 -07:00

rtl.js

Add rtl.js library for detecting direction of text.

2017-04-22 11:25:54 -07:00

scroll_bar.js

Fix outerHeight to OR with 0 to not produce NaN.

2017-07-27 14:16:57 -07:00

search_suggestion.js

Extract topic_data.js.

2017-07-27 14:26:22 -07:00

search.js

jQuery: Remove broken use of "removeAttr".

2017-07-24 10:54:47 -07:00

server_events_dispatch.js

settings_org: Change update_realm_description to read from page_params.

2017-07-24 17:36:50 -07:00

server_events.js

tornado: Use a machine-readable error code when an event queue is gone.

2017-07-24 16:41:22 -07:00

settings_account.js

urls: Use POST for zerver.views.user_settings.set_avatar_backend.

2017-07-07 10:31:43 -07:00

settings_bots.js

bots UI: Create a new bot switches tab to "Active bots".

2017-07-08 14:30:45 -07:00

settings_display.js

backend: Implement high contrast mode display setting.

2017-07-14 14:53:24 -07:00

settings_emoji.js

emoji: Merge the two semantically same tips on the Custom emoji page.

2017-07-21 13:29:27 -07:00

settings_filters.js

Change from deprecated $.parseJSON to JSON.parse.

2017-07-27 14:16:57 -07:00

settings_lab.js

Extract settings_lab.js.

2017-04-06 11:28:36 -07:00

settings_muting.js

Extract settings_muting.js.

2017-04-06 11:28:36 -07:00

settings_notifications.js

jQuery: Remove broken use of "removeAttr".

2017-07-24 10:54:47 -07:00

settings_org.js

settings_org: Change update_realm_description to read from page_params.

2017-07-24 17:36:50 -07:00

settings_sections.js

admin/settings: Lazy-load Organization sections.

2017-04-17 20:55:42 -07:00

settings_streams.js

typeahead: Remove highlighting and add common template.

2017-06-13 16:16:17 -04:00

settings_users.js

bots: Add 'Bot type' column to bots list in organization settings.

2017-06-20 23:04:46 -04:00

settings.js

i18n: Use double lowdash instead of handlebars.

2017-06-30 10:12:31 -04:00

setup.js

Fix outerHeight to OR with 0 to not produce NaN.

2017-07-27 14:16:57 -07:00

socket.js

local echo: Remove buggy restart-related code.

2017-07-18 12:03:16 -07:00

stream_color.js

refactor: Remove stream_name param in update_stream_color().

2017-03-05 15:44:43 -08:00

stream_create.js

stream_create: Use stream_name as local variable for stream names.

2017-07-07 19:31:47 -07:00

stream_data.js

Extract topic_data.js.

2017-07-27 14:26:22 -07:00

stream_edit.js

jQuery: Remove broken use of "removeAttr".

2017-07-24 10:54:47 -07:00

stream_events.js

Extract narrow_state.js.

2017-04-25 09:57:32 -07:00

stream_list.js

jQuery: Remove broken use of "removeAttr".

2017-07-24 10:54:47 -07:00

stream_muting.js

ui-refactor: Rename modals.js to overlays.js.

2017-05-29 11:24:46 -07:00

stream_popover.js

Extract stream_popover.topic_ops to muting_ui.js.

2017-03-25 09:42:49 -07:00

stream_sort.js

Change argument type for stream_data.is_active().

2017-04-28 07:39:52 -07:00

subs.js

streams-modal: Fix back arrow on streams modal.

2017-06-12 18:31:04 -04:00

tab_bar.js

Fix how we find if streams are muted.

2017-05-15 14:47:41 -07:00

templates.js

templates: Fix typo in error message.

2017-06-26 19:33:25 -04:00

timerender.js

uploads: Only display year uploaded if previous year.

2017-07-25 23:06:58 -07:00

topic_data.js

topic_data.js: Refactor topic history internals.

2017-07-27 14:26:22 -07:00

topic_generator.js

Extract topic_data.js.

2017-07-27 14:26:22 -07:00

topic_list.js

Extract topic_data.js.

2017-07-27 14:26:22 -07:00

translations.js

i18next: Disable i18n cache in development.

2017-07-13 21:37:56 -07:00

tutorial.js

emoji: Change emoji image titles to use spaces instead of underscores.

2017-07-26 09:27:17 -07:00

typeahead_helper.js

typeahead: Use recent_senders/pm_conversations to sort suggestions.

2017-07-09 10:51:19 -04:00

typing_data.js

Extract typing indicator inbound timing logic.

2017-03-22 08:20:21 -07:00

typing_events.js

Add error checking to get_users_typing_for_narrow().

2017-06-15 11:32:13 -04:00

typing_status.js

Extract typing_events.js.

2017-03-22 07:29:42 -07:00

typing.js

compose: Distinguish get_message_type() from composing().

2017-04-24 12:42:06 -07:00

ui_init.js

reactions: Simplify markup related to message ids.

2017-07-21 11:38:25 -07:00

ui_report.js

common.js: Migrate common.js module to use IIFE module style.

2017-06-22 19:06:32 -04:00

ui_util.js

Extract js/ui_util.js.

2017-03-19 11:05:45 -07:00

ui.js

i18n: Fix a smattering of strings that weren't getting translated.

2017-07-07 16:59:23 -07:00

unread_ops.js

refactor: Extract unread_ops.js

2017-03-18 10:35:52 -07:00

unread_ui.js

unread_ui: Wait for i18n setup before rendering.

2017-07-07 16:59:23 -07:00

unread.js

Check for errors in process_read_message().

2017-06-03 06:30:01 -06:00

upload_widget.js

upload-widget: Correct file input clearing.

2017-03-21 00:59:17 -07:00

user_events.js

account-settings: Always display the medium-size avatar.

2017-04-28 23:09:32 -07:00

util.js

util: Remove execute_early.

2017-07-04 13:54:33 -07:00

zulip.js

…