mirror of
https://github.com/zulip/zulip.git
synced 2025-11-04 05:53:43 +00:00
5c0730d7ca
The previous logic did not correctly handle the case where there were realm emoji (non-realm emoji would be inaccessible).
65 lines
2.5 KiB
Python
65 lines
2.5 KiB
Python
from __future__ import absolute_import
|
|
|
|
from django.http import HttpRequest, HttpResponse
|
|
from django.utils.translation import ugettext as _
|
|
from typing import Text
|
|
|
|
from zerver.decorator import authenticated_json_post_view,\
|
|
has_request_variables, REQ, to_non_negative_int
|
|
from zerver.lib.actions import do_add_reaction, do_remove_reaction
|
|
from zerver.lib.bugdown import emoji_list
|
|
from zerver.lib.message import access_message
|
|
from zerver.lib.request import JsonableError
|
|
from zerver.lib.response import json_success
|
|
from zerver.models import Reaction, Realm, UserProfile
|
|
|
|
def check_valid_emoji(realm, emoji_name):
|
|
# type: (Realm, Text) -> None
|
|
if emoji_name in set(realm.get_emoji().keys()):
|
|
return
|
|
if emoji_name in emoji_list:
|
|
return
|
|
raise JsonableError(_("Emoji '%s' does not exist" % (emoji_name,)))
|
|
|
|
@has_request_variables
|
|
def add_reaction_backend(request, user_profile, message_id, emoji_name):
|
|
# type: (HttpRequest, UserProfile, int, Text) -> HttpResponse
|
|
|
|
# access_message will throw a JsonableError exception if the user
|
|
# cannot see the message (e.g. for messages to private streams).
|
|
message = access_message(user_profile, message_id)[0]
|
|
|
|
check_valid_emoji(message.sender.realm, emoji_name)
|
|
|
|
# We could probably just make this check be a try/except for the
|
|
# IntegrityError from it already existing, but this is a bit cleaner.
|
|
if Reaction.objects.filter(user_profile=user_profile,
|
|
message=message,
|
|
emoji_name=emoji_name).exists():
|
|
raise JsonableError(_("Reaction already exists"))
|
|
|
|
do_add_reaction(user_profile, message, emoji_name)
|
|
|
|
return json_success()
|
|
|
|
@has_request_variables
|
|
def remove_reaction_backend(request, user_profile, message_id, emoji_name):
|
|
# type: (HttpRequest, UserProfile, int, Text) -> HttpResponse
|
|
|
|
# access_message will throw a JsonableError exception if the user
|
|
# cannot see the message (e.g. for messages to private streams).
|
|
message = access_message(user_profile, message_id)[0]
|
|
|
|
check_valid_emoji(message.sender.realm, emoji_name)
|
|
|
|
# We could probably just make this check be a try/except for the
|
|
# IntegrityError from it already existing, but this is a bit cleaner.
|
|
if not Reaction.objects.filter(user_profile=user_profile,
|
|
message=message,
|
|
emoji_name=emoji_name).exists():
|
|
raise JsonableError(_("Reaction does not exist"))
|
|
|
|
do_remove_reaction(user_profile, message, emoji_name)
|
|
|
|
return json_success()
|