mirror of
https://github.com/zulip/zulip.git
synced 2025-11-11 09:27:43 +00:00
02511bff1c
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
118 lines
2.8 KiB
JavaScript
118 lines
2.8 KiB
JavaScript
zrequire('message_events');
|
|
zrequire('message_store');
|
|
zrequire('people');
|
|
zrequire('util');
|
|
|
|
set_global('alert_words', {});
|
|
set_global('condense', {});
|
|
set_global('current_msg_list', {});
|
|
set_global('message_edit', {});
|
|
set_global('message_list', {});
|
|
set_global('notifications', {});
|
|
set_global('page_params', {});
|
|
set_global('pm_list', {});
|
|
set_global('stream_list', {});
|
|
set_global('unread_ui', {});
|
|
|
|
alert_words.process_message = () => {};
|
|
|
|
const alice = {
|
|
email: 'alice@example.com',
|
|
user_id: 32,
|
|
full_name: 'Alice Patel',
|
|
};
|
|
|
|
people.add(alice);
|
|
|
|
function test_helper(side_effects) {
|
|
const events = [];
|
|
|
|
for (const side_effect of side_effects) {
|
|
const parts = side_effect.split('.');
|
|
const module = parts[0];
|
|
const field = parts[1];
|
|
|
|
global[module][field] = () => {
|
|
events.push(side_effect);
|
|
};
|
|
}
|
|
|
|
const self = {};
|
|
|
|
self.verify = () => {
|
|
assert.deepEqual(side_effects, events);
|
|
};
|
|
|
|
return self;
|
|
}
|
|
|
|
run_test('update_messages', () => {
|
|
const original_message = {
|
|
id: 111,
|
|
sender_id: alice.user_id,
|
|
};
|
|
|
|
message_store.add_message_metadata(original_message);
|
|
|
|
const events = [
|
|
{
|
|
message_id: 111,
|
|
flags: [],
|
|
orig_content: 'old stuff',
|
|
content: '**new content**',
|
|
rendered_content: '<b>new content</b>',
|
|
},
|
|
];
|
|
|
|
current_msg_list.get_row = (message_id) => {
|
|
assert.equal(message_id, 111);
|
|
return ['row-stub'];
|
|
};
|
|
current_msg_list.view = {};
|
|
|
|
let rendered_mgs;
|
|
|
|
current_msg_list.view.rerender_messages = (msgs_to_rerender, message_content_edited) => {
|
|
rendered_mgs = msgs_to_rerender;
|
|
assert.equal(message_content_edited, true);
|
|
};
|
|
|
|
const side_effects = [
|
|
'condense.un_cache_message_content_height',
|
|
'message_edit.end',
|
|
'notifications.received_messages',
|
|
'unread_ui.update_unread_counts',
|
|
'stream_list.update_streams_sidebar',
|
|
'pm_list.update_private_messages',
|
|
];
|
|
|
|
const helper = test_helper(side_effects);
|
|
|
|
page_params.realm_allow_edit_history = false;
|
|
message_list.narrowed = 'stub-to-ignore';
|
|
|
|
// TEST THIS:
|
|
message_events.update_messages(events);
|
|
|
|
helper.verify();
|
|
|
|
assert.deepEqual(rendered_mgs, [
|
|
{
|
|
alerted: false,
|
|
content: '<b>new content</b>',
|
|
id: 111,
|
|
last_edit_timestamp: undefined,
|
|
mentioned: false,
|
|
mentioned_me_directly: false,
|
|
raw_content: '**new content**',
|
|
reactions: [],
|
|
sender_email: 'alice@example.com',
|
|
sender_full_name: 'Alice Patel',
|
|
sender_id: 32,
|
|
sent_by_me: false,
|
|
topic: undefined,
|
|
},
|
|
]);
|
|
|
|
});
|