Files
zulip/frontend_tests/zjsunit/zblueslip.js
Anders Kaseorg 719546641f js: Convert a.indexOf(…) !== -1 to a.includes(…).
Babel polyfills this for us for Internet Explorer.

import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import K from "ast-types/gen/kinds";
import fs from "fs";
import path from "path";
import process from "process";

const checkExpression = (node: n.Node): node is K.ExpressionKind =>
  n.Expression.check(node);

for (const file of process.argv.slice(2)) {
  console.log("Parsing", file);
  const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
    parser: path.extname(file) === ".ts" ? tsParser : babelParser,
  });
  let changed = false;

  recast.visit(ast, {
    visitBinaryExpression(path) {
      const { operator, left, right } = path.node;
      if (
        n.CallExpression.check(left) &&
        n.MemberExpression.check(left.callee) &&
        !left.callee.computed &&
        n.Identifier.check(left.callee.property) &&
        left.callee.property.name === "indexOf" &&
        left.arguments.length === 1 &&
        checkExpression(left.arguments[0]) &&
        ((["===", "!==", "==", "!=", ">", "<="].includes(operator) &&
          n.UnaryExpression.check(right) &&
          right.operator == "-" &&
          n.Literal.check(right.argument) &&
          right.argument.value === 1) ||
          ([">=", "<"].includes(operator) &&
            n.Literal.check(right) &&
            right.value === 0))
      ) {
        const test = b.callExpression(
          b.memberExpression(left.callee.object, b.identifier("includes")),
          [left.arguments[0]]
        );
        path.replace(
          ["!==", "!=", ">", ">="].includes(operator)
            ? test
            : b.unaryExpression("!", test)
        );
        changed = true;
      }
      this.traverse(path);
    },
  });

  if (changed) {
    console.log("Writing", file);
    fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
  }
}

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-10 14:08:12 -08:00

86 lines
2.5 KiB
JavaScript

exports.make_zblueslip = function () {
const lib = {};
const opts = {
// Silently swallow all debug, log and info calls.
debug: false,
log: false,
info: false,
// Check against expected error values for the following.
warn: true,
error: true,
fatal: true,
};
// Store valid test data for options.
lib.test_data = {};
lib.test_logs = {};
Object.keys(opts).forEach(name => {
lib.test_data[name] = [];
lib.test_logs[name] = [];
});
lib.set_test_data = (name, message) => {
lib.test_data[name].push(message);
};
lib.clear_test_data = (name) => {
if (!name) {
// Clear all data
Object.keys(opts).forEach(name => {
lib.test_data[name] = [];
lib.test_logs[name] = [];
});
return;
}
lib.test_data[name] = [];
lib.test_logs[name] = [];
};
lib.get_test_logs = (name) => {
return lib.test_logs[name];
};
lib.check_error = (isblueslip = false) => {
return function (error) {
if (isblueslip) {
assert(error.blueslip, "Not a blueslip error.");
return true;
}
// If an error was thrown by zblueslip, we know that that
// error was not in the list of expeccted errors for the test.
assert(!error.blueslip, "Error not in expected errors.");
return true;
};
};
// Create logging functions
Object.keys(opts).forEach(name => {
if (!opts[name]) {
// should just log the message.
lib[name] = function (message, more_info, stack) {
lib.test_logs[name].push({message, more_info, stack});
};
return;
}
lib[name] = function (message, more_info, stack) {
lib.test_logs[name].push({message, more_info, stack});
const exact_match_fail = !lib.test_data[name].includes(message);
const string_match_fail = !lib.test_data[name].includes(message.toString());
if (exact_match_fail && string_match_fail) {
const error = Error(`Invalid ${name} message: "${message}".`);
error.blueslip = true;
throw error;
}
};
});
lib.exception_msg = function (ex) {
return ex.message;
};
lib.start_timing = () => {
return () => {};
};
return lib;
};